From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out198-16.us.a.mail.aliyun.com (out198-16.us.a.mail.aliyun.com [47.90.198.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAB9C288510 for ; Sat, 6 Dec 2025 10:48:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=47.90.198.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765018085; cv=none; b=B71aQhvma5I08rIUVjnWRv6iGEUpV65pAoOA2f8GJ+Oj0Hq8LM0a4uhLpK4P22zMEbKWc21KW736PGcsxM6yFMa3ryytu70aVZHPXQKGIMi2x8yzm0zF8ykqwhgDo7iqeuFId7Dqk03CJTV1lOFEZS4wAAbK65vXiJA+mRMrjtE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765018085; c=relaxed/simple; bh=YwiNLCp9P2wX3cLj55n8uzZ2ceUUnCObCqqdXtJd2a8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pGH99DtrnKOnDOmAJmqwkRlThT/8HodCOCfHSRvykyqdOGT2udvceVWF5J9J5zQzx7d+HAoAk44cMWHWZisjH+cpNP8eJwovaqcKCXf8zxl0D4RoMHhMeKh333CCcazsuJAdrNU+7TyAFlUaphaDnD7wPpkQ2prl+t5mP/mPkYQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=open-hieco.net; spf=pass smtp.mailfrom=open-hieco.net; arc=none smtp.client-ip=47.90.198.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=open-hieco.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=open-hieco.net Received: from 172.18.26.4(mailfrom:shenxiaochen@open-hieco.net fp:SMTPD_---.feEcT1Q_1765018060 cluster:ay29) by smtp.aliyun-inc.com; Sat, 06 Dec 2025 18:47:42 +0800 Message-ID: Date: Sat, 6 Dec 2025 18:47:40 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] x86/resctrl: Add missing resctrl initialization for Hygon To: Fenghua Yu , tony.luck@intel.com, reinette.chatre@intel.com, bp@alien8.de Cc: babu.moger@amd.com, james.morse@arm.com, Dave.Martin@arm.com, x86@kernel.org, linux-kernel@vger.kernel.org, shenxiaochen@open-hieco.net References: <20251204023750.994143-1-shenxiaochen@open-hieco.net> <20251204023750.994143-2-shenxiaochen@open-hieco.net> Content-Language: en-US From: Xiaochen Shen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Fenghua, Thank you very much for code review! On 12/6/2025 11:30 AM, Fenghua Yu wrote: >> Add the missing AMD/Hygon common initialization to ensure proper >> Platform QoS functionality on Hygon CPUs. >> >> Fixes: d8df126349da ("x86/cpu/hygon: Add missing resctrl_cpu_detect() in bsp_init helper") > > This commit triggers the issue on Hygon. You may keep this fix. > Sure. Thank you! >> Fixes: 923f3a2b48bd ("x86/resctrl: Query LLC monitoring properties once during boot") > This commit just calls resctrl_cpu_detect() on AMD and Intel. The commit itself doesn't have an issue. Remove this Fixes? > Yes, you are correct. I will remove this Fixes: tag as you suggested. Thank you! >> Cc: stable@vger.kernel.org > Thanks. > > -Fenghua Best regards, Xiaochen Shen