From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761369AbdDSJBM (ORCPT ); Wed, 19 Apr 2017 05:01:12 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:60106 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761149AbdDSJBI (ORCPT ); Wed, 19 Apr 2017 05:01:08 -0400 X-AuditID: b6c32a59-f79166d0000017ce-4e-58f72752711d Subject: Re: [PATCH] usb: gadget: remove redundant self assignment To: Stefan Agner , balbi@kernel.org Cc: gregkh@linuxfoundation.org, peter.chen@nxp.com, yoshihiro.shimoda.uh@renesas.com, colin.king@canonical.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Krzysztof Opasiak Message-id: Date: Wed, 19 Apr 2017 11:01:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-version: 1.0 In-reply-to: <20170417031250.407-1-stefan@agner.ch> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIKsWRmVeSWpSXmKPExsWy7bCmlm6Q+vcIg/P9ohbH2p6wW/xe3ctm 0bx4PZvF5V1z2CwWLWtltvhz7w6rxeZ17ewWX/d+ZnPg8Fj8/R6zx6yGXjaPTas62Tz2z13D 7rHx3Q4mj29nJrJ4fN4kF8AexWWTkpqTWZZapG+XwJXR0mlasJa9ov/YbKYGxresXYycHBIC JhLfv+1hh7DFJC7cW8/WxcjFISSwlFFi7vNrjBBOO5PE/Tdz2WE6Wt5sZYdIzGGU6OmfCtVy n1Gib+F5sCphASeJC7shbBGgjt0TzoHtYxZYzSjx8blcFyMHB5uAvsS8XaIgYV4BO4lZXw+C lbMIqEp82H+KFaREVCBCov+MOkSJoMSPyfdYQGxOAWOJe+2XoSY6SjxYtBPKlpfYvOYtM8g5 EgK72CU2733GBDJHQkBWYtMBZoj7XSTmz33EBmELS7w6vgXqL2mJv0tvMUL0NjNKdOx5xgLh TGCU2LbuEFSVtcSfVRPZILbxSfT+fgK1gFeio00IosRDonnbB6hyR4mVWyZBw6eNUeL5wdPM ExjlZyF5aBaSJ2YheWIBI/MqRrHUguLc9NRi0wJTveLE3OLSvHS95PzcTYzghKMVuYPxysyg Q4wCHIxKPLwG4t8ihFgTy4orcw8xSnAwK4nwnlb6HiHEm5JYWZValB9fVJqTWnyIUZqDRUmc V2PltQghgfTEktTs1NSC1CKYLBMHp1QDo8zeffm3J4sfOdp/g+Pi1uAjCpEyuxq9xPaZsxQy rnx4cPqmrkMXf+2/rHSz77FT+Zam24tiXwavf8o/8/WO2a1bT1e3hM9w/dCl902hROnVw13J 6gtv/nGTvZK5taOnvvTt5gnZ954KtOr5dqn+Kq7mXz1/4or2HRt2bfFSWnfG0IjtB5fdFTUl luKMREMt5qLiRABbby6/NAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCIsWRmVeSWpSXmKPExsVy+t9jQd1A9e8RBl//alkca3vCbvF7dS+b RfPi9WwWl3fNYbNYtKyV2eLPvTusFpvXtbNbfN37mc2Bw2Px93vMHrMaetk8Nq3qZPPYP3cN u8fGdzuYPL6dmcji8XmTXAB7lJtNRmpiSmqRQmpecn5KZl66rVJoiJuuhZJCXmJuqq1ShK5v SJCSQlliTimQZ2SABhycA9yDlfTtEtwyWjpNC9ayV/Qfm83UwPiWtYuRk0NCwESi5c1Wdghb TOLCvfVsXYxcHEICsxglbjw/AOU8ZJTYNP8+WIewgJPEhd3nwTpEgLp3TzjHClHUwSjRvukc E4jDLLCaUeLftmOMXYwcHGwC+hLzdomCNPAK2EnM+noQrJlFQFXiw/5TYENFBSIkbj3sYIGo EZT4MfkemM0pYCxxr/0yWA2zgK3EgvfrWCBseYnNa94yT2AEuhOhZRaSsllIyhYwMq9ilEgt SC4oTkrPNcpLLdcrTswtLs1L10vOz93ECI7BZ9I7GA/vcj/EKMDBqMTDayD+LUKINbGsuDL3 EKMEB7OSCO9ppe8RQrwpiZVVqUX58UWlOanFhxhNgR6ZyCwlmpwPTA95JfGGJuYm5sYGFuaW liZGSuK8jbOfhQsJpCeWpGanphakFsH0MXFwSjUwikwyFF035/Npt/qbXZODp+3kUzzEzpK8 YUXHBi7vfbXHha8cN+yoYd5e55774qzvD93dC3ifXHcN39q0e0bSy+LPt2ZLB/B+klE+dvux FvvX28uKu50KjO+4zT/1tjrGfSJzT8+5WsvMf3/PN++zZsqdJHZxzmfOp946GVs/+1e/25RZ UHB1khJLcUaioRZzUXEiAOMkpa7XAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170419090105epcas5p3ccae4abb6355d2bd8636f3cee04491dc X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?S3J6eXN6dG9mIE9wYXNpYWsbU1JQT0wtU3lzdGVtIChUUCkb?= =?UTF-8?B?7IK87ISx7KCE7J6QG1NvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?S3J6eXN6dG9mIE9wYXNpYWsbU1JQT0wtU3lzdGVtIChUUCkb?= =?UTF-8?B?U2Ftc3VuZ8KgRWxlY3Ryb25pY3MbU29mdHdhcmUgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTY=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20170417031117epcas5p3cba067df249c6f0fcfad0eb09eb20040 X-RootMTR: 20170417031117epcas5p3cba067df249c6f0fcfad0eb09eb20040 References: <20170417031250.407-1-stefan@agner.ch> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/17/2017 05:12 AM, Stefan Agner wrote: > The assignment ret = ret is redundant and can be removed. > > Signed-off-by: Stefan Agner > --- > A very similar patch has been applied already last year, but there is > a second such assignment... > > -- > Stefan > > drivers/usb/gadget/udc/core.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c > index d685d82dcf48..b57bd53812fe 100644 > --- a/drivers/usb/gadget/udc/core.c > +++ b/drivers/usb/gadget/udc/core.c > @@ -139,10 +139,8 @@ int usb_ep_disable(struct usb_ep *ep) > goto out; > > ret = ep->ops->disable(ep); > - if (ret) { > - ret = ret; > + if (ret) > goto out; > - } > > ep->enabled = false; > > Reviewed-by: Krzysztof Opasiak -- Krzysztof Opasiak Samsung R&D Institute Poland Samsung Electronics