mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Andrew Morton <akpm@linux-foundation.org>,
	ljs@kernel.org, pfalcato@suse.de, vbabka@kernel.org,
	Marco Elver <elver@google.com>,
	Brendan Jackman <jackmanb@google.com>,
	Suren Baghdasaryan <surenb@google.com>
Cc: linux-kernel@vger.kernel.org, Shuah Khan <skhan@linuxfoundation.org>
Subject: Duplicate headers in tools/testing/shared directory diverged - rcupdate.h
Date: Wed, 15 Apr 2026 10:39:05 -0600	[thread overview]
Message-ID: <e233992e-27c2-43d4-9225-ed8c33203ee4@linuxfoundation.org> (raw)

All,

I am sending this email to you all because you touched tools/testing/shared
and its sub directories and show up in

get_maintainer.pl -f tools/testing/shared/ output

rbtree compile failed as it couldn't find urcu.h

cc -I../shared -I. -I../../include -I../../arch/x86/include -I../../../lib -g -Og -Wall -D_LGPL_SOURCE -fsanitize=address -fsanitize=undefined    -c -o rbtree_test.o rbtree_test.c
In file included from ../shared/shared.h:11,
                  from rbtree_test.c:9:
../shared/linux/rcupdate.h:5:10: fatal error: urcu.h: No such file or directory
     5 | #include <urcu.h>
       |          ^~~~~~~~
compilation terminated.

This sent me down the path to look at the duplicate headers in tools/testing/shared
especially rcupdate.h which is under tools/testing/shared/linux

It appears this file is an exact copy of include/linux/rcupdate.h and now it
diverged. Why do we have these duplicate headers here in this shared
directory - it appears they are out of date and lead to maintenance problems.

thanks,
-- Shuah

             reply	other threads:[~2026-04-15 16:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-15 16:39 Shuah Khan [this message]
2026-04-15 16:49 ` Marco Elver
2026-04-15 16:50 ` Lorenzo Stoakes
2026-04-15 17:00   ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e233992e-27c2-43d4-9225-ed8c33203ee4@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=elver@google.com \
    --cc=jackmanb@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ljs@kernel.org \
    --cc=pfalcato@suse.de \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®