From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCC4EC77B73 for ; Wed, 24 May 2023 13:24:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231281AbjEXNYM (ORCPT ); Wed, 24 May 2023 09:24:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233337AbjEXNXv (ORCPT ); Wed, 24 May 2023 09:23:51 -0400 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1DBAE9; Wed, 24 May 2023 06:23:49 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id B89263200201; Wed, 24 May 2023 09:23:45 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Wed, 24 May 2023 09:23:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1684934625; x=1685021025; bh=ra B7OJ7UdVre69aPRy4rO+ZRGCd+zuLQcF+Qv/YoZG8=; b=KeN+SZ3c314DpYLTMq MBBXznHtrN2C+qFdeSIJq3xOBZ0k29HIC+Xtw6daL+hf9K5z8EyWyGcHGyo5bmux Ade06pXwCVbRZWyrqwUq5i0SeM2ZORXKbW6F4p1ybuaWErf4zIxhdFC1nm0s74Kj MvDP4siVQQD9P2pBX3hkTL76qx5cTU8LMrn2s+69+M+NEFuK03eSspFgs/6LjBz5 19WiTORXXhHSrwaT2puNtkAdy1QUAINDeyCu7skj3fk5mwwxbiqrxAYR+B2WqYv8 +xBr1qCJgSrnU+YINARYe94FeBkRVNkPyeoFXqAj9fgf757atGqCTiBDlzoDVQ2r mjhg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1684934625; x=1685021025; bh=raB7OJ7UdVre6 9aPRy4rO+ZRGCd+zuLQcF+Qv/YoZG8=; b=E6pqQAcWCmgAa1czwjMCpTyu9whwy 2M4I2KVD0Gae7jhhVOV6WiZr5W18owt4YYHKsYbM2Gwxp0y6qo2/61S5ZSkNQEss mt8SOKFwkTygqSrZfXDHt43AyQ+YrVTxCd5xjVJ6jQKE5I0IGTtEUJUWUjshUnkP /J2PJB20kSXTbytywZ1xdNLIHQH2wkmOLFllRXlfxDu1pWMQKGywc5Gsw8SDjInE B7A7N6TAS8nE0msYcUYN3UKjqZFTMkdcpJ8WMsEivMAw4tZ+KdMx6PIXkQQIq/cO bttJROhbaE9nn8auKbIakqIJWmvFZIK5mH3K0sQdSP1P+y0m+tm+GzD2g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeejhedgiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id C5888B60086; Wed, 24 May 2023 09:23:44 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-441-ga3ab13cd6d-fm-20230517.001-ga3ab13cd Mime-Version: 1.0 Message-Id: In-Reply-To: References: <20230523194930.2116181-1-arnd@kernel.org> Date: Wed, 24 May 2023 15:23:24 +0200 From: "Arnd Bergmann" To: "Yonghong Song" , "Arnd Bergmann" , "Alexei Starovoitov" , "Daniel Borkmann" , "Andrii Nakryiko" Cc: "John Fastabend" , "Martin KaFai Lau" , "Song Liu" , "Yonghong Song" , "KP Singh" , "Stanislav Fomichev" , "Hao Luo" , "Jiri Olsa" , "Jason A . Donenfeld" , bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] [v2] bpf: hide unused bpf_patch_call_args Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 24, 2023, at 05:05, Yonghong Song wrote: > On 5/23/23 12:43 PM, Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> This function has no callers and no declaration when CONFIG_BPF_JIT_ALWAYS_ON >> is enabled: >> >> kernel/bpf/core.c:2075:6: error: no previous prototype for 'bpf_patch_call_args' [-Werror=missing-prototypes] > > If CONFIG_BPF_JIT_ALWAYS_ON is enabled, the definition of > bpf_patch_call_args should be invisible. Maybe I missed something. > Could you list *ALL& bpf related config options in your setup > so people can reproduce you above error messages? Sorry, my mistake. I've reworded the changelog now to fix this: | This function is only used when CONFIG_BPF_JIT_ALWAYS_ON is disabled, | but CONFIG_BPF_SYSCALL is enabled. When both are turned off, the | prototype is missing but the unused function is still compiled, | as seen from this W=1 warning: | | kernel/bpf/core.c:2075:6: error: no previous prototype for 'bpf_patch_call_args' [-Werror=missing-prototypes] | | Add a matching #ifdef for the definition to leave it out. If this makes sense now, I'll send out a v3. Arnd