From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 864F7283C9D for ; Tue, 11 Aug 2026 12:57:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786453057; cv=none; b=KqjZw37lMoBsySGOdDJlGSpElaeAETvozKQXxkEExlmuIXUGFQDM5Xk3UquPQnuf0CBl2l2pBdwaJfeTk0VuQWqzffRhxyBNSjiHsPNPTUw0hBKxePmm53PET2mUfa9JGQYrVPQhp2OMm67lW5VMMV/iDCjchCiLJW0DF7RAsGo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786453057; c=relaxed/simple; bh=gYdofRMujdzQOFJaSBNLQz1thCmXMhJyHxwSQzIPFr4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Uiawqec21hPD1Z2RGoq3QPZWKTqZ84x9LPbmodbwd4n61tvl6WG71O+j8jr7Z4KEMs+jo8nOCCtkeHtVHLB1QpgEXcHbMxdjiKzU8A21s0Rv7z1eFmJpprTLzy3hcwNes3FQUlsKN1q65hHoxY5k+cvbpgnNPFBx9fe1tWtIv2Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=O3ZvTKrl; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=AxGd4kHJ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="O3ZvTKrl"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="AxGd4kHJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786453054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0frBHjd61EyLYz0mPRsCOHDWT5ZKOwhF/npWzCbt6wI=; b=O3ZvTKrlbixLglNzN7m0uFmLSQZHNLgRP6AgfYnoLAwqOu4VqqN3Z3e3Mp0dtdX6DxEmU4 GfX8joZTB6AU40SF59M/5ZAmgbwyDS0vHETzMUbBBHZcvYFmjn3kmVgoEEt6lo29WSCGr6 +sSidl5ShexO/ku4pb7OwmSLG2Joxg4= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-272-I_y4vDJjNkuvf7vmVmNOOw-1; Tue, 11 Aug 2026 08:57:33 -0400 X-MC-Unique: I_y4vDJjNkuvf7vmVmNOOw-1 X-Mimecast-MFC-AGG-ID: I_y4vDJjNkuvf7vmVmNOOw_1786453052 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-47fd4ee0ac0so2368370f8f.2 for ; Tue, 11 Aug 2026 05:57:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1786453052; x=1787057852; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=0frBHjd61EyLYz0mPRsCOHDWT5ZKOwhF/npWzCbt6wI=; b=AxGd4kHJYRjjTPJLLkth7ToNFMT5ZKZJ0Eu6qy8eEvX46afijUXEZAnSKPR9+reldX wxwDvlMdaDmLNQxB0lVhchvOb7L8cfeSl1boSkT5VnpDbldoJUZ9uKjqZYnQ5Uh1hZCL KkOK0Kv4vDdWZTMNoaWEce005ELoAoAEQ1ZRqG+Grh8VJGNzsbJdgz9BzRFbtSO+z0WP mcRM7gTCe8FRoHJLa/UItkwwIbGGNIHh02azI5GAlcFhFHFmjfo7RjEpKsRczQZHiy3Y 055FAVxJk3Nk3AzQai3pTwYfdwFgAUejayWcYYExY3GkOT6wjytpggqoYnXQrmA51DSc qLHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786453052; x=1787057852; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=0frBHjd61EyLYz0mPRsCOHDWT5ZKOwhF/npWzCbt6wI=; b=cOfCHa0pE2HtCmCImL1nPCKbsui3tqnWmyiVPHN0uYpHItfFKhA5m9BAaegs67VhHt WxPszogdfC0XlWwsDQqtlx+tkojRfNDEasKor9eAtBvhdXNvbcvMPrG5tX2+KCDYIceh 0N6e8yi1vYx3m+Xie3YzkNMQpFfJCxbi3pNa7/wDMXvISWZZHIF3oawbWE+M0nmFuHIC fj/I+Ih3VjhHWZqbJAeSMg24jm0HQkPRpuiZ9huYe28rnjuu8iFtPCbspU28wrYwAUWN fdlAOTwAfm7RNCEXdAm3Jnay3HdLoT0GrEVQPQtzQOFA3duUe1mvjfIs+FAJZzqOqLci Tglg== X-Forwarded-Encrypted: i=1; AHgh+RppSvbZtNMeh/D8f18eePmKPNvXzHbElu6ex0RRtbZ60I61n9ZHtYx0i4Ldo8iZo1MB+2p/a0eLOwV4n7Y=@vger.kernel.org X-Gm-Message-State: AOJu0YzqDgEomEEagzy470YEZBz9g8IqmgXUjswgYZbJN9Nfe/w4+H+U 78QdH4lryCOpzggpu+4tpbyN+8/+S7+eIMbAUB28FmAecI9Qi9meZrljHAZtL408+1g5k0og4k5 yipSqiDqNgjGO1/0x5hzli88ShdRpfBtpoCMhW28Fbr3WccmMQhh4nYZ1lkNsUPiHqsjQqPQaBQ == X-Gm-Gg: AR+sD132fV93MFq8jZoj1L2EPGU2LVTAR32q+X1QhGKd054vegiFx1P32GnD1/I0fdy IrKCK1p4ru0uFArEL32/oYDStWU3R5APcdfrXnyqVfUGfO1rGsqVwkwbitDvvpyj6UxOHrGhXQj /jw+74Gmm3q2vL5j0GIzEdB3l/w7FmyM3IOjMlAO6vu57ru+gYbO8uiRDS0snJ7Y7HQEfHYmS6P DBpsYl5F+ihYYh0IpgqivvhJr/F5ctEEjgz4Z/6Drwe4eB8QuTcBCm8XTu7Tkq8nzz5gP9njPSn rAFxb78R+L5GNv9vtDpToRA6UwsTWsNDeuF1XJDUoIwMvh187llBMEqQIua5475Zm9QGMIBD X-Received: by 2002:a05:6000:4a19:b0:47f:ec8a:214f with SMTP id ffacd0b85a97d-4814adc3281mr5811655f8f.15.1786453051971; Tue, 11 Aug 2026 05:57:31 -0700 (PDT) X-Received: by 2002:a05:6000:4a19:b0:47f:ec8a:214f with SMTP id ffacd0b85a97d-4814adc3281mr5811584f8f.15.1786453051613; Tue, 11 Aug 2026 05:57:31 -0700 (PDT) Received: from [192.168.0.9] ([47.64.114.24]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4814a709361sm4217694f8f.20.2026.08.11.05.57.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Aug 2026 05:57:30 -0700 (PDT) Message-ID: Date: Tue, 11 Aug 2026 14:57:28 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/6] smb: clear the aes_cmac_key and aes_cmac_ctx when done To: Namjae Jeon Cc: Eric Biggers , Steve French , Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Sergey Senozhatsky , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org References: <20260807125845.1477067-1-thuth@redhat.com> <20260807125845.1477067-3-thuth@redhat.com> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/08/2026 12.31, Namjae Jeon wrote: >> diff --git a/fs/smb/client/smb2transport.c b/fs/smb/client/smb2transport.c >> index 1143ee52470a7..d23566da2ac81 100644 >> --- a/fs/smb/client/smb2transport.c >> +++ b/fs/smb/client/smb2transport.c >> @@ -464,8 +464,8 @@ smb3_calc_signature(struct smb_rqst *rqst, struct TCP_Server_Info *server) >> unsigned char smb3_signature[SMB2_CMACAES_SIZE]; >> struct kvec *iov = rqst->rq_iov; >> struct smb2_hdr *shdr = (struct smb2_hdr *)iov[0].iov_base; >> - struct aes_cmac_key cmac_key; >> - struct aes_cmac_ctx cmac_ctx; >> + struct aes_cmac_key cmac_key __cleanup(aes_cmac_zeroize_key); >> + struct aes_cmac_ctx cmac_ctx __cleanup(aes_cmac_zeroize_ctx); >> struct smb_rqst drqst; >> u8 key[SMB3_SIGN_KEY_SIZE]; > Shouldn’t we also clear the raw key with memzero_explicit(key, > sizeof(key)) immediately after aes_cmac_preparekey() ? > > rc = aes_cmac_preparekey(&cmac_key, key, SMB2_CMACAES_SIZE); > + memzero_explicit(key, sizeof(key)); > if (rc) { > cifs_server_dbg(VFS, "%s: Could not set key for cmac > aes\n", __func__); > return rc; > } Yes, but I was planning to do all the scrubbing for such other spots in a separate patch series (similar to what I've posted for the smb/server code already) ... this patch series here focuses on aes_cmac_zeroize_key and aes_cmac_zeroize_ctx only. I hope that's ok? Thomas