From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Bo Ye <bo.ye@mediatek.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: yongdong.zhang@mediatek.com, C Cheng <C.Cheng@mediatek.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2] fix overflow in idle exit_latency
Date: Tue, 19 Dec 2023 11:56:37 +0100 [thread overview]
Message-ID: <e23ebdd8-7fbe-435b-a850-0ef18a51b020@collabora.com> (raw)
In-Reply-To: <20231219031444.91752-1-bo.ye@mediatek.com>
Il 19/12/23 04:14, Bo Ye ha scritto:
> From: C Cheng <C.Cheng@mediatek.com>
>
> In detail:
>
> In C language, when you perform a multiplication operation, if
> both operands are of int type, the multiplication operation is
> performed on the int type, and then the result is converted to
> the target type. This means that if the product of int type
> multiplication exceeds the range that int type can represent,
> an overflow will occur even if you store the result in a
> variable of int64_t type.
>
> For a multiplication of two int values, it is better to use
> mul_u32_u32() rather than s->exit_latency_ns = s->exit_latency *
> NSEC_PER_USEC to avoid potential overflow happenning.
>
> Signed-off-by: C Cheng <C.Cheng@mediatek.com>
> Signed-off-by: Bo Ye <bo.ye@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
next prev parent reply other threads:[~2023-12-19 10:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 3:14 Bo Ye
2023-12-19 10:56 ` AngeloGioacchino Del Regno [this message]
2024-02-12 16:09 ` Rafael J. Wysocki
2023-12-19 16:24 ` David Laight
2023-12-19 16:30 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e23ebdd8-7fbe-435b-a850-0ef18a51b020@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=C.Cheng@mediatek.com \
--cc=bo.ye@mediatek.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=rafael@kernel.org \
--cc=yongdong.zhang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®