From: Joe Perches <joe@perches.com>
To: Nick Desaulniers <ndesaulniers@google.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Louis Taylor <louis@kragniz.eu>, Jonathan Corbet <corbet@lwn.net>,
pmladek@suse.com, geert+renesas@glider.be,
linux-doc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
clang-built-linux@googlegroups.com,
Jon Flatley <jflat@chromium.org>
Subject: Re: [PATCH] docs: add extra integer types to printk-formats
Date: Tue, 05 Mar 2019 11:59:30 -0800 [thread overview]
Message-ID: <e244390e3d245c94d6d2fb036943e63111ada86d.camel@perches.com> (raw)
In-Reply-To: <CAKwvOdm4uCWCtSMVQDVTSKavpT0dCo+ayuwvoXtewmk+ksn5sA@mail.gmail.com>
On Mon, 2019-03-04 at 09:59 -0800, Nick Desaulniers wrote:
> On Sun, Mar 3, 2019 at 12:10 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Sun, Mar 03, 2019 at 12:36:47PM +0000, Louis Taylor wrote:
> > > A few commonly used integer types were absent from this table, so add
> > > them.
> >
> > I'm not against the patch, but isn't obvious by reading POSIX and / or man
> > printf(3)?
>
> You'd think; but based on the sheer number of -Wformat warnings
> (~450), I'm not so sure.
<shrug> software defects are always present.
Many of the -Wformat warnings are bogus too.
There's nothing wrong with using %x for a unsigned int
of less than long size. (u8/u16)
> At least with this patch they're "above the
> fold."
I'd personally go with
"posix plus kernel specific deletions and extensions"
> The kernel also has its own format flag extensions, and does not
> implement %n (for good reason), so it's better to be explicit than
> imply posix or glibc compat.
%i is also supported and used a few hundred times
next prev parent reply other threads:[~2019-03-05 19:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-03 12:36 Louis Taylor
2019-03-03 20:10 ` Andy Shevchenko
2019-03-04 17:59 ` Nick Desaulniers
2019-03-05 19:59 ` Joe Perches [this message]
2019-03-05 20:07 ` Matthew Wilcox
2019-03-05 20:11 ` Matthew Wilcox
2019-03-05 20:15 ` Joe Perches
2019-03-05 21:00 ` Randy Dunlap
2019-03-04 15:45 ` Petr Mladek
2019-03-04 17:54 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e244390e3d245c94d6d2fb036943e63111ada86d.camel@perches.com \
--to=joe@perches.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=clang-built-linux@googlegroups.com \
--cc=corbet@lwn.net \
--cc=geert+renesas@glider.be \
--cc=jflat@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=louis@kragniz.eu \
--cc=ndesaulniers@google.com \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®