From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759196AbdAKUvu (ORCPT ); Wed, 11 Jan 2017 15:51:50 -0500 Received: from mout.web.de ([217.72.192.78]:59093 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751734AbdAKUvU (ORCPT ); Wed, 11 Jan 2017 15:51:20 -0500 Subject: [PATCH 15/18] mtd-cfi_cmdset_0002: Use kcalloc() in cfi_ppb_unlock() To: linux-mtd@lists.infradead.org, Boris Brezillon , Brian Norris , Cyrille Pitchen , David Woodhouse , Denys Vlasenko , Marek Vasut , Richard Weinberger References: <71189baa-8780-b80a-0b4d-9dae74763ba3@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: Date: Wed, 11 Jan 2017 21:50:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <71189baa-8780-b80a-0b4d-9dae74763ba3@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:vpDkEsGDClteGIMUkADz+WjaY2PaY8s46Hugl9+46nNIrirEXo2 XLJTCAX+94ElHtwNWwWFQLZ/zq06ulOPFOm/MA3R+rU83SaUWk5mB9ia1+HmvBjaaV3i2i7 hDVkclqG1iHdriMsGzFijade+lVG6XQVejiXbW82dlZBe2m+Hcp2q24st0XzNNmNhG7pqBw YyrY4aGLrZ7t7TZXSXG9w== X-UI-Out-Filterresults: notjunk:1;V01:K0:VjzgKZLEN/o=:u8Ul6r0j3kwbYc64FLWzgZ mc9YuW4aAAivEKiZaqkm6XM/WH2ALSFeXpo4ZKox1UM+UXzJE+zHGK6n8yVMhsklU1kpmSuRQ KJY+Sfajrosj3erWml6psbqzq9Risu8rQQ5vFSZppquMBaYdYS6jHZnumKwpQZBjl7XmXH0Vr zYR2biy1Wrsuuq2oUkj1rXOCudPAgeKNUs5mOmSE5YKC9FAtv/OvbTCgE8OltuPh+TtsHTeaw i+WvzSWA/PNCOMNLGCHuI0G31IXzFqqMIZK5FfuC9n6RcYW+fQK6XSaq6QLTyQPMdpqhzIoTC mT6l1p/S0rYi34sRsFPpG7O/VzjOUMltyWGtG1rM9pAkIPhKev3lVDZHGIWlFKdjuJnEgzMrb 3QwWpJWg1WZQzvbVlNh71b03wJ1kg5lVhHjj03GiI1vffSSlfRTb7RLIJnX36/rd6AD/q3MEr XJPjuRDT4U7gZIJLUf+7/HLoIZnUxXHWCSRF6ZC3qkf5WWi0uSLq/KML6TJWh3NBUXuBWQvAl L63ChudNATf9NSJmSWn504JkVaCIlc1QZHPsPTPCPhnpsQf6Tli+WNvR1H6WkyDXv52YaHu7B 0Cih9D+Lt4GdPAIqEoQomz5KFWzCluxJfwiejWIWWeGjrP0Xjxp1BLIw21GGwbaZ5181V/EOR NOwOI3YP3GLkuoudRFjdLy+YpT+Ebff8Xsv7VVUKcMqA+siMA8gMmYbneDp3B0EuiSLsR8VMQ LwcVsJUAiMUYVyzd+FtGdNLAh/Ij1kshwyIsu3Qs0Mfj8ZfxyCChYDb+m4oyo7waMM5EmBJGb yp5wFHv Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 11 Jan 2017 19:15:52 +0100 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kcalloc". This issue was detected by using the Coccinelle software. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/mtd/chips/cfi_cmdset_0002.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c index 0c4751eb6efe..81b6fd35be91 100644 --- a/drivers/mtd/chips/cfi_cmdset_0002.c +++ b/drivers/mtd/chips/cfi_cmdset_0002.c @@ -2649,7 +2649,7 @@ static int __maybe_unused cfi_ppb_unlock(struct mtd_info *mtd, loff_t ofs, * first check the locking status of all sectors and save * it for future use. */ - sect = kzalloc(MAX_SECTORS * sizeof(struct ppb_lock), GFP_KERNEL); + sect = kcalloc(MAX_SECTORS, sizeof(*sect), GFP_KERNEL); if (!sect) return -ENOMEM; -- 2.11.0