Re: [PATCH 3/3] can: tscan1: Kconfig: add COMPILE_TEST

[Vincent Mailhol <mailhol.vincent@wanadoo.fr>]

On 15/07/2025 at 18:13, Marc Kleine-Budde wrote:
> On 13.07.2025 17:02:45, Vincent Mailhol wrote:
>> tscan1 depends on ISA. Add COMPILE_TEST so that this driver can also be
>> built on other platforms.
>>
>> Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
>> ---
>>  drivers/net/can/sja1000/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/can/sja1000/Kconfig b/drivers/net/can/sja1000/Kconfig
>> index 2f516cc6d22c4028b1de383baa6b3d3a7605b791..fee9d6f84f5fb9d6a81df00be9d216219723a854 100644
>> --- a/drivers/net/can/sja1000/Kconfig
>> +++ b/drivers/net/can/sja1000/Kconfig
>> @@ -105,7 +105,7 @@ config CAN_SJA1000_PLATFORM
>>  
>>  config CAN_TSCAN1
>>  	tristate "TS-CAN1 PC104 boards"
>> -	depends on ISA
>> +	depends on ISA || COMPILE_TEST
>>  	help
>>  	  This driver is for Technologic Systems' TSCAN-1 PC104 boards.
>>  	  https://www.embeddedts.com/products/TS-CAN1
>>
> 
> What about making it:
> 
> --- a/drivers/net/can/sja1000/Kconfig
> +++ b/drivers/net/can/sja1000/Kconfig
> @@ -105,7 +105,7 @@ config CAN_SJA1000_PLATFORM
>  
>  config CAN_TSCAN1
>          tristate "TS-CAN1 PC104 boards"
> -        depends on ISA
> +        depends on ISA || (COMPILE_TEST && HAS_IOPORT)
>          help
>            This driver is for Technologic Systems' TSCAN-1 PC104 boards.
>            https://www.embeddedts.com/products/TS-CAN1

Yes, I was thinking of the exact same thing after seeing the bot's error
message. I just did not yet find some time to test.

The kernel test robot actually gives instructions on how to reproduce, but for
some reasons which I have not yet troubleshot, it did not work on first try on
my machine.

Well, you know what, because we reached the same conclusion, allow me to be a
bit lazy here. I will just send the v2 and let the bot test it for me.


Yours sincerely,
Vincent Mailhol