From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sm8450-hdk: add other analogue microphones
Date: Tue, 18 Jul 2023 11:47:27 +0200 [thread overview]
Message-ID: <e25fb716-38f3-7f4b-d525-e20455cdae85@linaro.org> (raw)
In-Reply-To: <76c99543-4f77-38c2-5940-517f2715060d@linaro.org>
On 18/07/2023 11:40, Srinivas Kandagatla wrote:
>> diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
>> index bd5e8181f2aa..9bd1ef401ca3 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
>> @@ -915,14 +915,23 @@ &sound {
>> "SpkrRight IN", "WSA_SPK2 OUT",
>> "IN1_HPHL", "HPHL_OUT",
>> "IN2_HPHR", "HPHR_OUT",
>> + "AMIC1", "MIC BIAS1",
>> "AMIC2", "MIC BIAS2",
>> - "VA DMIC0", "MIC BIAS1",
>> - "VA DMIC1", "MIC BIAS1",
>> - "VA DMIC2", "MIC BIAS3",
>> - "TX DMIC0", "MIC BIAS1",
>> - "TX DMIC1", "MIC BIAS2",
>> - "TX DMIC2", "MIC BIAS3",
>> - "TX SWR_ADC1", "ADC2_OUTPUT";
>> + "AMIC3", "MIC BIAS3",
>> + "AMIC4", "MIC BIAS3",
>> + "AMIC5", "MIC BIAS4",
> These should reflect the board-level wiring of MIC BIAS, are you sure
> that this is how the hdk is wired up?
If I read the schematics correctly, then yes. You can double check, if I
understood this right: page 40 of HDK schematics
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-18 9:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 14:38 Krzysztof Kozlowski
2023-07-18 9:40 ` Srinivas Kandagatla
2023-07-18 9:47 ` Krzysztof Kozlowski [this message]
2023-09-19 23:07 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e25fb716-38f3-7f4b-d525-e20455cdae85@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®