From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DFF33431E5 for ; Mon, 1 Sep 2025 14:43:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756737810; cv=none; b=ena8nAGBjutcpzvAa1IWIyYX0FXlAJlJiqpAXfrFc0CxanHkUvTgDAxdWNZZl8taKKbXO0Z5gjz361iYovEA0keTYhbLiTnK+/DUdlkZ13GKUCb1MOBULw5XPzhQWj4hwtiIs26LqsB5NRaWoxBRvpm6rYjp/8b5LltfnsHKxS0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756737810; c=relaxed/simple; bh=fzV2ArRfUZY3Zqk8nsUA/BCr9akfeCnj+cgX8D3T2U0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=o022oZRVhvfUuTytq/dcoAZSRsAKOK+n2WvC+6ueYdH8wBoQwaVF/pxvSlGdY13rCPrecwrt3vKzdJP7h2D3byfHxeLrVpOEE63isfkIzbvB1tpZKVRoHCYrpd13XxrJLLEhHshC5FGpCSp805ZmF1cwd3BI+NuN41sTJj4YV+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=he83A8Hr; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="he83A8Hr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756737807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZQf4Reiy5apT64tfdgfETW33d38jjuSty8SoNlXS3hY=; b=he83A8Hr4oZxw6L7xZYUs5O56bNktzRy1zVWXInnzvHq6lU9BSaZhxS71R1yPfCC7poltk ul6uyxGnyjxq32PJhu5YntHb/ow7v59L9W+f9sCh3+ZnLuZG3Xws98WHMAAlh5yYtopkff zsQh8SlOPC6LGLSZi1jId1Np6uy00LA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-437-9c4X0pIONSC7CyVSdpxN1g-1; Mon, 01 Sep 2025 10:43:26 -0400 X-MC-Unique: 9c4X0pIONSC7CyVSdpxN1g-1 X-Mimecast-MFC-AGG-ID: 9c4X0pIONSC7CyVSdpxN1g_1756737805 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-45b920a0c89so1633745e9.2 for ; Mon, 01 Sep 2025 07:43:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756737805; x=1757342605; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZQf4Reiy5apT64tfdgfETW33d38jjuSty8SoNlXS3hY=; b=gpt9WymauMmi17sP9yNAKDyh1pEHhreanfQZH0QPhO9PAqVxGCxqMc3zoDMACRb6r3 TuhJ28ZSeP+fRb3KAv5vv9js7jE1gv5gFuyhqIw7LX0enGWrdz6lWE9F/PiHVlDbf6IT ZLRr94KXqAjWGS6Wd278dBYOdVvRwUo6tP8Zc8WnYznoanobgi2nkitNLKcwKknWENms AxYPYDY5gxiFXnVriARAJbtiqPF+HuqSelafcHpXeHbspR3VRkhy9MfN0WDO5AiDt81C rnNAE2kx84vkwa1dMfu67ixnw9cY5HYZrbungVIKt3ha6Z5AkL1GaUPTDUAeHdIOK88W XRLw== X-Forwarded-Encrypted: i=1; AJvYcCW4qnciipu/GgtCGWokWoAYMjpgQRzuJjrUyeI4ZEOedYai9g8Vk5DbSjOVVc9BG5cUKWZEioD0l2CeN6Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwF37JchJXSw1z0joqlbRPYzF9xtz8EEYJiI0WkS4lwDVnKMv/+ /nRBEpvDAqnHppkBkro5fEwgRBgZygD/aRg3UziIZ8qgaq/J/2XNgtej+4ex1oU955N742eR3ky qhATbgY2XeVnByvjEb10yBqYBml2nkC5RDX7afWdxxxjscXnTiEGn/InE1qD+rEBtsw== X-Gm-Gg: ASbGncvlACMVxDcwbUZ/xEcgFA70mH1+aSDsd+OyPBAJtT65IMikb8oJNRVD5anxEr6 +7gvqgRUJsC7oNHEnEHrqMNWpkNr2mK16a/qBXxznSuPLoU3JAyTqz6xlEcrcc5Qm5fR3LiF3JQ K/vQBx/q0Rbc8atg5D3594+B47N7IrxQkA7OsMbqRhKDvlRAa9NgfbDBtSYvkiGqnhAxLO+my+b RfI4tgptgavwRaXg9fv4yjOsQdX7WJYOuiYOqPUaPD7PCTNz+Q+IqlIm/wtXZ/5JOT94aC1LPOz 1CwGALn/TQy5lrWKflbT8svj2Z0sii6vFjg6FhtM5B0nxcxAaXUMjxazGGfxInoeD2kMkgXfIIf yHEM4RRiyE3NiqPjQbPcmyg6ttl/ejqMqWqn3jtmOKAqL70nLVHYzj8/9wsUkjuyYklM= X-Received: by 2002:a05:600c:3b9d:b0:45b:8a84:503b with SMTP id 5b1f17b1804b1-45b8a845256mr54590945e9.31.1756737805324; Mon, 01 Sep 2025 07:43:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHQRfn5sR/77vqQEmdzkbnhL4QNlRAOrqr4TrvFYBM6bDd/eneSMeY2Ldu8ZaHvy16wvsmCiw== X-Received: by 2002:a05:600c:3b9d:b0:45b:8a84:503b with SMTP id 5b1f17b1804b1-45b8a845256mr54590595e9.31.1756737804892; Mon, 01 Sep 2025 07:43:24 -0700 (PDT) Received: from ?IPV6:2003:d8:2f37:2b00:948c:dd9f:29c8:73f4? (p200300d82f372b00948cdd9f29c873f4.dip0.t-ipconnect.de. [2003:d8:2f37:2b00:948c:dd9f:29c8:73f4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b87b38fcfsm53262385e9.0.2025.09.01.07.43.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Sep 2025 07:43:24 -0700 (PDT) Message-ID: Date: Mon, 1 Sep 2025 16:43:22 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 05/12] KVM: Documentation: describe GUEST_MEMFD_FLAG_NO_DIRECT_MAP To: "Roy, Patrick" Cc: "ackerleytng@google.com" , "Manwaring, Derek" , "Thomson, Jack" , "Kalyazin, Nikita" , "kvm@vger.kernel.org" , "kvmarm@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "pbonzini@redhat.com" , "rppt@kernel.org" , "seanjc@google.com" , "tabba@google.com" , "vbabka@suse.cz" , "will@kernel.org" , "Cali, Marco" References: <786503d6-e58d-412a-a17b-f5e4e481c3fe@redhat.com> <20250901143000.5017-1-roypat@amazon.co.uk> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20250901143000.5017-1-roypat@amazon.co.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01.09.25 16:30, Roy, Patrick wrote: > On Thu, 2025-08-28 at 11:27 +0100, David Hildenbrand wrote: >> On 28.08.25 11:39, Roy, Patrick wrote: >>> Signed-off-by: Patrick Roy >>> --- >>> Documentation/virt/kvm/api.rst | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst >>> index c17a87a0a5ac..b52c14d58798 100644 >>> --- a/Documentation/virt/kvm/api.rst >>> +++ b/Documentation/virt/kvm/api.rst >>> @@ -6418,6 +6418,11 @@ When the capability KVM_CAP_GUEST_MEMFD_MMAP is supported, the 'flags' field >>> supports GUEST_MEMFD_FLAG_MMAP. Setting this flag on guest_memfd creation >>> enables mmap() and faulting of guest_memfd memory to host userspace. >>> >>> +When the capability KVM_CAP_GMEM_NO_DIRECT_MAP is supported, the 'flags' field >>> +supports GUEST_MEMFG_FLAG_NO_DIRECT_MAP. Setting this flag makes the guest_memfd >>> +instance behave similarly to memfd_secret, and unmaps the memory backing it from >>> +the kernel's address space after allocation. >>> + >>> When the KVM MMU performs a PFN lookup to service a guest fault and the backing >>> guest_memfd has the GUEST_MEMFD_FLAG_MMAP set, then the fault will always be >>> consumed from guest_memfd, regardless of whether it is a shared or a private >> >> WARNING: Missing commit description - Add an appropriate one > > Admittedly wasn't sure what to say that wouldn't just repeat the commit title > or the contents. Maybe that just means this shouldn't be its own patch. Will > squash in the previous one (same for PATCH 11/12). Very right :) If there is nothing to say then probably everything was already said (other patch), lol > >> WARNING: From:/Signed-off-by: email name mismatch: 'From: "Roy, Patrick" >> ' != 'Signed-off-by: Patrick Roy ' > > Heh, my git config only ever uses "Patrick Roy ". Not sure > where "Roy, Patrick" comes from, could it be the mail server mangling things? Good question. Does it only happen through git? When Nikita sends through amazon.com[1] it seems to be fine. But when he also sent through amazon.co.uk [2], it's also messed up. I suggest contacting the amazon.co.uk admin or ... sending through amazon.com :) [1] https://lore.kernel.org/all/cda7c46b-c474-48f4-b703-e2f988470f3b@amazon.com/T/#u [1] https://lore.kernel.org/all/20250828153049.3922-1-kalyazin@amazon.com/T/#u -- Cheers David / dhildenb