From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C015C3F2D2 for ; Thu, 5 Mar 2020 15:54:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 512CF2072D for ; Thu, 5 Mar 2020 15:54:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727125AbgCEPyB (ORCPT ); Thu, 5 Mar 2020 10:54:01 -0500 Received: from lhrrgout.huawei.com ([185.176.76.210]:2511 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726275AbgCEPyB (ORCPT ); Thu, 5 Mar 2020 10:54:01 -0500 Received: from LHREML713-CAH.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id 81C7585F4FD0C4A75E66; Thu, 5 Mar 2020 15:53:58 +0000 (GMT) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by LHREML713-CAH.china.huawei.com (10.201.108.36) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 5 Mar 2020 15:53:58 +0000 Received: from [127.0.0.1] (10.202.226.45) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 5 Mar 2020 15:53:58 +0000 Subject: Re: [PATCH] spi: Remove CONFIG_ prefix from Kconfig select To: Joe Perches CC: Mark Brown , linux-spi , LKML References: From: John Garry Message-ID: Date: Thu, 5 Mar 2020 15:53:57 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.226.45] X-ClientProxiedBy: lhreml712-chm.china.huawei.com (10.201.108.63) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/03/2020 15:15, Joe Perches wrote: > commit a2ca53b52e00 ("spi: Add HiSilicon v3xx SPI NOR flash > controller driver") likely inadvertently used a select statement > with a CONFIG_ prefix, remove the prefix. > > Signed-off-by: Joe Perches It's a pity checkpatch can't pick this stuff up... The select is just for enabling the driver of a slave driver, so should not cause any build issues when not enabled. thanks FWIW, Acked-by: John Garry > --- > drivers/spi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig > index 82177d..2dc7bd 100644 > --- a/drivers/spi/Kconfig > +++ b/drivers/spi/Kconfig > @@ -292,7 +292,7 @@ config SPI_HISI_SFC_V3XX > tristate "HiSilicon SPI-NOR Flash Controller for Hi16XX chipsets" > depends on (ARM64 && ACPI) || COMPILE_TEST > depends on HAS_IOMEM > - select CONFIG_MTD_SPI_NOR > + select MTD_SPI_NOR > help > This enables support for HiSilicon v3xx SPI-NOR flash controller > found in hi16xx chipsets. > > > . >