Re: [PATCH 1/2] wifi: ath11k: simplify copying a peer's PPE thresholds

[Rameshkumar Sundaram <rameshkumar.sundaram@oss.qualcomm.com>]

On 11/7/2026 12:18 AM, Christopher Griffin via B4 Relay wrote:
> From: Christopher Griffin <christophergriffin05@gmail.com>
> 
> ath11k_peer_assoc_h_he() copies each 6-bit PPE threshold of a peer's HE
> capabilities into the WMI layout one bit at a time, shifting it in from
> the top: val >>= 1, then the new bit at bit 5, six times over. After the
> sixth bit, bit i of the field sits at bit i of val, so put it there
> directly.
> 
> No functional change: a userspace copy of both loops gives the same
> ppet16_ppet8_ru3_ru0 for every 6-bit value in every RU slot and for 2.5
> million random threshold fields. Compile-tested with W=1.
> 

this information seems to be unnecessary as its obvious from code.

> The change, this message and the test were written with Claude, an AI
> coding assistant.
> 

This might also be not needed as per latest guidelines.


> Suggested-by: Rameshkumar Sundaram <rameshkumar.sundaram@oss.qualcomm.com>
> Link: https://lore.kernel.org/all/b60c4c56-483b-406e-92ab-643b0fdf2dc8@oss.qualcomm.com/
> Signed-off-by: Christopher Griffin <christophergriffin05@gmail.com>
> ---
>   drivers/net/wireless/ath/ath11k/mac.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
> index 1a237adaa37d1..d7ae9e8747233 100644
> --- a/drivers/net/wireless/ath/ath11k/mac.c
> +++ b/drivers/net/wireless/ath/ath11k/mac.c
> @@ -2496,9 +2496,8 @@ static void ath11k_peer_assoc_h_he(struct ath11k *ar,
>   				if ((arg->peer_ppet.ru_bit_mask & BIT(ru)) == 0)
>   					continue;
>   				for (i = 0; i < 6; i++) {
> -					val >>= 1;
>   					val |= ((he_cap->ppe_thres[bit / 8] >>
> -						 (bit % 8)) & 0x1) << 5;
> +						 (bit % 8)) & 0x1) << i;
>   					bit++;
>   				}
>   				arg->peer_ppet.ppet16_ppet8_ru3_ru0[nss] |=
> 

both comments apply to ath12k patch as well

-- 
Ramesh