mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Roshan Khatri <topofeverest8848@gmail.com>,
	Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com,
	gregkh@linuxfoundation.org, ayushtiw0110@gmail.com,
	dan.carpenter@linaro.org, namcaov@gmail.com,
	linux-kernel@vger.kernel.org
Cc: linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: rtl8712: Fix spelling mistakes in rtl871x_event.h
Date: Mon, 20 May 2024 20:39:25 +0200	[thread overview]
Message-ID: <e26f09d5-0a04-4392-bae6-d619008b3d9e@gmail.com> (raw)
In-Reply-To: <20240520064750.48912-1-topofeverest8848@gmail.com>

On 5/20/24 08:47, Roshan Khatri wrote:
> codespell reported misspelled joining in rtl871x_event.h. This patch
> fixes the misspelled joining word.
> 
> Signed-off-by: Roshan Khatri <topofeverest8848@gmail.com>
> ---
>   drivers/staging/rtl8712/rtl871x_event.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl871x_event.h b/drivers/staging/rtl8712/rtl871x_event.h
> index 759a2d27d8f2..0cc780cf4341 100644
> --- a/drivers/staging/rtl8712/rtl871x_event.h
> +++ b/drivers/staging/rtl8712/rtl871x_event.h
> @@ -37,7 +37,7 @@ struct surveydone_event {
>   };
>   
>   /*
> - * Used to report the link result of joinning the given bss
> + * Used to report the link result of joining the given bss
>    * join_res:
>    *  -1: authentication fail
>    *  -2: association fail

Hi Roshan,

Subject line looks good to me - but it is only one mistake and not mistakes.

Patch description: Omit what you are changing as this can be seen in the 
change itself. Do only write why you are doing this.

You can find examples with
git log --grep=codespell
or
git log --grep=typo

If you send in a second version of this patch please use a change 
history. Description from Dan under:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

This is just my opinion but often I am right. Any response from Greg is 
binding.

Bye Philipp


      reply	other threads:[~2024-05-20 18:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-20  6:47 Roshan Khatri
2024-05-20 18:39 ` Philipp Hortmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e26f09d5-0a04-4392-bae6-d619008b3d9e@gmail.com \
    --to=philipp.g.hortmann@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=ayushtiw0110@gmail.com \
    --cc=dan.carpenter@linaro.org \
    --cc=florian.c.schilhabel@googlemail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=namcaov@gmail.com \
    --cc=topofeverest8848@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®