From: Linyu Yuan <quic_linyyuan@quicinc.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-trace-kernel@vger.kernel.org>
Subject: Re: [PATCH v5] trace: acquire buffer from temparary trace sequence
Date: Tue, 31 Jan 2023 10:06:22 +0800 [thread overview]
Message-ID: <e2735a3a-4a9b-8b3a-0671-b3f56187cbe2@quicinc.com> (raw)
In-Reply-To: <20230130143041.713c4c7b@gandalf.local.home>
On 1/31/2023 3:30 AM, Steven Rostedt wrote:
> On Mon, 30 Jan 2023 21:14:01 +0800
> Linyu Yuan <quic_linyyuan@quicinc.com> wrote:
>
>> @Steven current design is not safe, as user still can write to buffer
>> which have no enough space.
> I'm assuming that it would never use more that DWC3_MSG_MAX, and that's set
> to 500. The size of the trace_seq() is 4096 (or PAGE_SIZE), I doubt it will
> ever be an issue.
>
> How do you think the user can still write more than enough?
yes, agree it will be safe for dwc3, but i don't know if any possible
hacker,
as the function always return a valid pointer even when hacker input a
large size.
>
> -- Steve
>
>> do you think it is better to improve dwc3 trace in fast assign path ?
>>
>
next prev parent reply other threads:[~2023-01-31 2:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 7:54 Linyu Yuan
2023-01-30 13:14 ` Linyu Yuan
2023-01-30 19:30 ` Steven Rostedt
2023-01-31 2:06 ` Linyu Yuan [this message]
2023-01-31 2:37 ` Steven Rostedt
2023-01-31 2:49 ` Linyu Yuan
2023-01-31 3:58 ` Steven Rostedt
2023-01-31 4:59 ` Linyu Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2735a3a-4a9b-8b3a-0671-b3f56187cbe2@quicinc.com \
--to=quic_linyyuan@quicinc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®