From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F5FEC83F11 for ; Sat, 26 Aug 2023 12:15:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231124AbjHZMOg (ORCPT ); Sat, 26 Aug 2023 08:14:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231784AbjHZMOD (ORCPT ); Sat, 26 Aug 2023 08:14:03 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 093DD97 for ; Sat, 26 Aug 2023 05:14:01 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-4ff09632194so2752015e87.2 for ; Sat, 26 Aug 2023 05:14:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693052039; x=1693656839; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZWzzzk+As+BY6UwgLRaLr7poPNRCmomJPELZ+vZ4/8A=; b=Q/iPgubQoBEEbwbjCtGWxwHa24g0itm3XaTP8BUD8s+/2yZRu1xJR0RdmtM8xN0eMO hNXxbhOVTMDDk0h8cZzKXzeM1EJOpLhJTkUQ5u156misuWIX+UHjJNcFrEBMNwZT1sLG 84QN59/zZ1QkaA5VYuabt2vAhJ/s2VEqDYpXdLz/IR+5P/opbBOdIzx2Yy1sNyhaGfV+ eaURWEg/MakYN4XQVERgeUYVLO8+UzNnOVGExW9ScjRsCDalZot+MKnHnbXxEiQiIEE5 JbYRGGB+j0XTye5POv5LjcWTZu1AAoUuUgM0Zw0cU9Bhk+eyd7JyvL9Yri8/4iEWHHcT WkfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693052039; x=1693656839; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZWzzzk+As+BY6UwgLRaLr7poPNRCmomJPELZ+vZ4/8A=; b=ZCpszAYsSMXzMBNEZGnUiwh5+JxN9cWl2zxlqv98HFGOJGKIB50jy9OC/NPKUwUgB+ WGWsvlWpJ8/LQHyI7PynElEzc4Kvx9JEFJqkXKM/y4E5DYhEEzeskO42/DDLjRTdAw75 KuFk6Npl4L7eEMOwb+W4w63SzQJdIb3qeRDYKbnAAyGp91ecbU4x70HPCe0dVdfYCXIC JPiznTKUnvgtGizET3xnAA57/zvlJ4EkHkAql/HyeSVKFhwG9HUxvlulziaNzNTm9BhZ RubpZSYyjjoGYUhfA36uWKpDi/uqyvANtvheLgf4t0aLgldSC2Hg0UUB0I+TqJIao7w2 ffrA== X-Gm-Message-State: AOJu0Yyjyfcs6xUl+IQBtyFKEksAjcN+nLW32h/ARz6P25JYB2KOZj8B UqWCc//ycTCSM9fl2nyxu8hOHQ== X-Google-Smtp-Source: AGHT+IHQsqSmx6T2TFtoFQ4gwynS7vef2gEk25gwm+9PNpLOEe438ueEGCVQrsOwmZA7KSSLfgKirw== X-Received: by 2002:a05:6512:1587:b0:4fd:d470:203b with SMTP id bp7-20020a056512158700b004fdd470203bmr17737500lfb.69.1693052039243; Sat, 26 Aug 2023 05:13:59 -0700 (PDT) Received: from [192.168.1.101] (abyl74.neoplus.adsl.tpnet.pl. [83.9.31.74]) by smtp.gmail.com with ESMTPSA id x14-20020a19f60e000000b004fe3e0956fdsm693043lfe.240.2023.08.26.05.13.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Aug 2023 05:13:58 -0700 (PDT) Message-ID: Date: Sat, 26 Aug 2023 14:13:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 07/15] media: qcom: camss: Capture VFE CSID dependency in a helper function Content-Language: en-US To: Bryan O'Donoghue , rfoss@kernel.org, todor.too@gmail.com, agross@kernel.org, andersson@kernel.org, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com, andrey.konovalov@linaro.org Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230823104444.1954663-1-bryan.odonoghue@linaro.org> <20230823104444.1954663-8-bryan.odonoghue@linaro.org> <95db5a14-87dc-4f08-b8e2-52bce140354d@linaro.org> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26.08.2023 14:12, Bryan O'Donoghue wrote: > On 26/08/2023 13:04, Konrad Dybcio wrote: >>>>>   From sdm845 onwards we need to ensure the VFE is powered on prior to >>>>> switching on the CSID. >>>> And what's the symptom if we fail to ensure this? How can someone >>>> adding support for another platform tell whether the match-list >>>> should be expanded? >>> That person has to understand the dependency. >> If we need this workaround, there surely must be something that doesn't >> work without it, a measurable symptom. What is it? > > The CSID lives inside of the VFE therefore the VFE must be power prior to the CSID. > > The symptom will be .. the CSID doesn't come out of reset. Good, that's what I needed to know. Now we can rename that function to something like camss_csid_inside_vfe() to make it more meaningful Konrad