From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: qcom: use defines for interrupts
Date: Mon, 31 Jul 2023 10:07:25 +0200 [thread overview]
Message-ID: <e274df6d-d34b-8a5d-8792-261ae51e2f66@linaro.org> (raw)
In-Reply-To: <20230730111530.98105-1-krzysztof.kozlowski@linaro.org>
On 30.07.2023 13:15, Krzysztof Kozlowski wrote:
> Replace hard-coded interrupt parts (GIC, flags) with standard defines
> for readability. No changes in resulting DTBs.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm/boot/dts/qcom/qcom-apq8064.dtsi | 44 ++++++++++++------------
> arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi | 2 +-
> arch/arm/boot/dts/qcom/qcom-msm8660.dtsi | 22 ++++++------
> arch/arm/boot/dts/qcom/qcom-msm8974.dtsi | 6 ++--
> arch/arm/boot/dts/qcom/qcom-sdx55.dtsi | 18 +++++-----
> arch/arm/boot/dts/qcom/qcom-sdx65.dtsi | 26 +++++++-------
> 6 files changed, 59 insertions(+), 59 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi
> index e0adf237fc5c..c693bfc63488 100644
> --- a/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi
> @@ -190,7 +190,7 @@ cpu_crit3: trip1 {
>
> cpu-pmu {
> compatible = "qcom,krait-pmu";
> - interrupts = <1 10 0x304>;
> + interrupts = <GIC_PPI 10 0x304>;
Looks like 0x304 would be (IRQ_TYPE_LEVEL_HIGH | IRQ_LEVEL | IRQ_PER_CPU)
[...]
> timer {
> compatible = "arm,armv7-timer";
> - interrupts = <1 2 0xf08>,
> + interrupts = <GIC_PPI 2 0xf08>,
0xf08 -> (IRQ_LEVEL | IRQ_PER_CPU | IRQ_NOPROBE | IRQ_NOREQUEST | IRQ_TYPE_LEVEL_LOW)
there's a couple more 0x3XX and 0xfXX in there
otherwise lgtm
Konrad
next prev parent reply other threads:[~2023-07-31 8:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-30 11:15 Krzysztof Kozlowski
2023-07-31 8:07 ` Konrad Dybcio [this message]
2023-07-31 9:14 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e274df6d-d34b-8a5d-8792-261ae51e2f66@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®