From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo2-f36.google.com (mail-oo2-f36.google.com [74.125.231.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 163D652CCC9 for ; Tue, 29 Sep 2026 13:12:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.231.164 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790687543; cv=none; b=KbNbLB8UYLgmsU+iJQWVxH9CZYl8UsdLbJKKseEYe/KYY31QpxjRbz++tebnaqMKOkQWtadsCo2RLikOtx/6kX7uArTr0EbhmB8q+4Vx3jAuKEhYpPqM8A6m30Da7I4oIJk8IE/QS8x8wHG55KadpQ/Hl+fe1km0IeBPPvU+cms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790687543; c=relaxed/simple; bh=wOjzlOoYB90lyjfFiVBHTNDKDKGt6bPwugUnMawhWc4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dTWGoUntOKxbPc1w9jIiC7Bwu04Ypemv2DWcslSvFxsMWPm0acE2Adh6tX0yvuNUE5TVOV5ERlTcSumxJITZmPx94588QaZqtAOCVExmJF8O8LUjZoG/k3D9yXNLRm28QoKRbwi2xvUTZN2No++PhZsu+aOfQtODW7GM3JPJXis= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=HwPu+TmK; arc=none smtp.client-ip=74.125.231.164 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="HwPu+TmK" Received: by mail-oo2-f36.google.com with SMTP id 006d021491bc7-6d77b3455bbso1525904eaf.0 for ; Tue, 29 Sep 2026 06:12:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1790687540; x=1791292340; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=FSKiUJRQhiLhPi0pr/mU+MmO5Nu+j31ELjJx/f3jfj4=; b=HwPu+TmKVQyVgdqw8atSaQoVOE5z+qT/44x+yo701WfkGLui9wMWFcyuZFzl4ZvFMZ 84wdieWdMGI5TS2cJqaLel5iTUP2otlah8yQIoOjAOEiQj3SN47PhJmOSbduu4NBhEME TTsbTukxuV3ff5LNxcjs1+2zk3dYBHUy/RT0G/RCYifr1vOooHvXgm0v+FwdM5DbC6ED jByQbNLDsSpr6TZ1HNuAOplHgJ06ZHwaJJVzvgH/m8hsx44uxlKQq3/YXiJb96XWMUWG viZn7hPmTqLyuIX+5+jbjdDeedFvsaIyCHY4bCpdNuhPf6VNQPOc94SE3vMJlRT/ZPuF Jpsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790687540; x=1791292340; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FSKiUJRQhiLhPi0pr/mU+MmO5Nu+j31ELjJx/f3jfj4=; b=p037CEX8Gd/VOe3JwvoiinS/pgIlk9IKvEUC4DQ1/rLFzP9lxpUDhEWCCubQQt+NvB NKrbSwMspFZvnKKEah06TZIja6d3oT1lvQUJ85a+Yqd0FFym1GjEtqLvDYUhU/nnJaRD EvlpQwGv/Uzv1QBwjRL/8bRS0F6hoZksOCxi/k4wSW1WTumeNOmX3NBblQhuRD0X6TnD f1rqiVVVMhDeYpEl+4FhlUbp7x/mBG9ou9ICu4qAgbWdrS46aXQhrUll2bip18IUj1JY M3wBQMHiwcLK7caEIAfMIJufmoeNzKoAKxunBanUouPzi8ShHCoxl7Z4/dsuzsX773Ol wqOw== X-Forwarded-Encrypted: i=1; AKwUvBzG4QGHPFbxyrbC+caBbielW25R+ZGrkr/AGgAtOvsTlBsbjDIpf52VjgiRxH/6Tio/z2wANjwukYiZwdo=@vger.kernel.org X-Gm-Message-State: AFuF++mTQa30bZX1RMk8KtGQx6b9/q+F/NgaV+DEgFixbTHSq+Pco2OI wQ/2dJ0oYjSh+0dbNgGwN7S0bMerR7r0V8ehpvCBuLddxfwHK0IEiLk0CDrXFElUNv4= X-Gm-Gg: AYBFou0tHZIagp4XCiUyoSC7OOTfBpN4IZMkqJGXa2a89EtW7QQtr9uNyHWKxOjdTm2 vb437g4rk8rXuc3IJsMtQSROZYrIXzyGD5w6gq65uOFFjBonNnuP1zMldvyo5CtZL57rwMNtqEV 639/wbmfl5FuAuHz4csQDKvwjAbjIWlbnkBuSBWd30g/iyQfXcUoHRXFYVfd+VhIqtRhtYp12mO my28PeAzGcid0xmjfYKbic4GvRJfaQ1N27eBWb4qK+4q9rr9BoBQmxLN8Q1F9wAWPn7WVRO3FST Lp6r1eslwrJkJ3mNhmE5Q0W3hQnQDICK0NXiLvIpoliruHMQ5gS7hYDONDP+w22hFgUDYuswQNW aFZyO7zQRS6lObUyDezqb90rPK3ZfvONoMzOhdu3NYwl3cfZ8ELpRacYjrOH+phynUGwgD9mVDU bsmdc8qgbowv3WDw/LBI1ntUAhVHMKR+davexxM874yaLHO3N6SDpVyUibPW9Z1MCQQlGv8W0= X-Received: by 2002:a05:6820:1524:b0:6c1:598a:d80a with SMTP id 006d021491bc7-6d440eea6aamr17324629eaf.62.1790687539902; Tue, 29 Sep 2026 06:12:19 -0700 (PDT) Received: from [100.64.0.1] ([170.85.13.74]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6d8822199cbsm8598079eaf.5.2026.09.29.06.12.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Sep 2026 06:12:19 -0700 (PDT) Message-ID: Date: Tue, 29 Sep 2026 08:12:17 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 7/7] riscv: dts: eswin: add watchdog support To: Pinkesh Vaghela Cc: Yulin Lu , Darshan Prajapati , Pritesh Patel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Andi Shyti , Mika Westerberg , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Min Lin References: <20260814070007.1662455-1-pinkesh.vaghela@einfochips.com> <20260814070007.1662455-8-pinkesh.vaghela@einfochips.com> From: Samuel Holland Content-Language: en-US In-Reply-To: <20260814070007.1662455-8-pinkesh.vaghela@einfochips.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Pinkesh, On 2026-08-14 2:00 AM, Pinkesh Vaghela wrote: > From: Pritesh Patel > > Add watchdog node for ESWIN EIC7700 SoC and enable them for HiFive > Premier P550 board > > Signed-off-by: Pritesh Patel > Signed-off-by: Pinkesh Vaghela > --- > .../dts/eswin/eic7700-hifive-premier-p550.dts | 16 ++++++++ > arch/riscv/boot/dts/eswin/eic7700.dtsi | 40 +++++++++++++++++++ > 2 files changed, 56 insertions(+) > > diff --git a/arch/riscv/boot/dts/eswin/eic7700-hifive-premier-p550.dts b/arch/riscv/boot/dts/eswin/eic7700-hifive-premier-p550.dts > index 5dddcf13fd25..103c3dab184f 100644 > --- a/arch/riscv/boot/dts/eswin/eic7700-hifive-premier-p550.dts > +++ b/arch/riscv/boot/dts/eswin/eic7700-hifive-premier-p550.dts > @@ -207,3 +207,19 @@ &uart2 { > pinctrl-names = "default"; > pinctrl-0 = <&uart2_pins>; > }; > + > +&wdt0 { > + status = "okay"; > +}; > + > +&wdt1 { > + status = "okay"; > +}; > + > +&wdt2 { > + status = "okay"; > +}; > + > +&wdt3 { > + status = "okay"; > +}; The watchdog timers have no dependency outside the SoC, so they can be enabled by default (omit the status property). There is no need to separately enable them for each board. Regards, Samuel > diff --git a/arch/riscv/boot/dts/eswin/eic7700.dtsi b/arch/riscv/boot/dts/eswin/eic7700.dtsi > index c13432d14504..f873e9eeb929 100644 > --- a/arch/riscv/boot/dts/eswin/eic7700.dtsi > +++ b/arch/riscv/boot/dts/eswin/eic7700.dtsi > @@ -265,6 +265,46 @@ syscon: syscon@50440000 { > }; > }; > > + wdt0: watchdog@50800000 { > + compatible = "snps,dw-wdt"; > + reg = <0x0 0x50800000 0x0 0x4000>; > + interrupts = <87>; > + clocks = <&clk EIC7700_CLK_GATE_LSP_WDT0_PCLK>; > + clock-names = "tclk"; > + resets = <&reset EIC7700_RESET_WDT0>; > + status = "disabled"; > + }; > + > + wdt1: watchdog@50804000 { > + compatible = "snps,dw-wdt"; > + reg = <0x0 0x50804000 0x0 0x4000>; > + interrupts = <88>; > + clocks = <&clk EIC7700_CLK_GATE_LSP_WDT1_PCLK>; > + clock-names = "tclk"; > + resets = <&reset EIC7700_RESET_WDT1>; > + status = "disabled"; > + }; > + > + wdt2: watchdog@50808000 { > + compatible = "snps,dw-wdt"; > + reg = <0x0 0x50808000 0x0 0x4000>; > + interrupts = <89>; > + clocks = <&clk EIC7700_CLK_GATE_LSP_WDT2_PCLK>; > + clock-names = "tclk"; > + resets = <&reset EIC7700_RESET_WDT2>; > + status = "disabled"; > + }; > + > + wdt3: watchdog@5080c000 { > + compatible = "snps,dw-wdt"; > + reg = <0x0 0x5080c000 0x0 0x4000>; > + interrupts = <90>; > + clocks = <&clk EIC7700_CLK_GATE_LSP_WDT3_PCLK>; > + clock-names = "tclk"; > + resets = <&reset EIC7700_RESET_WDT3>; > + status = "disabled"; > + }; > + > uart0: serial@50900000 { > compatible = "snps,dw-apb-uart"; > reg = <0x0 0x50900000 0x0 0x10000>;