From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011033.outbound.protection.outlook.com [40.93.194.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B1353ED5C9 for ; Tue, 7 Jul 2026 10:41:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.33 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783420917; cv=fail; b=I3ni/QRNreCft8QLcFo1hJerhons9dpQp94t4vAzyNaDgAm7CGzy+RmsAomkJEcp989XU+dJexYBKoLsauUl89/lARWS3ufCBWg2AS+T5IeU1EWMr2AdZSnyq43Z6ZneD//ylbW9Rvf/BqTkdnv3g4/IiGSvp6GloY7KbKkmUzU= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783420917; c=relaxed/simple; bh=/A9AdyI3vNvgxRT8sgvfA5yVrGs9bk9tR0Yg8tXowkc=; h=Message-ID:Date:Subject:To:References:From:In-Reply-To: Content-Type:MIME-Version; b=nAB7EmWwe95WUn5qIFCrUBBGM+jVVixC7R0FXYglcPd6/Va6FIerv1083n8gfMgGd2Pjw5cIksSIWebKiVsnT0cwjb9J44I3zV/1qB/HNk0IN2zwnrWXdYVIOfFzVib3dnumj2fWb3kLTMnxg0/EuXO2YCwnGzEocRY5wxf+ijc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=rj1LCn9D; arc=fail smtp.client-ip=40.93.194.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="rj1LCn9D" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bT3bdAn65VZngptq7pJJVxDgOxqBMLJyZkVUKDMsQLxdQApfSC51cu6L6pqbV1DM9K6oJJpl60Tir5cyp8w97tP7ZaCDukyK6qFVEpHPyN7DhuB76drr4cO8tF9LplepdfhjQQE/0a3ZFj6iUgPsqIQZLkMpeLI2K/rD4EJJ7LAXbRtD4pFSGZXWRJLrkO9bNO+Ttlj536FGVGQjlISkJdof6CCON1U0f10unADgT0osM2jykd2VxrMmgDhlvfdwH2LNdqCVeFAFrO1awOn110IWxljyedq3boQIrayR5amuTiQ+vQvhx8R1PCHhocQqbUXaHnOfNXHtzDo0yuHhkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qjcpxJee5lakUwNE+eJxosL/6vVG+F3zI8eGlUrYXFU=; b=Y3GmvuuwcvuCLYM1O4anYLczT+A+4A/bEIn7CjeaiOfGQz2+8SzdDb4ifQvWEMVVBTEEZ7q+2yGa9yM3obzR14j6XD5I9azf8mYQ3m49SQwaueFi0I4pQcfADtmmKQmyVvTxqR4sgkq4Gomn1+nIONM+amzghUXj8310yzE24tGVfq+k+GGtJ3QyJUSrip9SI7oXmsJ4VnrvSgXnus9RZiA4m5AG1leknUYESRfIiJ1CcZZBtoxrRanwdTudrcmOfrQ3QkbDctS0dM4Sg07SEcVRYiVLgtn8sXB198LoTq9ApVm8RlbhZHhhNmBQFpyaDnsrL4QsbSJESdexOm2a4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qjcpxJee5lakUwNE+eJxosL/6vVG+F3zI8eGlUrYXFU=; b=rj1LCn9D4c/0YmGhFoznVZZCJh67w9J+U3LehYL02Ul+2x3DwfKV4O5tCZPy1AexHCivo4qdxioBScfcPuxIBRRYP+t3PTxsny3Lyw2kSfEKOL5Z2lhwCMWYHdvpX53iQR5GpA3llpeK3RqTL177ZMrkYRR+gxVNElvLsK5C0wk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DS7PR12MB9549.namprd12.prod.outlook.com (2603:10b6:8:24e::7) by PH7PR12MB7453.namprd12.prod.outlook.com (2603:10b6:510:20a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.159.19; Tue, 7 Jul 2026 10:41:53 +0000 Received: from DS7PR12MB9549.namprd12.prod.outlook.com ([fe80::bace:1330:9ab2:acc6]) by DS7PR12MB9549.namprd12.prod.outlook.com ([fe80::bace:1330:9ab2:acc6%6]) with mapi id 15.21.0181.009; Tue, 7 Jul 2026 10:41:53 +0000 Message-ID: Date: Tue, 7 Jul 2026 16:11:47 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] misc: Add Xilinx PUF driver To: Arnd Bergmann , Greg Kroah-Hartman , Michal Simek , linux-kernel@vger.kernel.org, sarat.chand.savitala@amd.com, nkowlaku@amd.com References: <20260707095620.2795456-1-h.jain@amd.com> <20260707095620.2795456-3-h.jain@amd.com> Content-Language: en-US From: "Jain, Harsh (AECG-SSW)" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN3PR01CA0025.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:97::9) To DS7PR12MB9549.namprd12.prod.outlook.com (2603:10b6:8:24e::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9549:EE_|PH7PR12MB7453:EE_ X-MS-Office365-Filtering-Correlation-Id: d08f9adc-35c4-4f5a-865d-08dedc145be9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|23010399003|366016|376014|3023799007|18002099003|22082099003|5023799004|11063799006|4143699003|56012099006; X-Microsoft-Antispam-Message-Info: 7Q2j9YQxOgJv9ig1JHYPrSl/HUQMnuZfJ9t2UW248JhBDPlSZTv+xG3UH2NDK76YpIU2K1h+RX6X0oLK+d2WE1AX/WbvdgR/Fhaj2G/jnwyuaVUrX5MIEK8ZB7xybcxAD+BUhlppaVo6a7vdSke+NEe3tCrG5kMXDho1EuXJrD0Sir6oJcw7fkxoTXJkUlZ2yV5i3opJCIXYRT40I4v854XbeQutYMnJheWhs1sqp/wL4bCzoX6Bqfy00jYqCFguTdU2ZRExz1bjmomup/f/CE3o8gENAa3JOxgDug/h7t/C1ow28RlUteQNBsSKeCVqqmQvAA47PW04Q+knGtoZVCXvX5/B+rpMTG1AA9MhjSD00KrUzaEWX2/OtXRkX8V6cuaVc+meUy0hog02VyKKVYy1gAfQWaEuKKhPe8C3t0YWSgRltasJnA3nftt74sl3aydGJRUrISzp8weWVQxwTgua/7utStGMZ2lVbbUi5W/4Lju5Gd7PpB2+fBQyu4R3SYsDz34nD1+PikkLhpR+GC/4UBX3fscamvzqfEKJlTn/9zSuLGOAgBYa3RvkMm8ew2rvQHx9beMa8X5pDNx72el/dXk/kzcQ3ql5AXthXn674c88AFy7zC/jtMh6pNzWXxUlfCOQnl+R0q/+6NU2vu5Bk7QIRlgF2urfCGkU2z0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9549.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(23010399003)(366016)(376014)(3023799007)(18002099003)(22082099003)(5023799004)(11063799006)(4143699003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TjZVekdiUU9DS0lWdUEweUFqbU1ab0F1STVKSXJLWVJ4WnhwUm9RTEkwVzhx?= =?utf-8?B?eHVzNE4zZ25ZV05hdVN0QmVuK1FUMEZCV0RibVVvV0tWWUU0S0VveDlVV2Ns?= =?utf-8?B?QjVDeUxKb0wwaFJrWEptVVpnMnpYNERWdGIzT25qcnpQci9QdUp2NTlHZTVT?= =?utf-8?B?aU1KREo2RGtzalpVbWQxbStsUEt4YXpycnhoaFRGODIyWDdxbkJ2U0xxT0Ni?= =?utf-8?B?cWY4b3FFcUp2ZWUraUkxT3NoeGswZ2FHSE1jYkhmRkloWjNtNnVDRWxwbVdy?= =?utf-8?B?QXRHa0tVU3g0S0F5dGFUSGNwSWxsMkF4bEJrakllUmcxaTBZMHhxNEIvSVpS?= =?utf-8?B?d2ZaNXA0S29pa1NGQzhvTCtYYldWS2dNSjBKOHlMRndzT0U4SGtHODlvV0g0?= =?utf-8?B?dGNSTGtRaTJJR1VIU2VJRmgxNGttYXdscDNscFkwUWU4a3hNdGVUdCtzMWJt?= =?utf-8?B?SDNmTVArb2dmRzhiYkNkQ3pSaTJRcUVBUmI3WHNCTTdTbHJ6cU51WkUxZkUz?= =?utf-8?B?U0NNRSthd2ZIMlBuRitaeTEzcUloWWZrak15bDNBTGpROUxFVnVIaGFEaEp0?= =?utf-8?B?YkZ2TVFWM3UrTWxwd2pXL2hxbmFmMVhOekc1UXFvUmt6eEVuUkduOXY2dHEw?= =?utf-8?B?cVJnSG5Oc3ZqRTM0QmJIclMvZlZQY2g0U3ZMOVVXdFo0b0dCMVdhRTkvRklO?= =?utf-8?B?RHZWdXBIL0x1Snd5d2pER0R6WDhlZzJDTHFHb1dZeldXSDQrdlhYUThhZE1n?= =?utf-8?B?ZjZmVHg0LzZ0eUJnYVhlSVJtZlFZcDJhbHBxT0JDM1dTZUhqMVRSSzFQRmh5?= =?utf-8?B?QlhyQ0tSQ29UMllqSnV4cmE5Znd5QzdBSXFuT2hzellBajZKVFZWOVBJM0tn?= =?utf-8?B?UTVOajFnZWRwOFhpSUVqQUFRR2VhaTlPZ2g5eXhUa1VvSVl6Z1ZzN1cwVlBk?= =?utf-8?B?cGZHVnlIVEJ6YmVySHk0Q1RpNVk3ZEE0RG45U1B2WHVjZHdIc1FRVyszZEhG?= =?utf-8?B?OVRzZFNudVdUS3ZjYnZTYWpWUjJKd0NKZnZqajhtbTdIQ2ZHR2RxbXBmWUtw?= =?utf-8?B?WGhOZks4ZHRxRUR3cFlEbGJMTHJzMDFxV0JoSUlDNEZydU12Qnd1d3E0b2hr?= =?utf-8?B?dzlRWHpZcVFSR1VGa1NDS01mZU5VU3JUTlVSZGJzVGV1N1JQOStzSkpCZVhI?= =?utf-8?B?M0k2TWh1TnQvNkcxYVB4MTl2YnhlRnpsdnhtbnN1UTF4NVdmZy9wYVZjWW5x?= =?utf-8?B?R2NwRkx6R2hnOXNaOWlBdHM3NWxKa0Y4Uk5sSUdOWDRJVXpyRTdlS1JZWjd5?= =?utf-8?B?L0xnSUJKOFpVVmZUZncxZDMzK2ZIY3NQTU9rRkpJLzFIYlI1WVBtSVkrNGlu?= =?utf-8?B?ZzYrOHkrWkdac01PeVZuUUIzZHVHVXczUVQ2SDFRZFc0N2VRKzk0STZyeWQ3?= =?utf-8?B?dlFDZHZrZ3J6N0dIalV1Z1ZRYVhDc2w3WE00aG5CdHhjbkt2dkdDSFVXdWRy?= =?utf-8?B?aXRnZGJzZ2xvRnlpamg2cE04Njh3Y0ZPSVFJTUlkVDNyMDNWdkVyUURRbkUz?= =?utf-8?B?a1VHbFdncmVSNDU1MVFncDZsY1EyVm9LZFR3dDR2dEt1bGw5N3czazhwNEdp?= =?utf-8?B?b0dMeEUvL3dtc053ZUhBZ1RySXZnRnlVbWhUeDMxKzNOV2ZHTTlQUmVFcTIx?= =?utf-8?B?TkY1S3Z4TmV0aDFabWFuRXlQNk9EekFOYnBVZnFGd2k2YVJ1aGoxY05xUzFx?= =?utf-8?B?V0FjL2ZxZ1M1VU4zNFV4WnpZMGI5T1IzczlSSnRnWFRJeWJ5b3NPNlBRSkFO?= =?utf-8?B?ckxta3E2bEUxbUwvWEw2S1Qwbk14OUM2ak9sSUhKdUZoakpTalRlVUxLaHg3?= =?utf-8?B?eThEOXE1dTAxZTRPaWpSOUw4TGFyZisyMTZtcUFiKzRvUms5WmNvQ0RhUSto?= =?utf-8?B?djBxc3l4ZUJHN1U3T2lKMzZaZXJDUTM3ZEVFbVVyaXlPRm9scXF1clY5NUVr?= =?utf-8?B?WUtaOXRuUS83SWRCcDFINTZMZitLdDhvYWdxcG1VZnNGeHRwcHh5Q2M5ZC9I?= =?utf-8?B?Um1KMlQzV2pXZjNDQjNpRFEybU5EbXk4N3VJVVh0Y05SQVI2SjRBRkRsWnVp?= =?utf-8?B?NHJhN0t3Mjk4YU9JVWhFbVIrTEszcFdEeWwvM3JXdHpjNks4ZFFKRTlvNDNP?= =?utf-8?B?SlJ0ZjZTMTBXUHJNeTVRYWNPSjVNS0hKczZuaWhWVERrc2ZFUnROT0NUSHlO?= =?utf-8?B?S1ZjdTlnblBFYW1tSDVicDR5YXVNc2tiUVphUHpoYUV1ZFJaVGZGY2ZaRVk5?= =?utf-8?Q?CNE1YZoSZrkokZaM0c?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d08f9adc-35c4-4f5a-865d-08dedc145be9 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9549.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2026 10:41:53.3915 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TPnnMSM2pzWO2D9PPl9klAPinOUdfmwAszJmsSKK7cc9gYVqJFi39O3KDAsmVboj X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7453 On 7/7/2026 3:34 PM, Arnd Bergmann wrote: > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > On Tue, Jul 7, 2026, at 11:56, Harsh Jain wrote: >> Versal devices contain a physically unclonable function (PUF) block >> that derives device-unique secrets from intrinsic silicon >> characteristics. The PUF generates a Key Encryption Key (KEK) used >> internally by the AES engine for secure key storage, which is not >> externally accessible. In addition, the PUF provides a readable >> device-unique identifier derived from the same entropy source. >> >> Add a misc character driver to support PUF registration and regeneration. >> Registration generates a unique secret and outputs binary helper data >> that can later be used during regeneration to reproduce the same >> secrets. >> >> The driver also implements PUF_CLEAR_ID and PUF_CLEAR_KEY ioctls to clear >> the PUF ID and PUF-derived AES key via firmware. They are disabled by default >> unless puf_clear is set. >> >> Signed-off-by: Harsh Jain > Hi Harsh, > > This description sounds like it should be integrated into the > existing crypto infrastructure of the kernel. I'm not sure > what the exact feature set in your hardware is like, but > please work with the crypto and keyctl maintainers to either > use that infrastructure, or extend it to your requirements > instead of adding a custom ioctl interface. > > My guess would be that you can have a driver similar > to drivers/platform/cznic/turris-omnia-mcu-keyctl.c > for managing private keys in the hardware and managing > it through the keyctl(2) infrastructure. Have you looked > at this already? Thanks Arnd for quick feedback. I will check the mentioned subsystem. > > Arnd