From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10829C432C3 for ; Thu, 14 Nov 2019 06:02:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F116B206CC for ; Thu, 14 Nov 2019 06:02:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726812AbfKNGC0 (ORCPT ); Thu, 14 Nov 2019 01:02:26 -0500 Received: from out30-130.freemail.mail.aliyun.com ([115.124.30.130]:37076 "EHLO out30-130.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725601AbfKNGCZ (ORCPT ); Thu, 14 Nov 2019 01:02:25 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=|;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01f04446;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=16;SR=0;TI=SMTPD_---0Ti22RJM_1573711340; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0Ti22RJM_1573711340) by smtp.aliyun-inc.com(127.0.0.1); Thu, 14 Nov 2019 14:02:21 +0800 Subject: Re: [PATCH v2 6/8] mm/lru: remove rcu_read_lock to fix performance regression To: Mel Gorman Cc: Matthew Wilcox , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, Johannes Weiner , Roman Gushchin , Shakeel Butt , Chris Down , Thomas Gleixner References: <1573567588-47048-1-git-send-email-alex.shi@linux.alibaba.com> <1573567588-47048-7-git-send-email-alex.shi@linux.alibaba.com> <20191112143844.GB7934@bombadil.infradead.org> <20191113114045.GZ3016@techsingularity.net> From: Alex Shi Message-ID: Date: Thu, 14 Nov 2019 14:02:20 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <20191113114045.GZ3016@techsingularity.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2019/11/13 下午7:40, Mel Gorman 写道: >> Hi Matthew, >> >> Very sorry for your time! The main reasons I use a separate patch since a, Intel 0day asking me to credit their are founding, and I don't know how to give a clearly/elegant explanation for a non-exist regression in a fixed patch. b, this regression is kindly pretty tricky. Maybe it's better saying thanks in version change log of cover-letter? >> > Add something like this to the patch > > [lkp@intel.com: Fix RCU-related regression reported by LKP robot] > Signed-off-by: Alex Shi It's a good idea! Thanks a lot, Mel!