From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50B7EC77B62 for ; Fri, 31 Mar 2023 08:55:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230007AbjCaIzz (ORCPT ); Fri, 31 Mar 2023 04:55:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229792AbjCaIzw (ORCPT ); Fri, 31 Mar 2023 04:55:52 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0538310E7 for ; Fri, 31 Mar 2023 01:55:51 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id br6so27952772lfb.11 for ; Fri, 31 Mar 2023 01:55:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680252949; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4dm+BPEOnC7e4hjDLH6po2CUlQmPHlDI5qtCyO0in2Q=; b=h9p+asgoR7hjf3xWGqt0dESGNOGLYImfThLBriNOU0tdhyee4Dj/v82aPxY1l+yshP rJxuPxGgYI6jUI6DBjgYqYHHxlm+3k4RYYjQX99sNkOanqarLy2UZMupY9g1Qv7egTfD 3iQbRP3qKjrBlBC8MLOcVhwBkT2DGC+KDRqi3qP+7TvgmVGRfbMfZRu/AYlQ4SaPljzg eKCGp/zIAvGJhIBwkH1RyLPXBc3rwVclVdlHiyQi2cfc80JRI6qtQmM/Tw/rIsAQTfyg fAv4m06xtOPLY7yFFiKTKST/6WJIbCvp+KFLiospIbLfJzI44pgopG9eozFO+yO6h/5e dQkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680252949; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4dm+BPEOnC7e4hjDLH6po2CUlQmPHlDI5qtCyO0in2Q=; b=kXsHo1QPsLDd1DHDn9Vi3oXZFeABh359ud0sKvnWgu9pb2CXd9BuTBkDtotHgY8FCs 8yYX2ewV9Vbj3EEqad5TkKjcHh8y86ShzNAac0Dekqqckbda731WOWJsdyXC531nlh0q 2ab0BZfmQ4rzsNbrGzsl1nUH2vyJ8EEU+UjJoN2/2QDiONPqT0PCA57GdcbJMCfhx8MI Mu20uPxmwx0XkoSvUgbw2hEfnUT6qIyWBRJere+UESfZWpEvHGGme2DbdzLzQ3hY09x/ imiqeR0gMd/iI0NSxtzUVa3ki2C171zd40ol6z7187fFH+j0B/XaY2f4mZ/BEf2uD+Xe FTWw== X-Gm-Message-State: AAQBX9d3AyDqaqmrju+3Gy47c4TSctn7TnnaqoKnYE/wlGX/B1qrQu1b yBGK89fvJXKZZ1G1xHojgiyAUQ== X-Google-Smtp-Source: AKy350ZI/3UGdFSqbHDvzrq0gk2lxo1Tz6xoBuV/VTSFHLt8yiKO4pkQahghPdhIFyzf5V5sRpBGCA== X-Received: by 2002:a19:f619:0:b0:4d5:831a:1af8 with SMTP id x25-20020a19f619000000b004d5831a1af8mr7934107lfe.40.1680252949296; Fri, 31 Mar 2023 01:55:49 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id z9-20020ac25de9000000b004eb2dab8a61sm294109lfq.44.2023.03.31.01.55.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Mar 2023 01:55:48 -0700 (PDT) Message-ID: Date: Fri, 31 Mar 2023 10:55:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [RFC PATCH v2 5/6] dt-bindings: cpufreq: add bindings for virtual kvm cpufreq Content-Language: en-US To: David Dai , "Rafael J. Wysocki" , Viresh Kumar , Rob Herring , Krzysztof Kozlowski , Paolo Bonzini , Jonathan Corbet , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider Cc: Saravana Kannan , kernel-team@android.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev References: <20230331014356.1033759-1-davidai@google.com> <20230331014356.1033759-6-davidai@google.com> From: Krzysztof Kozlowski In-Reply-To: <20230331014356.1033759-6-davidai@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/03/2023 03:43, David Dai wrote: > Add devicetree bindings for a virtual kvm cpufreq driver. Why? Why virtual devices should be documented in DT? DT is for non-discoverable hardware, right? You have entire commit msg to explain it instead of saying something easily visible by the diff. > > Co-developed-by: Saravana Kannan > Signed-off-by: Saravana Kannan > Signed-off-by: David Dai > --- > .../bindings/cpufreq/cpufreq-virtual-kvm.yaml | 39 +++++++++++++++++++ > 1 file changed, 39 insertions(+) > create mode 100644 Documentation/devicetree/bindings/cpufreq/cpufreq-virtual-kvm.yaml > > diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-virtual-kvm.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-virtual-kvm.yaml > new file mode 100644 > index 000000000000..31e64558a7f1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-virtual-kvm.yaml > @@ -0,0 +1,39 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/cpufreq/cpufreq-virtual-kvm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Virtual KVM CPUFreq > + > +maintainers: > + - David Dai > + > +description: | Do not need '|'. > + Drop stray blank line. > + KVM CPUFreq is a virtualized driver in guest kernels that sends utilization > + of its vCPUs as a hint to the host. The host uses hint to schedule vCPU > + threads and select CPU frequency. It enables accurate Per-Entity Load > + Tracking for tasks running in the guest by querying host CPU frequency > + unless a virtualized FIE exists(Like AMUs). No clue why you need DT bindings for this. KVM has interfaces between host and guests. > + > +properties: > + compatible: > + const: virtual,kvm-cpufreq > + > +required: > + - compatible > + > +additionalProperties: false > + > +examples: > + - | > + { This is some broken syntax and/or indentation. I don't get what this node is about. > + #address-cells = <2>; > + #size-cells = <2>; Why? > + > + cpufreq { > + compatible = "virtual,kvm-cpufreq"; > + }; > + Drop stray blank lines > + }; Best regards, Krzysztof