From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1383C20010A for ; Thu, 30 Jul 2026 05:03:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785387834; cv=none; b=kehFgfdwQ5v9PXvz2H+C2lVYkvTEROXVVTGVKrrEDourh8XV6xyqclx81aDRpxPs1IA4evf93f3oK8iBJrHfUNcEvLX71w7Apg2SNvynAiLIJ7Jd9JDzyggsDpWbVs/BQ+N4eOjfKPMIU9YQtnyegZ/MmxgKaWR1Sw1SPPPieCk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785387834; c=relaxed/simple; bh=uMIrjqKk4RgBAzI+jZ6xHtZNARP5qo72487b1xnhPJE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FynGQiR40+HjxxpRvjQFcejgQhkBFaWWlE9bkDGTyNTQAaQCs4wst7JDvsFU6KEtJY3ZABoT8qJcNbWEOudG7Ny7WxBeqoVc9C43qSUsYwcktBdPHsh4RPAOkd1UH42w8CqcYhM2ygrSPjaRSWK759FxtDww8G5wEgjVL6qr06I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=pass smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=c4d67tCD; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="c4d67tCD" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=rJjPlgr19BPgTXrhWH6UpTJ4lGsLyVDJ6qeBEB42M8I=; b=c4d67tCD1HtugX9WD1UrWEgXm7 04cvST81cEdxS4VbWat8/xkjEqYFMktY33p3T8GPMFqcCU5fLpcHYBkAwIn5r7d4GljQzYr+nPN1y Ie4j12MKOwghLG/sUWs0YUNes5WeiHxhnRD2rXyihglwaus94ptqXhkRAM2mmosWnMVsezoJa4/Ib O1EzvqP1xHqEhyIj9SDCfF0Aewj+j1DNcDq2j0oGQmM2+DHO4Y+T+Rt8u8BSlz3ChVtJoCtZu/09j SMSoDrulbi9RwC1Zi7efu9XcmIORk9pNVRDNYJ0V1QR2KM7VAR+d7yLMrBlanmKMs53jDgxiofNFL p5chBE+w==; Received: from [50.53.43.113] (helo=[192.168.254.34]) by bombadil.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wpIvu-00000009Wft-2gpT; Thu, 30 Jul 2026 05:03:50 +0000 Message-ID: Date: Wed, 29 Jul 2026 22:03:49 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] misc: issei: hw_heci: fix dev_err format warnings To: linux-kernel@vger.kernel.org Cc: Vitaly Lubart , Alexander Usyskin , Greg Kroah-Hartman , Arnd Bergmann References: <20260730042227.595683-1-rdunlap@infradead.org> Content-Language: en-US From: Randy Dunlap In-Reply-To: <20260730042227.595683-1-rdunlap@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 7/29/26 9:22 PM, Randy Dunlap wrote: > Use "%u" instead of "%lu" to prevent dev_err format warnings: > > In file included from ../drivers/misc/issei/hw_heci.c:7: > ../drivers/misc/issei/hw_heci.c: In function ‘heci_write_hbuf’: > ../drivers/misc/issei/hw_heci.c:374:37: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘unsigned int’ [-Wformat=] > 374 | dev_err(&idev->dev, "Data size %zu not aligned to slot size %lu\n", > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ../drivers/misc/issei/hw_heci.c: In function ‘heci_read_hbuf’: > ../drivers/misc/issei/hw_heci.c:404:37: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘unsigned int’ [-Wformat=] > 404 | dev_err(&idev->dev, "Data size %zu not aligned to slot size %lu\n", > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Fixes: 8bf5e84998c3 ("issei: add heci hardware module") > Signed-off-by: Randy Dunlap > --- > Cc: Vitaly Lubart > Cc: Alexander Usyskin > Cc: Greg Kroah-Hartman > Cc: Arnd Bergmann > > drivers/misc/issei/hw_heci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- linux-next-20260729.orig/drivers/misc/issei/hw_heci.c > +++ linux-next-20260729/drivers/misc/issei/hw_heci.c > @@ -371,7 +371,7 @@ static int heci_write_hbuf(struct issei_ > struct issei_heci_hw *hw = to_heci_hw(idev); > > if (!IS_ALIGNED(data_len, CB_SLOT_SIZE)) { > - dev_err(&idev->dev, "Data size %zu not aligned to slot size %lu\n", > + dev_err(&idev->dev, "Data size %zu not aligned to slot size %u\n", > data_len, CB_SLOT_SIZE); > return -EINVAL; > } > @@ -401,7 +401,7 @@ static int heci_read_hbuf(struct issei_d > u32 *reg_buf = data; > > if (!IS_ALIGNED(data_len, CB_SLOT_SIZE)) { > - dev_err(&idev->dev, "Data size %zu not aligned to slot size %lu\n", > + dev_err(&idev->dev, "Data size %zu not aligned to slot size %u\n", > data_len, CB_SLOT_SIZE); > return -EINVAL; > } Please ignore for now. I get conflicting reports before/after this patch. (!?) -- ~Randy