mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Martin Peres <martin.peres@free.fr>
To: Colin King <colin.king@canonical.com>,
	Ben Skeggs <bskeggs@redhat.com>, David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [Nouveau] [PATCH] drm/nouveau/therm: fix spelling mistake on array thresolds
Date: Tue, 27 Jun 2017 13:07:45 +0300	[thread overview]
Message-ID: <e293780c-4e02-025b-2cf5-f41b8a3cd659@free.fr> (raw)
In-Reply-To: <20170627080858.12218-1-colin.king@canonical.com>

On 27/06/17 11:08, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Array thresolds should be named thresholds, rename it. Also make it static
> static const char * const
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks for doing this,

Reviewed-by: Martin Peres <martin.peres@free.fr>

> ---
>   drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c
> index e93b2410c38b..6449771b9dc6 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c
> @@ -83,7 +83,7 @@ nvkm_therm_sensor_event(struct nvkm_therm *therm, enum nvkm_therm_thrs thrs,
>   {
>   	struct nvkm_subdev *subdev = &therm->subdev;
>   	bool active;
> -	const char *thresolds[] = {
> +	static const char * const thresholds[] = {
>   		"fanboost", "downclock", "critical", "shutdown"
>   	};
>   	int temperature = therm->func->temp_get(therm);
> @@ -94,10 +94,10 @@ nvkm_therm_sensor_event(struct nvkm_therm *therm, enum nvkm_therm_thrs thrs,
>   	if (dir == NVKM_THERM_THRS_FALLING)
>   		nvkm_info(subdev,
>   			  "temperature (%i C) went below the '%s' threshold\n",
> -			  temperature, thresolds[thrs]);
> +			  temperature, thresholds[thrs]);
>   	else
>   		nvkm_info(subdev, "temperature (%i C) hit the '%s' threshold\n",
> -			  temperature, thresolds[thrs]);
> +			  temperature, thresholds[thrs]);
>   
>   	active = (dir == NVKM_THERM_THRS_RISING);
>   	switch (thrs) {
> 

      reply	other threads:[~2017-06-27 10:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-27  8:08 Colin King
2017-06-27 10:07 ` Martin Peres [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e293780c-4e02-025b-2cf5-f41b8a3cd659@free.fr \
    --to=martin.peres@free.fr \
    --cc=airlied@linux.ie \
    --cc=bskeggs@redhat.com \
    --cc=colin.king@canonical.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®