From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8374237B031 for ; Fri, 13 Mar 2026 09:49:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773395368; cv=none; b=qs7ToINTl7O3K6GXMvsggUUwbCsQSDF2jhgYSmDr6pS5NyRUWHAe0VZpZC6FW9I5WR8L63U4g12F3ZYbcNQTXBOo3ga8FjeNYbC9IL4JYiF4ERFJLme8En3tF+0i5xu2lQNhOQdfdK63h6OkDiQw+ufmjUisO4UneBq2n6FAT+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773395368; c=relaxed/simple; bh=IwcaY8eaggeIn6MMtHGJ1IROj49OmXUpwa6sUyG68vw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VycadYxwsSTLP3N+VV6o8D64u8smkTLFf3hwJRNKD53TQJ8+H7oCjx63cziYjEBWPATaxattSumPMUmDbicOWPn6Coo1OARH5BK/WG7/sS8qkk/nelxhdrVbPUFQf1h1w2m2XGqothwhDeAUPjaedHs6d4T3Wcnzy8jVApQ/VRM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HPsUIKkz; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HPsUIKkz" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-b972641eb96so257415266b.2 for ; Fri, 13 Mar 2026 02:49:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773395365; x=1774000165; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=M8FS5yYGjX67AwqiomjlT3iHM2nG+cI6PJzSIUbSTVE=; b=HPsUIKkzS5xXndD/Mu6md4Myn8EJoc55Ws3BZlogUARhzhof1toQw+RAjE3ZVjb8cb tF87CBbgITMEEB48oxjljByJND1a2aOJbrYKHiDRQOsfPAmsYptw4oqpSwZkyt05W3RM DbgwGRkiX/Y+Q/o4trKFnRCbGGTo2xFPEQyW4gcxup8lby4mx3HPNi9Z8TOPiQaeb3JZ kyG3AeV+SflD+56TSLJxHY5F/5+KUGTCQBQ45+NxmahqUCsgoFSFdxzx+d9CbogbDfR8 FLED8HhCVNTZpwEVappKHYmvCuTkxqVij6aA7E5VyM80MiNugQj1S73LZsa0VXvOo45B PjoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773395365; x=1774000165; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=M8FS5yYGjX67AwqiomjlT3iHM2nG+cI6PJzSIUbSTVE=; b=O1NJSv86TzjZkUK+KhIiK/Q5OUUGdyetR75QvTgrawbtnPl1ttwzzivIjzpseTnl8B zM52gfAeOTneEt+kon7hhEGbWTT2wyqxWeuEmB9FayVCWGH/rY89NErEAxHr0wa5cGg5 z63Pt9610ISkuL8xZetTrJmymSUKEyVZeudJRHfCU4YRUd7Mpkz2mJwwxuMYPXa429fk ivTNRATwlH+yB8IpF8QMkUa4qiGCBw0urLam8jF/EGVdq+zfO06LmLDQSury37SdAGQA wjorB5DdhpbJUcmcLebnoLFLIoJubzI/UJKUs30GsVI1TwUz8Hj0cWrxe8T+E5Nh7QFy zv5g== X-Forwarded-Encrypted: i=1; AJvYcCVLXRlHsQWW7OY6KY2xEsbhssmfSWX1IYwWrhuPRX36vP8p50I1VAVieUbtKt6H9ZW4RAWbBL2Nr61+ikM=@vger.kernel.org X-Gm-Message-State: AOJu0YxguX/+JLuVElTA70EqnpaR0xSj6cNVSAlCBOqoIC6F3/UvixWV iDDmbUvRNj7q2lo+C6wDuS48XxqiDjDg9MY9Htx9wvtimC8Ov6OML0cX9rO9JEsR4+8= X-Gm-Gg: ATEYQzwMKeTR4rco2sDnSN9ll+SUlTII6p6Gazyx2b7HCE9O0toYVctHrG8lCMw0ZdS wWuw5Kq5nOYeM8YKbgKe+bfRzig2ogwiNkM3WFnHZxADZYfI7RENrEFaW+drIOxAwVZo1y9I24r abkmUfk1x4o4xsow5lnIQHFZIS76gZldm3B3kN8SdikGJUB5AjXwPrHpR5Np/uT3pWsH1H5M9OU nos25Qh73hF680EjtsR67ToHmicFGvCeAiOOBIXW6tWaSyNX9N1MNOFUmkAlpH5kC6crDzhItq4 SYaSGkPdcyjC3XvFgn07qS3ymn4FNpp9eUoLLR4kI8kGrMMa8J6WXuN2vXIxM49NnEW+h9RF0+/ wnQpJx4PWquAoKQSsmflywIjpepmR4joiV6IIRVAc4O9X6wSZMM5vvIyjxQXtfTrwMM6EdzTMUG braZkXGryG1Zxa1CXV/VlrwNYnX8Ttw7/0a/oz X-Received: by 2002:a17:907:7294:b0:b8a:f61a:edf2 with SMTP id a640c23a62f3a-b9765352458mr149879066b.50.1773395364637; Fri, 13 Mar 2026 02:49:24 -0700 (PDT) Received: from [192.168.0.101] ([109.76.176.163]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b976d0b7722sm32825966b.66.2026.03.13.02.49.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 02:49:23 -0700 (PDT) Message-ID: Date: Fri, 13 Mar 2026 09:49:22 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] media: qcom: camss: Add missing clocks for VFE lite on 8775p To: Wenmeng Liu , Robert Foss , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , Hans Verkuil , Vikram Sharma , Suresh Vankadara , Wenmeng Liu Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260313-vfelite_fix-v1-0-2ee7de00dee7@oss.qualcomm.com> <20260313-vfelite_fix-v1-2-2ee7de00dee7@oss.qualcomm.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20260313-vfelite_fix-v1-2-2ee7de00dee7@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/03/2026 09:42, Wenmeng Liu wrote: > Add missing required clocks (cpas_ahb and camnoc_axi) for VFE lite > instances on 8775p platform. These clocks are necessary for proper > VFE lite operation: > > Fixes: e7b59e1d06fb ("media: qcom: camss: Add support for VFE 690") > Signed-off-by: Wenmeng Liu > --- > drivers/media/platform/qcom/camss/camss.c | 40 +++++++++++++++++++------------ > 1 file changed, 25 insertions(+), 15 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c > index 4a0bf8acd7645f8cd8c1b4cb9b6ff6f3a54d42e8..d325539defbecc7f4fbcb9d20fb69884e109a459 100644 > --- a/drivers/media/platform/qcom/camss/camss.c > +++ b/drivers/media/platform/qcom/camss/camss.c > @@ -3746,15 +3746,17 @@ static const struct camss_subdev_resources vfe_res_8775p[] = { > /* VFE2 (lite) */ > { > .regulators = {}, > - .clock = { "cpas_vfe_lite", "vfe_lite_ahb", > + .clock = { "cpas_ahb", "cpas_vfe_lite", "vfe_lite_ahb", > "vfe_lite_csid", "vfe_lite_cphy_rx", > - "vfe_lite"}, > + "vfe_lite", "camnoc_axi"}, > .clock_rate = { > - { 0, 0, 0, 0 }, > + { 0 }, > + { 0 }, > { 300000000, 400000000, 400000000, 400000000 }, > { 400000000, 400000000, 400000000, 400000000 }, > { 400000000, 400000000, 400000000, 400000000 }, > { 480000000, 600000000, 600000000, 600000000 }, > + { 400000000 }, > }, > .reg = { "vfe_lite0" }, > .interrupt = { "vfe_lite0" }, > @@ -3769,15 +3771,17 @@ static const struct camss_subdev_resources vfe_res_8775p[] = { > /* VFE3 (lite) */ > { > .regulators = {}, > - .clock = { "cpas_vfe_lite", "vfe_lite_ahb", > + .clock = { "cpas_ahb", "cpas_vfe_lite", "vfe_lite_ahb", > "vfe_lite_csid", "vfe_lite_cphy_rx", > - "vfe_lite"}, > + "vfe_lite", "camnoc_axi"}, > .clock_rate = { > - { 0, 0, 0, 0 }, > + { 0 }, > + { 0 }, > { 300000000, 400000000, 400000000, 400000000 }, > { 400000000, 400000000, 400000000, 400000000 }, > { 400000000, 400000000, 400000000, 400000000 }, > { 480000000, 600000000, 600000000, 600000000 }, > + { 400000000 }, > }, > .reg = { "vfe_lite1" }, > .interrupt = { "vfe_lite1" }, > @@ -3792,15 +3796,17 @@ static const struct camss_subdev_resources vfe_res_8775p[] = { > /* VFE4 (lite) */ > { > .regulators = {}, > - .clock = { "cpas_vfe_lite", "vfe_lite_ahb", > + .clock = { "cpas_ahb", "cpas_vfe_lite", "vfe_lite_ahb", > "vfe_lite_csid", "vfe_lite_cphy_rx", > - "vfe_lite"}, > + "vfe_lite", "camnoc_axi"}, > .clock_rate = { > - { 0, 0, 0, 0 }, > + { 0 }, > + { 0 }, > { 300000000, 400000000, 400000000, 400000000 }, > { 400000000, 400000000, 400000000, 400000000 }, > { 400000000, 400000000, 400000000, 400000000 }, > { 480000000, 600000000, 600000000, 600000000 }, > + { 400000000 }, > }, > .reg = { "vfe_lite2" }, > .interrupt = { "vfe_lite2" }, > @@ -3815,15 +3821,17 @@ static const struct camss_subdev_resources vfe_res_8775p[] = { > /* VFE5 (lite) */ > { > .regulators = {}, > - .clock = { "cpas_vfe_lite", "vfe_lite_ahb", > + .clock = { "cpas_ahb", "cpas_vfe_lite", "vfe_lite_ahb", > "vfe_lite_csid", "vfe_lite_cphy_rx", > - "vfe_lite"}, > + "vfe_lite", "camnoc_axi"}, > .clock_rate = { > - { 0, 0, 0, 0 }, > + { 0 }, > + { 0 }, > { 300000000, 400000000, 400000000, 400000000 }, > { 400000000, 400000000, 400000000, 400000000 }, > { 400000000, 400000000, 400000000, 400000000 }, > { 480000000, 600000000, 600000000, 600000000 }, > + { 400000000 }, > }, > .reg = { "vfe_lite3" }, > .interrupt = { "vfe_lite3" }, > @@ -3838,15 +3846,17 @@ static const struct camss_subdev_resources vfe_res_8775p[] = { > /* VFE6 (lite) */ > { > .regulators = {}, > - .clock = { "cpas_vfe_lite", "vfe_lite_ahb", > + .clock = { "cpas_ahb", "cpas_vfe_lite", "vfe_lite_ahb", > "vfe_lite_csid", "vfe_lite_cphy_rx", > - "vfe_lite"}, > + "vfe_lite", "camnoc_axi"}, > .clock_rate = { > - { 0, 0, 0, 0 }, > + { 0 }, > + { 0 }, > { 300000000, 400000000, 400000000, 400000000 }, > { 400000000, 400000000, 400000000, 400000000 }, > { 400000000, 400000000, 400000000, 400000000 }, > { 480000000, 600000000, 600000000, 600000000 }, > + { 400000000 }, > }, > .reg = { "vfe_lite4" }, > .interrupt = { "vfe_lite4" }, > Reviewed-by: Bryan O'Donoghue --- bod