From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72B29C433EF for ; Mon, 28 Feb 2022 16:25:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237908AbiB1QZs (ORCPT ); Mon, 28 Feb 2022 11:25:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232766AbiB1QZq (ORCPT ); Mon, 28 Feb 2022 11:25:46 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C20575E7B for ; Mon, 28 Feb 2022 08:25:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1646065507; x=1677601507; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=et847OQQ3mcoZ5+BEptPvOyvcAVF4lTBNLhOTaaoa3U=; b=sQmyt9i0LmrHB6EEb0UrUpZJ43SEBPQFRWDlIhin8CjbJwMgQAXRwr0h r29sKDiniYuZ9HZsRq0Cj862YTla6pvXQ9K45fOuuKmEV5Q8+lFMwgZtc maMxXhjX+cLdFu6aq2m1HRwiqIXZrztKlwOvqXyHEsPixMCxJyH3yanXw KR2htLcZOHZigiEFjHJgia1Kt/D1lHokPi9nr/VouT3MycBHaCIAZUEmJ 99gtLPcWrMl2XHjSK+KdGpWLARDeAgp4xpeC/E0DgPrYt1j2K/itbJ0aC JC7eGf2Bttkfcj206+Re1W/hZzJEU6YiODnV03URJxQR3Bb4Hn8kh2L3t g==; X-IronPort-AV: E=Sophos;i="5.90,142,1643698800"; d="scan'208";a="150257703" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 28 Feb 2022 09:25:06 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Mon, 28 Feb 2022 09:25:06 -0700 Received: from [10.12.72.64] (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Mon, 28 Feb 2022 09:25:05 -0700 Message-ID: Date: Mon, 28 Feb 2022 17:25:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] soc: microchip: make mpfs_sys_controller_put static Content-Language: en-US To: Arnd Bergmann , Conor Dooley CC: , Olof Johansson , linux-riscv , Linux ARM , Linux Kernel Mailing List , kernel test robot References: <20220226124826.1564871-1-mail@conchuod.ie> From: Nicolas Ferre Organization: microchip In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/02/2022 at 16:42, Arnd Bergmann wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Sat, Feb 26, 2022 at 1:48 PM Conor Dooley wrote: >> >> From: Conor Dooley >> >> dsafsdfd0054 ("soc: add microchip polarfire soc system controller") >> incorrectly exported mpfs_sys_controller_put. Remove the export and make >> the function static instead. This fixes the "no previous prototype >> for 'mpfs_sys_controller_put'" warning spotted by the kernel test robot. >> >> Fixes: dsafsdfd0054 ("soc: add microchip polarfire soc system >> controller") >> Reported-by: kernel test robot >> Signed-off-by: Conor Dooley >> Signed-off-by: Conor Dooley > > For reference, I saw the same report and added a different fix for this > at first, but replaced it with this patch now. No need to add it to the at91 > tree. Nicolas, in case there is another problem with this patch, let me know. Ok Arnd, thanks. For the record: Reviewed-by: Nicolas Ferre -- Nicolas Ferre