From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755076Ab3LDIfN (ORCPT ); Wed, 4 Dec 2013 03:35:13 -0500 Received: from mail.kmu-office.ch ([178.209.48.102]:37120 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754762Ab3LDIfL (ORCPT ); Wed, 4 Dec 2013 03:35:11 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Date: Wed, 04 Dec 2013 09:40:46 +0100 From: Stefan Agner To: Lee Jones Cc: swarren@wwwdotorg.org, thierry.reding@gmail.com, dev@lynxeye.de, lgirdwood@gmail.com, broonie@kernel.org, kai.poggensee@avionic-design.de, sameo@linux.intel.com, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/3] mfd: tps6586x: add version detection In-Reply-To: <20131204081021.GB7469@lee--X1> References: <77384d24810d9a22fc04cad6f7468f54a9cbaafe.1386108712.git.stefan@agner.ch> <20131204081021.GB7469@lee--X1> Message-ID: User-Agent: Roundcube Webmail/0.9.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2013-12-04 09:10, schrieb Lee Jones: >> +int tps6586x_get_version(struct device *dev) >> +{ >> + struct tps6586x *tps6586x = dev_get_drvdata(dev); >> + >> + return tps6586x->version; >> +} >> +EXPORT_SYMBOL_GPL(tps6586x_get_version); > > I thought Mark suggested that this routine was converted to a 'static > inline' and moved into the header? Did you not think this was a good > idea? As I pointed out in the comment above, the struct tps6586x is in the C file, so I would need to move that too. That's why I did not made that change in the end. What do you think, should I still move (and move the struct too?)