From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 970F334E754 for ; Tue, 19 May 2026 05:53:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.12 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779170002; cv=fail; b=Xeiq3VKs5dLiZbyAu8uQ0SPynk7OKhkJrvLK/6ygaCCR9jqovcXaIcu7xM1VeLCDN+PNHadmRxT0KdEFgjtS/kgMVd2fQsp2VoDINM+dbO8gMiBPNOokoJO1C3PH3+9544WXKmMC1URXEDbWtOPrG8Tz0RjQPotpG3X/m5C5Sb4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779170002; c=relaxed/simple; bh=Too3UA5aiWMl2o4/95ANFkpQuXrmGaSFE85CukDMup0=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=MS5bthTBS3pLBBRJ31NMVLPtoYLs5aDaHPEfR0PorIlcIKWr+beyv9VmIScaZ5vcYD5qHZ/sJg5r8gxs8qAXDdRF0p70jKAj9tzwX6EGUrl9b2CcrwoPvZ7aqwPNJhIP4a0YszonW3deIyvZyEt7l16HMIjkx3O/Y/DFb9c+6Pc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=PRRF23CO; arc=fail smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="PRRF23CO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1779170001; x=1810706001; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=Too3UA5aiWMl2o4/95ANFkpQuXrmGaSFE85CukDMup0=; b=PRRF23COIPCfXVxRYtA0TSIGuBwCQyYB14FOsoTNLssESIp8TbwQOXgY e+/YqsoUfUszMp6/7iVXsktazlsg0MhDDcFWuLoTUC0H5S/6RvHK4HSxV 9V2rOsQcP5P+EM3Fsz2t+uQYWxG14CapdnSiu+nkzPKp18twUqBOsKFVD Kyt/pv3KSgP9LQmJc6pfgbQnw3tBsdZXiBZgPBIA6HC/B2x6MW98ec6Xi JMJz2KnOxs6xCapyc7g3RTm8+tj+z33r5o+7K3cSsQ1HYgufNSCd0bJZC pQO+CxsGQJdkaJttvTmpgcOM9mOiF1cfYPd3npsJ/WVLS8lLCTtfBcFyv g==; X-CSE-ConnectionGUID: WzoDnAObShOJ//lXh9qFAg== X-CSE-MsgGUID: rXVW9+FJTUOqwoOl8N47jQ== X-IronPort-AV: E=McAfee;i="6800,10657,11790"; a="91501519" X-IronPort-AV: E=Sophos;i="6.23,243,1770624000"; d="scan'208";a="91501519" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2026 22:53:20 -0700 X-CSE-ConnectionGUID: 2QkwZ/UnRSCY2TD8UschUQ== X-CSE-MsgGUID: yvwXA3dZQE+iuEYR3Gxcjg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,243,1770624000"; d="scan'208";a="238670225" Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by orviesa006.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2026 22:53:20 -0700 Received: from ORSMSX902.amr.corp.intel.com (10.22.229.24) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Mon, 18 May 2026 22:53:18 -0700 Received: from ORSEDG902.ED.cps.intel.com (10.7.248.12) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Mon, 18 May 2026 22:53:18 -0700 Received: from PH8PR06CU001.outbound.protection.outlook.com (40.107.209.38) by edgegateway.intel.com (134.134.137.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Mon, 18 May 2026 22:53:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HKZQwAxiwIdmtuandanWHD2Luof+dn724/p9bEM+P/axlt5r+Oky8NVp0stWKhORTDu+h2OsO9uMWVA4lw9qmoLUOliZdLxyyJzcoHTNMx/QrOyv0SnnLK2TauK4gceHGMqJesLfh3p8DcGA3qUQKTLJWMvLzNRtXFmbI/1cZi6CpWssiD7l2p92t+G2/6/cG7Bq8ki9TLP198DTq2Wj9vr0+WUKG/ccWu7xf/hd7bz/wHbLg8sFLpJxAtb1cdPGOi6PUFURkU+a3OFaCgS8zULH4UyL48ZAsm1Oe8SCAHIlrLQUdsuRwcGFm4FHOP4Gn/QxQtW4fO1PU86Gy86vVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fZc1HOULujP3E8EmycFz3/JbgwndHeQjXPovDiyM+w8=; b=Y6GpKzRKu0RKKwT6FqK4Z6YwNnHyC+hVq5R2mTP/3zcb5DvvXZEAxOCdlFspFcjyFzEz8ozkFskaKyIcOJudR7JZFP+uqyocDDkHqZr0KlFNuUWruNXlQVBdCkavPQIi+h9Njy1Xc5wQi53Zel78xtY+yYHj3yPD5HsJqUA47nj2E7X2Ebhb7e/hMze4Fy/gepcj060cs1VOUuxSeaMw9qd6otJMTjYx3w9ofGyBV71+VRdIMkTrBByhFwzBf1X+kmq7iaCcamKAJ8FyOzzS7ZQ3eWqymGBxWXSd6tR+ADB7SPgGjCIJKkhae0GO/ZwuIjIjGRKYQUaOsG3h/a/7vA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6020.namprd11.prod.outlook.com (2603:10b6:8:61::19) by SJ1PR11MB6298.namprd11.prod.outlook.com (2603:10b6:a03:457::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.24; Tue, 19 May 2026 05:53:14 +0000 Received: from DM4PR11MB6020.namprd11.prod.outlook.com ([fe80::3058:1480:e4ac:5765]) by DM4PR11MB6020.namprd11.prod.outlook.com ([fe80::3058:1480:e4ac:5765%6]) with mapi id 15.21.0025.022; Tue, 19 May 2026 05:53:13 +0000 Message-ID: Date: Tue, 19 May 2026 13:52:56 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [Patch v4 13/16] sched/cache: Fix cache aware scheduling enabling for multi LLCs system To: Peter Zijlstra , Tim Chen CC: Ingo Molnar , K Prateek Nayak , Vincent Guittot , Juri Lelli , Dietmar Eggemann , "Steven Rostedt" , Ben Segall , Mel Gorman , Valentin Schneider , "Madadi Vineeth Reddy" , Hillf Danton , "Shrikanth Hegde" , Jianyong Wu , "Yangyu Chen" , Tingyin Duan , Vern Hao , Vern Hao , Len Brown , Aubrey Li , Zhao Liu , Chen Yu , Adam Li , Aaron Lu , Tim Chen , Josh Don , Gavin Guo , Qais Yousef , Libo Chen , Luo Gengkun , References: <6328a8a7f40925cec2a712d81ee58128a4c4444a.1778703694.git.tim.c.chen@linux.intel.com> <20260518150632.GW3102624@noisy.programming.kicks-ass.net> Content-Language: en-US From: "Chen, Yu C" In-Reply-To: <20260518150632.GW3102624@noisy.programming.kicks-ass.net> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SI2PR02CA0029.apcprd02.prod.outlook.com (2603:1096:4:195::6) To DM4PR11MB6020.namprd11.prod.outlook.com (2603:10b6:8:61::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6020:EE_|SJ1PR11MB6298:EE_ X-MS-Office365-Filtering-Correlation-Id: ca122362-ff5e-4a9c-1fec-08deb56aea1a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|366016|4143699003|11063799003|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: qjLgGL1JVVwCRAwOrdQmbpKVs4npvKUNVrZsY7PBvWMAxTLQ226xKMIn2nhSnsA8BS3T62LbGFxYIFVbsU2UeNkQJxH3aIycSiCeVLhXe5x9h5xapmntJ1HmJzctKHSkvRHGPLVqU2+he2XHsNAyJDb4Drgj/r17tfZQzjypBNm6KGZwmeWp8tNtydgWR5e59/81dERdJyoffMwI55PkVXZYveRqk3b/XRZZ0mYYmmWo5QGtZy5HUpcxlNFi7x5F0H3bKdbynyeVHO/bsQgm3n7AiOejXuxmx6GjHHcMvBiZHyxnIuO/XVmbG3DL1CllRVDQQ/ow7ougIKKggyHhiz9fVUwLC4Em0BPBJwbOqGfwk88ZOAmiWR6yxLnvC/SrqZw7oJz7Rf6lCrvsf8pOS+Nu0JjbPx28ZQ3TysT88mThxKck8TfYOjwh+FVbp4UCDS80vl3YXI8cRKSuthrBTTspLczcfFMwx5MxyBomomfTZQD7c6XdCs4ckl3MHGzJZwqbCAvXjojl11GMZu15uHgU2oId4D27VfunNDwJN53EveowQFaFIDZLNkxTz8wygjL97dBXa6giwShOjAbsk2Qe6NM4/QzNxgeqjeAwSuv84yPpTqluN10IHiBayfGBgxgh216ku67QPiFMMOOJYJDsTRsBpjfKOj5zcWNIEvSB27fBjWYkAw3Tr/b5BsJY X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB6020.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(366016)(4143699003)(11063799003)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UTR1SkR1QmwvYmpseG5Dd3ZaUTNnQitQSWQxOGZxZlY2czFJQ3lqZ1NxbFhx?= =?utf-8?B?QWkxMVNzV2lPdFl5aDZIS3ZKaE5aQ0ljUUJ6cFZpaEJZcE43NVRHK0ZTc0Vp?= =?utf-8?B?ekw0ZkdpZEVsN25qVGQ5dVVTMFV3MktsVkxzbXA4OWJQSk1jZ1BMZjJuelRQ?= =?utf-8?B?SDBiWlIvVngzdnZQb2dnODY0ZkR2dEUxckxYc0lIZklDamtRdXNONVFpTDNM?= =?utf-8?B?ekdLWXd1NDl6WUE0emg2S3VQWHpUdVk3TzZMdWRkV2VQSGF6b0c0RStGWS9r?= =?utf-8?B?RkMvbWEydmFoRVlVRlNSbkdVeVEvWkpBa3dDVzNjNDU5NWhKR0ZOekVGSzgz?= =?utf-8?B?aVJJYXBqVkVPM0htRzVUamsyVUVEVTVReVhFaGxZdWRvYW0vd1BnMjY4S0kx?= =?utf-8?B?K21tWVEwTE9saldsRlJZVlZjbmc1VWVIelRFbVIxbTV2MTJvUmtyeHJndGtq?= =?utf-8?B?ZWxDODh4b1dIYWNqTWY0ajZEQ2ZTWmFHdWdranhlMDZPTUVvS3lqb0htNTF6?= =?utf-8?B?N3ZKSGc5Tmp5NGM3dFJ6dE5LTEh0UzBoZWV4eVBJTHhmUVBrcHlFRW9JUUN6?= =?utf-8?B?MDA2djlYR3hLMWlpOFQ1a0YxT09Pb21kNWlYQnVaNldVV0orOW4wcWhVVk5M?= =?utf-8?B?ejBsYnRDZ3VSQ2sxVzExWDBXWjFENmFjTkpFT3ZoNnd2S2doUDYxS1poSy9F?= =?utf-8?B?VGp6cGRFa2pyUm9odEIya3lGeXJiRGMyc0Z5YS9OOTdQUGo2bk9nVUNGdXVU?= =?utf-8?B?emZSRm5ITmtEUm5yZjk3VjJ3aituaVh1dlZHMHI0M2xMLzVIbU1lcEtTNmRl?= =?utf-8?B?cVphb1pDSXFKd3gzUUt5WTVhcVRqREZXUVArUUIwZFBrUVlrb0hDTVUzME9z?= =?utf-8?B?eGNrL1p3Q3ZNd2h1ejZDL1lNYnkwSG1URkVlVzhSVm1uUkhXRmVGZVM4K2RQ?= =?utf-8?B?VjZOV2M2MmphWkVQczI4bnJLSlBDQnlab3Q4Z3RVVUxac0ZtZThBWTE2M2F1?= =?utf-8?B?Z1Eza3NvODMwbWlZMlFhNXdrUlZnM253aVh6WWg0MlQ1M0V3U3lITWRDT3lR?= =?utf-8?B?bHlta0VhQnRxQUtUR05WZW04Z2RMRkdERjBBWEkvallBK25mN2xBT0hiT3lK?= =?utf-8?B?UnZpOWVRWmpvaUh5SUM4dnhiWjI0RkhkeHZyK0I3ZXRhajkyMDhLY1lyYndD?= =?utf-8?B?MGZjSnNwa0pvN25PYVNIOGxDZ1ZGUDhxaHZraGczQUJCQmFnVVRtRjN3aWU5?= =?utf-8?B?TXVvRlRoWVhoSzJNR09tQTB0UXd3VFVzc3NMZ3loM2I1OWdxcm1VLzBTZVh5?= =?utf-8?B?d3NjbjkralQ2MGp0aGZuZktaRkN5T3pHbUVrM1FFWHdvQWU5ZTIyc1Bud3p6?= =?utf-8?B?UGtkQWhQRCtsSGZiOC9qWkJqemJBOGFpQkpJN3UvU2FBRlRqWXY5V1BQcElY?= =?utf-8?B?WjlsM2wxcHB4VGE3LzQ5ZFVvL0lkcExKZWxDckpDd3ZxTDJaZVlkYmpGbG9Y?= =?utf-8?B?dFNOZU5OQTZMd2ltRDE5b2lWUVVHVkxDYUNEc2VkTTBqYWFuU3JEQkcxRzY5?= =?utf-8?B?Nm5IOHBMZEtwaWhrck9CK3VjMVVpUDRwb2dhTVJIb3ZsdnovRnVCc3p0aXFO?= =?utf-8?B?WUV0UWxpak84SGdLRGVOeWZyUitXWlIvNUNydytuekU2YlNkMjF5T3kwMFQw?= =?utf-8?B?TkwvU3FobUhQYVJPbysrWGpkeEV4clFlWGVqNlFTaFBNclNGbEpZMzl2dTZ6?= =?utf-8?B?R0VMblFHMmgyYUo2WUhNMVVyOWxtZUd6OTUvMTREbHZseVFKYzlxYVVidGtX?= =?utf-8?B?dFlRM2NwdXkvT1pTY0FhTlZTWDBTWWpCU0VYR1lyUzVxMC80dTFqemg3MDAr?= =?utf-8?B?Y3ZJUmtwU0UvTUd3dEIxcC9kdXZlYXIwN3pxODAyWmlEZndNamtqQjI4SE80?= =?utf-8?B?WjZzc21lWDRPeFBIbmNrSk9wNkpCTytaa0VoYlU5cEI3T3RNRXdqUzBnb3h3?= =?utf-8?B?L0E2QnhNUy8xVzFPUkRyRkVxR3ZLZytKYVZPbncvQVJnRUFFRXNoQmZwWjlP?= =?utf-8?B?NXhqS251YWZGSmFSTENvWXI2bkJmb2E3ZG95enI5Rjd0Y1dVeG1LdGpyNzdt?= =?utf-8?B?aTQxc1p5T3N4VFlZY3BvVGhmVWNTR05CSXg2SGFvWmVsY1ZPOGI3ZUQrRlJV?= =?utf-8?B?KzY5amF0aUUybDV4NnZ3RkNKUFRmOGxnOWtWYWMzQmlmb2owSDMzVnpUVjVl?= =?utf-8?B?b1NnMVNhWDJvYnptTEJEWmR4NUhvZGhmdjBHTW1pUTZxN1ptUnhsckswZjFh?= =?utf-8?B?L3JZaVJYbnArM3hKb2RvMmV2cG4wcjNJRVA4NUNTUXJ2Q1NoeWExQT09?= X-Exchange-RoutingPolicyChecked: hK8xQD7ayzlS4NRpamZI9zekJHdjUH+Mk2AkRDl41iUGae3WbKj5iuBDw/+wsOFhpSY5wY1cXsaITOg/GgusYFJRaVkFx06uzzFAVCUcPFsyIJMw+d2GtoDzqXh6rbvKBuLL2Q2M+BB5IiszoA5kscn/TsXxf8idrwbXj2iQ+ZgAn4YHKqHhShU1aPbqHjjPpUgvB486kvPDoCI0h3a6eWzcaRLzK8Beexdl3UbafXgPkcxryLOrcTH+pxSRgyjZKIXjvJCB092O1n4+ZxfftwC2SZuCTMBLZGv4yTNUS7jxpNqCh38evb+WqhTWwYANfOTjzDCvj6+cTelKexTFiQ== X-MS-Exchange-CrossTenant-Network-Message-Id: ca122362-ff5e-4a9c-1fec-08deb56aea1a X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6020.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2026 05:53:13.3575 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sAyjzl/52yBjN9/W2oXm5N/soAq0uoOcasq8H1rRf9Z3lfxP7AQRxOylN+Edr0cedI2AmV5RyZCkYnljEMiPvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6298 X-OriginatorOrg: intel.com On 5/18/2026 11:06 PM, Peter Zijlstra wrote: > On Wed, May 13, 2026 at 01:39:24PM -0700, Tim Chen wrote: >> From: Chen Yu >> >> If there are multiple LLCs in the system, cache aware scheduling >> should be enabled. However, there is a corner case where, if there >> is a single NUMA node and a single LLC per node, cache aware >> scheduling will be turned on in the current implementation - >> because at this moment, the parent domain has not yet been >> degenerated, and it is possible that the current domain has the >> same cpu span as its parent. There is no need to turn cache aware >> scheduling on in this scenario. >> >> Fix it by iterating the parent domains to find a domain that is >> a superset of the current sd_llc, so that later, after the duplicated >> parent domains have been degenerated, cache aware scheduling will >> take effect. >> >> For example, the expected behavior would be: >> 2 sockets, 1 LLC per socket: MC span=0-3, PKG span=0-7, has_multi_llcs=true >> 1 socket, 2 LLCs per socket: MC span=0-3, PKG span=0-7, has_multi_llcs=true >> 2 sockets, 2 LLCs per socket: MC span=0-3, PKG span=0-7, has_multi_llcs=true >> 1 socket, 1 LLC per socket: MC span=0-3, PKG span=0-3, has_multi_llcs=false >> >> This bug was reported by sashiko. >> >> Fixes: d59f4fd1d303 ("sched/cache: Enable cache aware scheduling for >> multi LLCs NUMA node") > > FWIW, this and the next patch have this Fixes: line mangled -- I fixed > it. But please figure out what did that so it doesn't happen again. Thanks for fixing it. We will pay attention to this in the next version. thanks, Chenyu