From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 091B9C48BE5 for ; Wed, 16 Jun 2021 11:58:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D05F56128B for ; Wed, 16 Jun 2021 11:58:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232690AbhFPMAx (ORCPT ); Wed, 16 Jun 2021 08:00:53 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:7335 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231808AbhFPMAw (ORCPT ); Wed, 16 Jun 2021 08:00:52 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4G4kBX5T4gz6yJV; Wed, 16 Jun 2021 19:54:44 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 19:58:43 +0800 Received: from [127.0.0.1] (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 19:58:43 +0800 Subject: Re: [PATCH 1/3] scripts: add spelling_sanitizer.sh script From: "Leizhen (ThunderTown)" To: Joe Perches , Andrew Morton , Nicolas Dichtel , Jason Baron , Stefani Seibold , Jacob Keller , Thomas Graf , Herbert Xu , Jens Axboe , Petr Mladek , Sergey Senozhatsky , "Andy Shevchenko" , Rasmus Villemoes , linux-kernel , Colin Ian King , Kees Cook References: <20210611071241.16728-1-thunder.leizhen@huawei.com> <20210611071241.16728-2-thunder.leizhen@huawei.com> <6cff5719-9548-a49e-6c47-8bc92c5bd6b8@huawei.com> Message-ID: Date: Wed, 16 Jun 2021 19:58:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <6cff5719-9548-a49e-6c47-8bc92c5bd6b8@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/6/15 15:01, Leizhen (ThunderTown) wrote: > > > On 2021/6/11 23:36, Joe Perches wrote: >> On Fri, 2021-06-11 at 15:12 +0800, Zhen Lei wrote: >>> The file scripts/spelling.txt recorded a large number of >>> "mistake||correction" pairs. These entries are currently maintained in >>> order, but the results are not strict. In addition, when someone wants to >>> add some new pairs, he either sort them manually or write a script, which >>> is clearly a waste of labor. >> >> Try using lintian's make sort >> >> https://salsa.debian.org/lintian/lintian I installed lintian and found no option to support sort. Can anyone give me more specific instructions on how to use it? Although I don't understand the perl language, after reading commit 66b47b4a9dad ("checkpatch: look for common misspellings"), it seems to match from top to bottom. So, as Andy Shevchenko says, they should be sorted by frequency of the word usage. I really don't know the details of the implementation of scripts/checkpatch.pl --types=typo_spelling. Are only misspelled words involved in spelling.txt matching? Otherwise, if correctly spelled words are also traversed, sorting by frequency makes no sense. Because the correct number of words is far more than the wrong number of words. If that's the case, then my modified script could come in handy. And if only misspelled words involved in spelling.txt matching, do we really need spelling.txt? Just output the misspelled words is enough. I don't think anyone needs to follow the tips to complete the fix. >> >> > > Okay, I'll try it > >> >> . >>