From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753034AbdJTQP5 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 20 Oct 2017 12:15:57 -0400
Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:44876 "EHLO
        foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752976AbdJTQPy (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 20 Oct 2017 12:15:54 -0400
Subject: Re: [PATCH] ARM: dts: exynos: add cpu perf counters to Exynos54xx
 boards
To: Marian Mihailescu <mihailescu2m@gmail.com>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Russell King <linux@armlinux.org.uk>, Kukjin Kim <kgene@kernel.org>,
        Krzysztof Kozlowski <krzk@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
References: <CAM3PiRxi8sxf6T990K8rd7UsOLd2D5TaLciF=c_wF=9gmpLKYg@mail.gmail.com>
From: Robin Murphy <robin.murphy@arm.com>
Message-ID: <e2b87fe2-bc04-242d-8f4f-9cd21743e3aa@arm.com>
Date: Fri, 20 Oct 2017 17:15:51 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CAM3PiRxi8sxf6T990K8rd7UsOLd2D5TaLciF=c_wF=9gmpLKYg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20/10/17 13:09, Marian Mihailescu wrote:
> Hi,
> 
> This patch enables support for ARM Performance Monitoring Units
> available in Cortex-A7
> and Cortex-A15 CPU cores for Exynos54xx SoCs (5410, 5420 and 5422/5800).
> 
> Exynos5410 currently has only Cortex-A7 nodes defined in the device tree,
> so the Cortex-A15 PMU is defined in the exynos5420 device tree file.

Huh? 5410 only has the *A15* cluster described (and for whatever reason
mainline cannot bring up the A7 cluster even if you do add it).

Also*, the interrupt affinity properties are bogus as presented - those
will need to be delegated to the SoC-variant-specific dtsi files in the
same manner as the "cpus" nodes, to cope with the different CPU numberings.

Robin.

*I'd like to have made this comment inline in the patch, but I can't :(

> Tested with perf on Odroid XU4 (Exynos5422):
> armv7_cortex_a7 PMU driver: 5 counters available
> armv7_cortex_a15 PMU driver: 7 counters available
> 
> Regards,
> Marian
> 
> --
> Either I've been missing something or nothing has been going on. (K. E. Gordon)
> 
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>