From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752934AbcHOJEN (ORCPT ); Mon, 15 Aug 2016 05:04:13 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:17674 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752885AbcHOJEL (ORCPT ); Mon, 15 Aug 2016 05:04:11 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Mon, 15 Aug 2016 02:00:34 -0700 Subject: Re: [PATCH v2] drm/tegra: dpaux: Modify error handling To: Amitoj Kaur Chawla , , , , , , , References: <20160815045748.GA12947@amitoj-Inspiron-3542> CC: From: Jon Hunter Message-ID: Date: Mon, 15 Aug 2016 10:04:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160815045748.GA12947@amitoj-Inspiron-3542> X-Originating-IP: [10.26.11.109] X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/08/16 05:57, Amitoj Kaur Chawla wrote: > devm_pinctrl_register returns an ERR_PTR in case of error and should > have an IS_ERR check instead of a null check. > > The Coccinelle semantic patch used to make this change is as follows: > @@ > expression e; > @@ > > e = devm_pinctrl_register(...); > if( > - !e > + IS_ERR(e) > ) > { > <+... > return > - ... > + PTR_ERR(e) > ; > ...+> > } > > Signed-off-by: Amitoj Kaur Chawla > --- > Changes in v2: > -Correct typo > > drivers/gpu/drm/tegra/dpaux.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c > index 059f409..2fde44c 100644 > --- a/drivers/gpu/drm/tegra/dpaux.c > +++ b/drivers/gpu/drm/tegra/dpaux.c > @@ -539,9 +539,9 @@ static int tegra_dpaux_probe(struct platform_device *pdev) > dpaux->desc.owner = THIS_MODULE; > > dpaux->pinctrl = devm_pinctrl_register(&pdev->dev, &dpaux->desc, dpaux); > - if (!dpaux->pinctrl) { > + if (IS_ERR(dpaux->pinctrl)) { > dev_err(&pdev->dev, "failed to register pincontrol\n"); > - return -ENODEV; > + return PTR_ERR(dpaux->pinctrl); > } > #endif > /* enable and clear all interrupts */ > Acked-by: Jon Hunter Cheers! Jon -- nvpublic