From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: * X-Spam-Status: No, score=1.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,UNWANTED_LANGUAGE_BODY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89656C4321D for ; Thu, 23 Aug 2018 10:30:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3CFF7208FA for ; Thu, 23 Aug 2018 10:30:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CFF7208FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728521AbeHWN7y (ORCPT ); Thu, 23 Aug 2018 09:59:54 -0400 Received: from mga07.intel.com ([134.134.136.100]:64286 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726353AbeHWN7x (ORCPT ); Thu, 23 Aug 2018 09:59:53 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Aug 2018 03:30:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,278,1531810800"; d="scan'208";a="65406997" Received: from linux.intel.com ([10.54.29.200]) by fmsmga008.fm.intel.com with ESMTP; 23 Aug 2018 03:30:50 -0700 Received: from [10.125.252.155] (abudanko-mobl.ccr.corp.intel.com [10.125.252.155]) by linux.intel.com (Postfix) with ESMTP id 55C435802C8; Thu, 23 Aug 2018 03:30:48 -0700 (PDT) Subject: [PATCH v1 1/2]: perf util: map data buffer for preserving collected data From: Alexey Budankov To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo Cc: Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andi Kleen , linux-kernel , linux-perf-users@vger.kernel.org References: <1c3fd88f-c408-2863-15b3-221829f3d383@linux.intel.com> Organization: Intel Corp. Message-ID: Date: Thu, 23 Aug 2018 13:30:47 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1c3fd88f-c408-2863-15b3-221829f3d383@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The data buffer and accompanying AIO control block are allocated at perf_mmap object and the mapped data buffer size is equal to the kernel one. The buffer is then used to preserve profiling data ready for dumping and queue it for asynchronous writing into perf trace thru implemented record__aio_write() function. mmap_aio control structure of the size equal to the number of per-cpu kernel buffers is used to keep pointers to enqueued AIO control blocks for monitoring of completed AIO operations. Signed-off-by: Alexey Budankov --- tools/perf/builtin-record.c | 18 ++++++++++++++++++ tools/perf/util/evlist.c | 9 +++++++++ tools/perf/util/evlist.h | 2 ++ tools/perf/util/mmap.c | 12 ++++++++++++ tools/perf/util/mmap.h | 3 +++ 5 files changed, 44 insertions(+) diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index 22ebeb92ac51..a35675e9f3aa 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c @@ -53,6 +53,7 @@ #include #include #include +#include struct switch_output { bool enabled; @@ -121,6 +122,23 @@ static int record__write(struct record *rec, void *bf, size_t size) return 0; } +static int record__aio_write(int trace_fd, struct aiocb *cblock, + void *buf, size_t size, off_t off) +{ + cblock->aio_fildes = trace_fd; + cblock->aio_buf = buf; + cblock->aio_nbytes = size; + cblock->aio_offset = off; + cblock->aio_sigevent.sigev_notify = SIGEV_NONE; + + if (aio_write(cblock) == -1) { + pr_err("failed to write perf data, error: %m\n"); + return -1; + } + + return 0; +} + static int process_synthesized_event(struct perf_tool *tool, union perf_event *event, struct perf_sample *sample __maybe_unused, diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c index e7a4b31a84fb..6bce307d2cfb 100644 --- a/tools/perf/util/evlist.c +++ b/tools/perf/util/evlist.c @@ -718,6 +718,8 @@ static void perf_evlist__munmap_nofree(struct perf_evlist *evlist) void perf_evlist__munmap(struct perf_evlist *evlist) { perf_evlist__munmap_nofree(evlist); + if (&evlist->mmap_aio) + zfree(&evlist->mmap_aio); zfree(&evlist->mmap); zfree(&evlist->overwrite_mmap); } @@ -749,6 +751,13 @@ static struct perf_mmap *perf_evlist__alloc_mmap(struct perf_evlist *evlist, */ refcount_set(&map[i].refcnt, 0); } + + evlist->mmap_aio = zalloc(evlist->nr_mmaps * sizeof(struct aiocb *)); + if (!evlist->mmap_aio) { + zfree(&map); + return NULL; + } + return map; } diff --git a/tools/perf/util/evlist.h b/tools/perf/util/evlist.h index dc66436add98..f98b949561fd 100644 --- a/tools/perf/util/evlist.h +++ b/tools/perf/util/evlist.h @@ -15,6 +15,7 @@ #include "util.h" #include #include +#include struct pollfd; struct thread_map; @@ -43,6 +44,7 @@ struct perf_evlist { } workload; struct fdarray pollfd; struct perf_mmap *mmap; + struct aiocb **mmap_aio; struct perf_mmap *overwrite_mmap; struct thread_map *threads; struct cpu_map *cpus; diff --git a/tools/perf/util/mmap.c b/tools/perf/util/mmap.c index fc832676a798..e71d46cb01cc 100644 --- a/tools/perf/util/mmap.c +++ b/tools/perf/util/mmap.c @@ -155,6 +155,10 @@ void __weak auxtrace_mmap_params__set_idx(struct auxtrace_mmap_params *mp __mayb void perf_mmap__munmap(struct perf_mmap *map) { + if (map->data != NULL) { + munmap(map->data, perf_mmap__mmap_len(map)); + map->data = NULL; + } if (map->base != NULL) { munmap(map->base, perf_mmap__mmap_len(map)); map->base = NULL; @@ -190,6 +194,14 @@ int perf_mmap__mmap(struct perf_mmap *map, struct mmap_params *mp, int fd) map->base = NULL; return -1; } + map->data = mmap(NULL, perf_mmap__mmap_len(map), PROT_READ | PROT_WRITE, + MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); + if (map->data == MAP_FAILED) { + pr_debug2("failed to mmap perf event data buffer, error %d\n", + errno); + map->data = NULL; + return -1; + } map->fd = fd; if (auxtrace_mmap__mmap(&map->auxtrace_mmap, diff --git a/tools/perf/util/mmap.h b/tools/perf/util/mmap.h index d82294db1295..1974e621e36b 100644 --- a/tools/perf/util/mmap.h +++ b/tools/perf/util/mmap.h @@ -6,6 +6,7 @@ #include #include #include +#include #include "auxtrace.h" #include "event.h" @@ -25,6 +26,8 @@ struct perf_mmap { bool overwrite; struct auxtrace_mmap auxtrace_mmap; char event_copy[PERF_SAMPLE_MAX_SIZE] __aligned(8); + void *data; + struct aiocb cblock; }; /*