From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932186AbdBPO4Q (ORCPT ); Thu, 16 Feb 2017 09:56:16 -0500 Received: from mail-it0-f50.google.com ([209.85.214.50]:38787 "EHLO mail-it0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754410AbdBPO4O (ORCPT ); Thu, 16 Feb 2017 09:56:14 -0500 Subject: Re: [BUG] Potential deadlock in the block layer To: Thomas Gleixner References: <4d3f25fc-7480-769c-2f4f-e5271a47f7c3@kernel.dk> Cc: LKML , linux-block@vger.kernel.org, Gabriel C , Steven Rostedt , Peter Zijlstra , Linus Torvalds From: Jens Axboe Message-ID: Date: Thu, 16 Feb 2017 07:56:12 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/16/2017 07:35 AM, Thomas Gleixner wrote: > On Mon, 13 Feb 2017, Jens Axboe wrote: > >> On 02/13/2017 07:14 AM, Thomas Gleixner wrote: >>> Gabriel reported the lockdep splat below while investigating something >>> different. >>> >>> Explanation for the splat is in the function comment above >>> del_timer_sync(). >>> >>> I can reproduce it as well and it's clearly broken. >> >> Agree, the disable logic is broken. The below isn't super pretty, but it >> should do the trick for 4.10. > > Cures the splat. Is that a new 4.10 'feature'? That wbt stuff has been > merged a few releases ago. OK good, I'll get this submitted for 4.10. wbt is a new feature in this release. -- Jens Axboe