From: Bart Van Assche <bvanassche@acm.org>
To: Yang Li <yang.lee@linux.alibaba.com>,
jejb@linux.ibm.com, martin.petersen@oracle.com
Cc: alim.akhtar@samsung.com, avri.altman@wdc.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] scsi: ufs: core: Simplify bool conversion
Date: Thu, 7 Sep 2023 15:47:44 -0700 [thread overview]
Message-ID: <e2c7f484-0fd5-43e0-b27a-41f1b23c6932@acm.org> (raw)
In-Reply-To: <20230907005413.100804-1-yang.lee@linux.alibaba.com>
On 9/6/23 17:54, Yang Li wrote:
> ./drivers/ufs/core/ufshcd.c:2307:26-31: WARNING: conversion to bool not needed here
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/ufs/core/ufshcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index c2df07545f96..04bbe38ffd87 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -2304,7 +2304,7 @@ static inline bool ufshcd_ready_for_uic_cmd(struct ufs_hba *hba)
> int ret = read_poll_timeout(ufshcd_readl, val, val & UIC_COMMAND_READY,
> 500, UIC_CMD_TIMEOUT * 1000, false, hba,
> REG_CONTROLLER_STATUS);
> - return ret == 0 ? true : false;
> + return ret == 0;
> }
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
prev parent reply other threads:[~2023-09-07 22:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 0:54 Yang Li
2023-09-07 22:47 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2c7f484-0fd5-43e0-b27a-41f1b23c6932@acm.org \
--to=bvanassche@acm.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®