From: Nihal Kumar Gupta <nihal.gupta@oss.qualcomm.com>
To: Loic Poulain <loic.poulain@oss.qualcomm.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-hardening@vger.kernel.org,
devicetree@vger.kernel.org,
Hans de Goede <johannes.goede@oss.qualcomm.com>
Subject: Re: [PATCH v5 4/5] media: qcom: camss: Add CAMSS Offline Processing Engine driver
Date: Fri, 21 Aug 2026 12:04:40 +0530 [thread overview]
Message-ID: <e2cab6c6-a5fc-43b2-96e7-f46f9a7bd20d@oss.qualcomm.com> (raw)
In-Reply-To: <20260724-camss-isp-ope-v5-4-e70ad4fa39ce@oss.qualcomm.com>
On 24-07-2026 18:12, Loic Poulain wrote:
> + .start_streaming = ope_start_streaming,
> + .stop_streaming = ope_stop_streaming,
> + .wait_prepare = vb2_ops_wait_prepare,
> + .wait_finish = vb2_ops_wait_finish,
> +};
Hi Loic,
While reviewing the series, I noticed that wait_prepare/wait_finish
callbacks and their helpers were removed in:
d0730006dac2 ("media: vb2: remove vb2_ops_wait_prepare/finish helpers")
b70886ff5833 ("media: vb2: drop wait_prepare/finish callbacks")
These stale lines are causing a compilation failure:
- .wait_prepare = vb2_ops_wait_prepare,
- .wait_finish = vb2_ops_wait_finish,
Please take care of this while posting next ver.
---
Regards,
Nihal Kumar Gupta
next prev parent reply other threads:[~2026-08-21 6:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 12:42 [PATCH v5 0/5] media: qcom: camss: CAMSS Offline Processing Engine support Loic Poulain
2026-07-24 12:42 ` [PATCH v5 1/5] media: qcom: camss: Add V4L2 meta format for CAMSS ISP parameters Loic Poulain
2026-07-29 18:28 ` Gjorgji Rosikopulos (Consultant)
2026-07-30 11:44 ` Loic Poulain
2026-07-30 11:57 ` Bryan O'Donoghue
2026-07-30 12:34 ` Loic Poulain
2026-07-30 13:15 ` Gjorgji Rosikopulos (Consultant)
2026-07-24 12:42 ` [PATCH v5 2/5] dt-bindings: media: qcom: Add CAMSS Offline Processing Engine (OPE) Loic Poulain
2026-07-24 12:42 ` [PATCH v5 3/5] media: uapi: Add CAMSS OPE ISP configuration definition Loic Poulain
2026-07-29 13:27 ` johannes.goede
2026-07-29 18:31 ` Gjorgji Rosikopulos (Consultant)
2026-07-24 12:42 ` [PATCH v5 4/5] media: qcom: camss: Add CAMSS Offline Processing Engine driver Loic Poulain
2026-07-29 19:53 ` Gjorgji Rosikopulos (Consultant)
2026-08-21 6:34 ` Nihal Kumar Gupta [this message]
2026-07-24 12:42 ` [PATCH v5 5/5] arm64: dts: qcom: agatti: Add OPE node Loic Poulain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2cab6c6-a5fc-43b2-96e7-f46f9a7bd20d@oss.qualcomm.com \
--to=nihal.gupta@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gustavoars@kernel.org \
--cc=johannes.goede@oss.qualcomm.com \
--cc=kees@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®