From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 664102F3609 for ; Tue, 23 Dec 2025 05:36:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766468171; cv=none; b=jmJZM4VipfCc++4MUPBubKXaM4iKFtXHu58twwQkERb6XXRJHv3on4iK7oO8q7OJjXSCJ8bxNRzZekaXr9k4CCapygZlCH4sL2fqv3JZ1d9fA12dLdQhYIN6Ost9HuDub1IIBPU7pMfd5N7Z1du5fvofVgJfSSd3/NkqIAydIuw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766468171; c=relaxed/simple; bh=lW+UmIWRSVZ7zpivjjDN2RAk8y2uECMzZoBmWD3afKc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PToSq94onzkO18ZbuP5nCpTuKTaFjNkz0M7vfpa3Tz/1B0PVzVL13B6ca1S6SLh8IhYlGyDBIAqC5sq1P90RwRKjcyH97x5fN2cF9lz4ECjtU6mF1RGYRrPgngQUEH5yH4sJyYEqJ9G6RcY/w3wMeIPsIgUQ68reVop62hfy/O4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ung45Q84; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ung45Q84" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-34b75fba315so5262573a91.3 for ; Mon, 22 Dec 2025 21:36:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766468169; x=1767072969; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lW+UmIWRSVZ7zpivjjDN2RAk8y2uECMzZoBmWD3afKc=; b=Ung45Q84NKJpgXUpj6V9c/ed39FtjE6rEaUqQWkJJFS7fjSzXwil3mKYAY6k0P8R9Z ddtgTfoZNL09/7vdeIMFC9JYApmDKSVclj15wMPBUSYzvYzI2V1K6y3+4OrBFi1YYL2i Ygo61aSI7PTM3LrIlLqoQR3YIwD47T+aDfeoHcsd1atowsBYoyrx6dnbVIVfEB/MalJF 2NuWCA0r1bN8toEVguQoOSvqibnOTY8FjNDSkJ/sdULSEVFDzpcjyqioyPm4wEmXqrj1 ilE8f7MJVCDOQnn9/KIYfxwD2zQKhMHjA+B/jiX/srEFwN0w8KKug3A4yAIpvlDCg4c+ GzLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766468169; x=1767072969; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lW+UmIWRSVZ7zpivjjDN2RAk8y2uECMzZoBmWD3afKc=; b=S0fqC9y55oAjJCy13IYjK51KlIQ7I2t0mbMot6a6xb6Sz8Dda6xbPlUc2HkH1m/ixC WEEhYv0z/7MTFy5gyd9ReQQJDWWvi9GQuVxxLigPk4hJM6zaxCEYkNr/Olaeq2fd3EKu Cmae/19FFQog+uIuLk9/KNBFVHb62ix5lFtBxpG8lIL2T+S79i+KuqwmlbhqMlmZ5hIc 2ZjyLwXB+4v0XCrvQp7QGm1JT9c2y/i3CTRJVNSgsd59RioIcoNcRB4q/4jVm2vSGSwJ 43HaTWCV7x52oev2GMOEGCZDAAKIdmmkQMtB48Htq3VzZfdiS8iUGbVWvHQD34kPIgGx E1xQ== X-Forwarded-Encrypted: i=1; AJvYcCUbovs8TahpXyhFSzSiNYuP0Z4o/CTn2xJbk8BeElyJyFQHQmuP95qypgU5gSXOp8EIF3aveWp1VB7ZokY=@vger.kernel.org X-Gm-Message-State: AOJu0YwXtokgVqAkyUX97w/VcLpmMwxu/Qku3NQpG4ryWlyZYIjdMYGR zjjpulfa7/UFa1QcKGn0MiN9mwe06ZVAx/yEDYJEeZJmynpIbZHqsMyt X-Gm-Gg: AY/fxX68ihmZ5C31piMdstdMpClMyYMD0vzIKdce0ICQc0sXvHucF5GcP0oq2TPqtsv Bwg1mtQ0F8PBuLVivRbpF5IFzJ6MAkZu1kCyz7s0xYdDIziOAWeMrLJAryUh4FSgvrJHjuH/m00 7xNyRjB9rinPPo8yoJvlM99t1/jaKIX65op7okQndZfO3aZ9sIbe04q3PsmCZxb2QVRTT+GZ4Ge 9x/aQzuH78fFEDmvbaNfROLjpPRZusj8O1RUqNGJ11M58l68D50icn8WMpi0kinPzZURa1cma/U ofQK/YdT7T0PliisvB/evazbMgiznUPnx6YVXD5Tf3rir7e+DpeaoGovHkMpsbEhs3JeIoUhXNh fg08TtHSJdr8PrFHeOq1jEsGRkY89tpA5wsft8OG6r31iBRnjnFDRxGaxXMosyL88tzr4uxHGrn 9at8VbdhuA7yFLcPH3W+qkng2xODybTC40h94unA4/Q9EmpqqpSghz/1fH/9M5h7FQ X-Google-Smtp-Source: AGHT+IH379xsDZ0d7vjKdC6ERRiENfgRNsDKq+A1tK8cXdwsmB2ywvOol5d1N83fquxU7SkCjjJrLg== X-Received: by 2002:a05:7022:3b8a:b0:11b:79f1:850 with SMTP id a92af1059eb24-121722b7f23mr14589383c88.14.1766468169469; Mon, 22 Dec 2025 21:36:09 -0800 (PST) Received: from ?IPV6:2600:8802:b00:9ce0:637f:5cdc:9df0:d9ab? ([2600:8802:b00:9ce0:637f:5cdc:9df0:d9ab]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1217254ce49sm52556580c88.15.2025.12.22.21.36.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Dec 2025 21:36:09 -0800 (PST) Message-ID: Date: Mon, 22 Dec 2025 21:36:08 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/11] fs: return I_DIRTY_* and allow error returns from inode_update_timestamps To: Christoph Hellwig , Christian Brauner Cc: Al Viro , David Sterba , Jan Kara , Mike Marshall , Martin Brandenburg , Carlos Maiolino , Stefan Roesch , Jeff Layton , linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, gfs2@lists.linux.dev, io-uring@vger.kernel.org, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, linux-mtd@lists.infradead.org, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org References: <20251223003756.409543-1-hch@lst.de> <20251223003756.409543-6-hch@lst.de> Content-Language: en-US From: Chaitanya Kulkarni In-Reply-To: <20251223003756.409543-6-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/22/25 16:37, Christoph Hellwig wrote: > Change the inode_update_timestamps calling convention, so that instead > of returning the updated flags that are only needed to calculate the > I_DIRTY_* flags, return the I_DIRTY_* flags diretly in an argument, and > reserve the return value to return an error code, which will be needed to > support non-blocking timestamp updates. > > Signed-off-by: Christoph Hellwig Looks good. Reviewed-by: Chaitanya Kulkarni -ck