From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753584Ab0AHO51 (ORCPT ); Fri, 8 Jan 2010 09:57:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753527Ab0AHO50 (ORCPT ); Fri, 8 Jan 2010 09:57:26 -0500 Received: from ey-out-2122.google.com ([74.125.78.24]:34417 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753443Ab0AHO5Z convert rfc822-to-8bit (ORCPT ); Fri, 8 Jan 2010 09:57:25 -0500 MIME-Version: 1.0 In-Reply-To: <1262915005.10429.92.camel@Joe-Laptop.home> References: <201001071627.46569.hartleys@visionengravers.com> <20100108000224.GH2436@verge.net.au> <1262915005.10429.92.camel@Joe-Laptop.home> Date: Fri, 8 Jan 2010 15:57:23 +0100 Message-ID: Subject: Re: [PATCH] drivers/net/skfp/skfddi.c: use %pMF to show MAC address From: =?ISO-8859-2?Q?Micha=B3_Miros=B3aw?= To: Joe Perches Cc: Simon Horman , H Hartley Sweeten , Linux Kernel , netdev@vger.kernel.org, davem@davemloft.net Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2010/1/8 Joe Perches : > On Fri, 2010-01-08 at 11:02 +1100, Simon Horman wrote: >> On Thu, Jan 07, 2010 at 04:27:46PM -0700, H Hartley Sweeten wrote: >> > Use the %pMF kernel extension to display the MAC address. >> > The address will still be displayed in the FDDI Canonical format. >> I'm not sure that it matters, but prior to this patch >> the address was displayed with octets delimited by spaces, >> and afterwards its delimited by hyphens. So perhaps the comment >> should read: >> >> The address will now be displayed in the FDDI Canonical format. > And it probably wasn't bit reversed. >> > diff --git a/drivers/net/skfp/skfddi.c b/drivers/net/skfp/skfddi.c >> > index db216a7..1f9698c 100644 >> > --- a/drivers/net/skfp/skfddi.c >> > +++ b/drivers/net/skfp/skfddi.c >> > @@ -435,13 +435,7 @@ static  int skfp_driver_init(struct net_device *dev) >> >             goto fail; >> >     } >> >     read_address(smc, NULL); >> > -   pr_debug(KERN_INFO "HW-Addr: %02x %02x %02x %02x %02x %02x\n", >> > -          smc->hw.fddi_canon_addr.a[0], >> > -          smc->hw.fddi_canon_addr.a[1], >> > -          smc->hw.fddi_canon_addr.a[2], >> > -          smc->hw.fddi_canon_addr.a[3], >> > -          smc->hw.fddi_canon_addr.a[4], >> > -          smc->hw.fddi_canon_addr.a[5]); >> > +   pr_debug(KERN_INFO "HW-Addr: %pMF\n", smc->hw.fddi_canon_addr.a); > Is fddi_canon_addr already bit reversed? > It's memcpy'd to dev->dev_addr later, so probably not. > >> >     smt_reset_defaults(smc, 0); >> > @@ -890,15 +884,8 @@ static void skfp_ctl_set_multicast_list_wo_lock(struct net_device *dev) >> >                                                       (struct fddi_addr *)dmi->dmi_addr, >> >                                                       1); >> > >> > -                                   pr_debug(KERN_INFO "ENABLE MC ADDRESS:"); >> > -                                   pr_debug(" %02x %02x %02x ", >> > -                                          dmi->dmi_addr[0], >> > -                                          dmi->dmi_addr[1], >> > -                                          dmi->dmi_addr[2]); >> > -                                   pr_debug("%02x %02x %02x\n", >> > -                                          dmi->dmi_addr[3], >> > -                                          dmi->dmi_addr[4], >> > -                                          dmi->dmi_addr[5]); >> > +                                   pr_debug(KERN_INFO "ENABLE MC ADDRESS: %pMF\n", >> > +                                           dmi->dmi_addr); > I think you want %pM here, not the bit-reversed %pMF form. You could add %pMf for those, that are bit-reversed already? That should take at most two extra insns for x86. ;) Best Regards, Michał Mirosław