From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x226FlrDYlT6ZYuo0UxQfF0z98ZyDh+GPCkME2bgifii30xIwWcy092cMJnQz+mU2s6ov6YcH ARC-Seal: i=1; a=rsa-sha256; t=1519327432; cv=none; d=google.com; s=arc-20160816; b=kNqa7uF2A9Y5i4EEzwFvqPmZk+F+CdwQ2bHBBjxpTMSmMHshk5nrv+y0jq3tyabxsc EJPXzsD7Wu3HL1iHPv6h0Awzz3Df2+ryaFEqXFITKQhTYcx8kO1PD7cdqiwnbLacvyg7 1JEU1/E1/N/aQrfei0eeL2LNlbAxZgAodvH79yQHi3QOsBqZpp7kPZYhaoGWUVVoBoSU 4wdLskJsu02/8Wsg6E/tvvLNowftf9yc3vL+SMf/+renCtZHeQcceyvcNVLfMCA1kEOr 22DLmHvR+vpKu/vPbuHSKFwhIhxZJMI2vP+0PJ8aXIPglXQcF1lKW6jkUangMvB3skmz AiDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:to:subject:from :dkim-signature:arc-authentication-results; bh=BeU+FiTCN6S/hpR0wxTsJfTPHdY1bsru0syQI+3IH40=; b=I7w7vXGXPPkiVIumVuLgS7SYbrHYLTZqiVNuo+WvHCfWR9K85SoAbqx0TVr+CMbb2x 5O8PpLp62BnmuFMa4ckNFKjweuK4rrzYQvfMvMTYR6xNCTDCMc40V9AWHG1zg0BfCf0i Jnyr3bEI7HCDaVLUb4Bo7Sv4V1zRDR3A86Wh7YSKmM1Y2KQKVv9PuYOBUQdecy16MRlR 9Q03fQbhTsnNhePZZ7a9tXIhFvnSp6Al1tuaTkB3rp4MX28wSK/BlfKWlWoLyI0M0DXg BqbzK4iCfpROhGQZkR9bSJVcG2fnvXjW3K7ptS19j8SzbTj1aDMf+8a2jLR9wGJjPH9S jGGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=merlin.20170209 header.b=keT2yVoL; spf=pass (google.com: best guess record for domain of rdunlap@infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom=rdunlap@infradead.org Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=merlin.20170209 header.b=keT2yVoL; spf=pass (google.com: best guess record for domain of rdunlap@infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom=rdunlap@infradead.org From: Randy Dunlap Subject: Re: [PATCH v9 2/7] PCI/AER: factor out error reporting from AER To: Oza Pawandeep , Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Keith Busch , Wei Zhang , Sinan Kaya , Timur Tabi References: <1519285571-5634-1-git-send-email-poza@codeaurora.org> <1519285571-5634-3-git-send-email-poza@codeaurora.org> Message-ID: Date: Thu, 22 Feb 2018 11:23:41 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1519285571-5634-3-git-send-email-poza@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1593086410511514158?= X-GMAIL-MSGID: =?utf-8?q?1593130281957885814?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 02/21/2018 11:46 PM, Oza Pawandeep wrote: Hi, Just minor stuff: > diff --git a/drivers/pci/pcie/pcie-err.c b/drivers/pci/pcie/pcie-err.c > new file mode 100644 > index 0000000..a532fe0 > --- /dev/null > +++ b/drivers/pci/pcie/pcie-err.c > @@ -0,0 +1,334 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * This file implements the error recovery as a core part of PCIe error reporting. > + * When a PCIe error is delivered, an error message will be collected and printed > + * to console, then, an error recovery procedure will be executed by following > + * the PCI error recovery rules. > + * > + * Copyright (C) 2006 Intel Corp. > + * Tom Long Nguyen (tom.l.nguyen@intel.com) > + * Zhang Yanmin (yanmin.zhang@intel.com) > + * > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include "portdrv.h" > +static int report_error_detected(struct pci_dev *dev, void *data) > +{ > + pci_ers_result_t vote; > + const struct pci_error_handlers *err_handler; > + struct aer_broadcast_data *result_data; > + > + result_data = (struct aer_broadcast_data *) data; > + > + device_lock(&dev->dev); > + dev->error_state = result_data->state; > + > + if (!dev->driver || > + !dev->driver->err_handler || > + !dev->driver->err_handler->error_detected) { > + if (result_data->state == pci_channel_io_frozen && > + dev->hdr_type != PCI_HEADER_TYPE_BRIDGE) { > + /* > + * In case of fatal recovery, if one of down- > + * stream device has no driver. We might be > + * unable to recover because a later insmod > + * of a driver for this device is unaware of > + * its hw state. > + */ > + dev_printk(KERN_DEBUG, &dev->dev, "device has %s\n", > + dev->driver ? > + "no error-aware driver" : "no driver"); or: dev_printk(KERN_DEBUG, &dev->dev, "device has no%s driver\n", dev->driver ? " error-aware" : ""); > + } > + > + /* > + * If there's any device in the subtree that does not > + * have an error_detected callback, returning > + * PCI_ERS_RESULT_NO_AER_DRIVER prevents calling of > + * the subsequent mmio_enabled/slot_reset/resume > + * callbacks of "any" device in the subtree. All the > + * devices in the subtree are left in the error state > + * without recovery. > + */ > + > + if (dev->hdr_type != PCI_HEADER_TYPE_BRIDGE) > + vote = PCI_ERS_RESULT_NO_AER_DRIVER; > + else > + vote = PCI_ERS_RESULT_NONE; > + } else { > + err_handler = dev->driver->err_handler; > + vote = err_handler->error_detected(dev, result_data->state); > + } > + > + result_data->result = merge_result(result_data->result, vote); > + device_unlock(&dev->dev); > + return 0; > +} > +/** > + * broadcast_error_message - handle message broadcast to downstream drivers > + * @dev: pointer to from where in a hierarchy message is broadcasted down I would drop ^^ "from" ... is broadcast downstream > + * @state: error state > + * @error_mesg: message to print > + * @cb: callback to be broadcasted to be broadcast > + * > + * Invoked during error recovery process. Once being invoked, the content > + * of error severity will be broadcasted to all downstream drivers in a will be broadcast > + * hierarchy in question. > + */ > +static pci_ers_result_t broadcast_error_message(struct pci_dev *dev, > + enum pci_channel_state state, > + char *error_mesg, > + int (*cb)(struct pci_dev *, void *)) > +{ > + struct aer_broadcast_data result_data; -- ~Randy