From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Dionna Amalie Glaze <dionnaglaze@google.com>
Cc: Jarkko Sakkinen <jarkko@kernel.org>,
Stefano Garzarella <sgarzare@redhat.com>,
linux-kernel@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>,
Dave Hansen <dave.hansen@linux.intel.com>,
Borislav Petkov <bp@alien8.de>,
linux-integrity@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>,
Ingo Molnar <mingo@redhat.com>,
linux-coco@lists.linux.dev, Dov Murik <dovmurik@linux.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Joerg Roedel <jroedel@suse.de>,
x86@kernel.org, Tom Lendacky <thomas.lendacky@amd.com>,
Claudio Carvalho <cclaudio@linux.ibm.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v5 3/4] tpm: add SNP SVSM vTPM driver
Date: Mon, 31 Mar 2025 18:59:36 -0400 [thread overview]
Message-ID: <e2db0cef00e9ad6061af8256c71d0198b15a5ddc.camel@HansenPartnership.com> (raw)
In-Reply-To: <CAAH4kHYwDgnYsMhJ8zZWn1uU4tqqnSXOLKEJNMb-3OCNrM7Z9A@mail.gmail.com>
On Mon, 2025-03-31 at 15:23 -0700, Dionna Amalie Glaze wrote:
> On Mon, Mar 31, 2025 at 2:26 PM James Bottomley
> <James.Bottomley@hansenpartnership.com> wrote:
> >
> > On Mon, 2025-03-31 at 13:56 -0700, Dionna Amalie Glaze wrote:
> > [...]
> > > I might be unclear on how I should be testing this, but I do see
> > > /dev/tpm0 and /dev/tpmrm0 when I build with CONFIG_TCG_SVSM=y,
> > > but I don't see the event log in securityfs. What am I missing?
> >
> > The vtpm driver for EDK2/OVMF I suspect ... without that the UEFI
> > won't lay down and event log for the kernel to pick up.
>
> This test is with Oliver's PR
> https://github.com/tianocore/edk2/pull/6527
Well, since the event log is searched for in tpm_chip_register(), I
really don't think it can be the kernel driver. Best guess is there's
something wrong with that patch set (or the vTPM didn't activate in
OVMF for some reason).
Regards,
James
next prev parent reply other threads:[~2025-03-31 22:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 10:38 [PATCH v5 0/4] Enlightened vTPM support for SVSM on SEV-SNP Stefano Garzarella
2025-03-31 10:38 ` [PATCH v5 1/4] x86/sev: add SVSM vTPM probe/send_command functions Stefano Garzarella
2025-04-02 4:13 ` Dionna Amalie Glaze
2025-04-02 4:50 ` Dionna Amalie Glaze
2025-03-31 10:38 ` [PATCH v5 2/4] svsm: add header with SVSM_VTPM_CMD helpers Stefano Garzarella
2025-03-31 10:38 ` [PATCH v5 3/4] tpm: add SNP SVSM vTPM driver Stefano Garzarella
2025-03-31 17:34 ` Jarkko Sakkinen
2025-03-31 20:56 ` Dionna Amalie Glaze
2025-03-31 21:26 ` James Bottomley
2025-03-31 22:23 ` Dionna Amalie Glaze
2025-03-31 22:59 ` James Bottomley [this message]
2025-04-01 8:58 ` Stefano Garzarella
2025-04-01 9:08 ` Stefano Garzarella
2025-04-01 14:48 ` Jarkko Sakkinen
2025-03-31 10:38 ` [PATCH v5 4/4] x86/sev: register tpm-svsm platform device Stefano Garzarella
2025-03-31 16:10 ` Tom Lendacky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2db0cef00e9ad6061af8256c71d0198b15a5ddc.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=bp@alien8.de \
--cc=cclaudio@linux.ibm.com \
--cc=dave.hansen@linux.intel.com \
--cc=dionnaglaze@google.com \
--cc=dovmurik@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=jroedel@suse.de \
--cc=linux-coco@lists.linux.dev \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterhuewe@gmx.de \
--cc=sgarzare@redhat.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®