From: Juergen Gross <jgross@suse.com>
To: Len Bao <len.bao@gmx.us>,
Stefano Stabellini <sstabellini@kernel.org>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen/mcelog: mark g_physinfo, ncpus and xen_mce_chrdev_device as __ro_after_init
Date: Sat, 23 May 2026 17:37:03 +0200 [thread overview]
Message-ID: <e2df8ceb-2649-42d2-aaf7-37f73ac27318@suse.com> (raw)
In-Reply-To: <20260523132802.25391-1-len.bao@gmx.us>
[-- Attachment #1.1.1: Type: text/plain, Size: 625 bytes --]
On 23.05.26 15:28, Len Bao wrote:
> The 'g_physinfo' and 'ncpus' variables are initialized only during the
> init phase in the 'bind_virq_for_mce' function and never changed. So,
> mark them as __ro_after_init.
>
> The 'xen_mce_chrdev_device' variable is initialized only in the
> declaration and never changed. So, this variable could be 'const', but
> using the 'misc_register' and 'misc_deregister' functions discards the
> 'const' qualifier. Therefore, as an alternative, mark it as
> __ro_after_init.
>
> Signed-off-by: Len Bao <len.bao@gmx.us>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
prev parent reply other threads:[~2026-05-23 15:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-23 13:28 Len Bao
2026-05-23 15:37 ` Juergen Gross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2df8ceb-2649-42d2-aaf7-37f73ac27318@suse.com \
--to=jgross@suse.com \
--cc=len.bao@gmx.us \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr_tyshchenko@epam.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®