From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EED692A1CF for ; Mon, 30 Mar 2026 13:01:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774875719; cv=none; b=gBF2ABACCMJ+3Hm9ZrZDZZlucWX6yY9CvXnftk4uFNTNEuo/A7Wm9c/DUQfPqWJTO5Xsuyr0BsRSx441uxef/uLt0EmrclXRuMtfMQZ0GdLePbSkHjvvb4nuZz3AbGbSVJIUAl89JkNMJ8mGf0SolczyTRSgJO61Fp7Wn6jSs+8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774875719; c=relaxed/simple; bh=bkkBveKjAHydjdwm5B2c0Qxu0aJ1KW2dBLPWw+hE4Ck=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=I3tgVFHV0nt/C8Z607i2LAJPme/iQolyON00MtGlo1jSpK4cjVb7l6iohkE/AYW0yMrqqtpWgN+8ZcrgPy5yCA4uAoNDGwySRQBTeMK5810+Fwv8uZpK4C7lux5gkzoi01Rw1vAAAvzWIj1fNYU7C/5A2ekzfGthitSJSIb1Veg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PvnhmnFT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AAPxu1an; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PvnhmnFT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AAPxu1an" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62UBEGVm1402787 for ; Mon, 30 Mar 2026 13:01:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QIa3nEBOIri1zV4QwKaiohs9t4fLtqXdWwCFyzd67oQ=; b=PvnhmnFTI8iaNZyW zBr6hG7YIhDgMtPekjaFP+anhoM2hn7hnTxnCmO9Ytwxlor8dlAc4XQlm+51Smmm oVhl6dR6GvAwPNYQaKhn4aloLtUBW7Ua4SWM1rzV1fTxj50hoyyJQlRVtT2AwhNC co9VkGbwflz2U9qe3LMvTMu+//nd/E9PJA5jmSk1hX2sbIIuQpGNMJdPL63D2wKC AznYDVyLML8r7R6Gu13SE/Y0JfnMkGFhb8E6An9HukfivY+3/KoKo8/TU2SoRHU7 m2k8Gv7gb9/E9JYg4Npq3841F5zuFAwDDlt6V2MN88IbQauh2+0NjHj2iDQ/Lzew MnZJUw== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d7r4h8gqa-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 30 Mar 2026 13:01:56 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-35d96923dd2so2255141a91.1 for ; Mon, 30 Mar 2026 06:01:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774875716; x=1775480516; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QIa3nEBOIri1zV4QwKaiohs9t4fLtqXdWwCFyzd67oQ=; b=AAPxu1angsad5HEZXkP9Z09UVTg0Cj7BhJ1Hc2R9F28ymoDW68ym6ivh4ByR5HgSWW C5LcP2fmuNQEtXhRue/p9j5aogOxgqlrTXaOltFdHRdsGsWVZeMWRJsvrVZMf7ahmGB7 vcfa6wFFfgNy5BIdQLv6p2qwjA63RTcWHuqxM7SfvKxTL/TlNYqp3qagJB8OiGlnxxdw KkPWIPjIs5aTEg0jUQC0ozVUtp+0S6z1YeU/NLQxbt3WwVTkWSJfa4SjFJUqmBh9SGe7 Z56I1fxBSKRKd9vMQPZe2PYeDvZPtoNT2BcEbge/32TrqDbGlGHWoJpIW1YtRqFbKNyN lmsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774875716; x=1775480516; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QIa3nEBOIri1zV4QwKaiohs9t4fLtqXdWwCFyzd67oQ=; b=Bp6HgnKjWSEkmKTX0r3J5wp5yXLTVEymLXM7dWaFkLj/CIhuZJzVgoC9vzqx83mqEn it59WTNX7wt1cILGWKu/JvH+wWbuw5R7CktQyj8bZ1WR0ARH+SufUsLSV0ljOLUkmKPa M5t4+rufDJJkMlzmRaquRm1dvvvqn/rpG6g5Q3dFZnsHviuCvCMEBAGoaJ48eJwpPpd9 zp0tGdJB2ER9woB1mA63q6eWJ1BE0UkknSeLr+BFiualdZ8RZit0AVVepBRYx+gAfKI0 tTg0mvB0xyLqM9gCCMJ6H0TGKTSuo22FHYAOH5dV+xrFyzVFVnos2c8x0NhyvqRwKo1s Mm2Q== X-Forwarded-Encrypted: i=1; AJvYcCX2siTN58p59e1uOm/aF6Z32rmZQwH7ZzSm1WPYn747ETQ43f+9N0En3v9JA0rgW2iE/A6OXx2PGhhidkM=@vger.kernel.org X-Gm-Message-State: AOJu0YzaT8EEkE2xE70LAxVGd7K0IaYP/7slgeYeEJJWXVTt+L9yQo1N r8eVg5Ah0AAwd6wuurWyJcJlg5RunQTAkt/kiLBGH6fFU3NGOR/ZcTI4M6+PsFI28QadM+NLLom HbwlW+p8IS59LoL1dc+J+X9kPl5Y1kqlL0GuPelCVVl3bYxWYf3BF8aVGg8nxUW2AG7o= X-Gm-Gg: ATEYQzxnoLjyRJReEJlboPHS9YbxbYrtQZY1QTwLUwJ+4AjdXR5uCzQ+3MJ0SnQp+/D YqGocmGsa1Ckrprnj5CGpIFtuLEYh9a9uenKBBE+aVkPOm2ufIB1VSI8ENTI8A4BDY+u2AZ40oR kr1TxcUS/lXVGys3op52ep4+N0VfUznHcCZZp5BbMLKD00gfl8jUxYibCYmrLBhsZKQnaS3cD7I ObHsLtfW0dYV/acF82ZVT5vb2f8A2+ykqtMPS4Mjv8wrXFZyUQOut+ftUBY5ilkwzPhpH7b3qan H8oY0K0cIvFhl+UosyWIE6iQv1XiIplQ9KNHz3+3iUh1uMLx6E9B1NX13VNmw5zs8msf89RGEbP 4D07BBiqrUcd0CwCDQNqLeYGo/w1gPcTNx1E2Qa5mLKDRPt+mpxtCd/tw+FkYZMI0dHDuUg0TOv 0uGq0WTYilt60pGMd3 X-Received: by 2002:a17:90b:3d06:b0:35a:189b:43db with SMTP id 98e67ed59e1d1-35c2ffa80ccmr11171845a91.4.1774875715303; Mon, 30 Mar 2026 06:01:55 -0700 (PDT) X-Received: by 2002:a17:90b:3d06:b0:35a:189b:43db with SMTP id 98e67ed59e1d1-35c2ffa80ccmr11171786a91.4.1774875714415; Mon, 30 Mar 2026 06:01:54 -0700 (PDT) Received: from [10.133.33.66] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35d94d3039csm8842008a91.6.2026.03.30.06.01.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2026 06:01:54 -0700 (PDT) Message-ID: Date: Mon, 30 Mar 2026 21:01:49 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 2/2] cpufreq: Add boost_freq_req QoS request To: "zhenglifeng (A)" , Pierre Gondois , linux-kernel@vger.kernel.org Cc: Huang Rui , "Gautham R. Shenoy" , Mario Limonciello , Perry Yuan , "Rafael J. Wysocki" , Viresh Kumar , linux-pm@vger.kernel.org, zhongqiu.han@oss.qualcomm.com References: <20260326204404.1401849-1-pierre.gondois@arm.com> <20260326204404.1401849-3-pierre.gondois@arm.com> <8261d970-ccaa-494c-91c7-6ebecce010ac@oss.qualcomm.com> <6eff4517-cc4b-4f2f-8e39-6cfe8b18c4dc@oss.qualcomm.com> <6cd973e4-5df5-47b0-86d5-1552f8ba8d2e@huawei.com> Content-Language: en-US From: Zhongqiu Han In-Reply-To: <6cd973e4-5df5-47b0-86d5-1552f8ba8d2e@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDEwMSBTYWx0ZWRfX1hd/jVpmy5D6 haeBPI6iQGVVzFsecXCwcx7GJ9Wrugs+2O4FgIH2xqtiqjBDwVSjJjIeYUivHd9Fg4S57XNhieH XKDxjLnJlOsH9SLhdvfmnYGmg2kuPulS+eGqBQruEw72qNo+MAqoEbB3cpzJmG9oLdgBqMh25OK WtR4Wee2Gvu/fImLC6CmTFRmfdLd4LxeCEFCEwnHSFDNROy9qWtNcNhZx4MBSsOkI6ZCpCnh/9f LrqrJmcGcIJRYqeVkzIl63ymTfKZ3Pq1lHU/FkgZRbEIsH2MPvSa6YN40qt/58g2KhtHs22lOeJ ToF6trrArDZNVWpaL7Ut/tuMbcvOa76afLxAIg6gOCASREk0G7+sAIsm+WtyYK/8mZILWjIXpGF 8iZYJOSnArq7e0TR+Fi5gJaRTPSGc78VGaT8FHIctAfuQdxF0VXx8qCL0t1g93WbRUJOjvVCBDe sM+zqRFlBNPaHzusHlg== X-Proofpoint-ORIG-GUID: CNrXzkiiQobDTn4YZJ0oFRoPHj6wuo51 X-Authority-Analysis: v=2.4 cv=PI0COPqC c=1 sm=1 tr=0 ts=69ca7444 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=J7N9wpLcb6RgLkOmlGQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: CNrXzkiiQobDTn4YZJ0oFRoPHj6wuo51 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 adultscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300101 On 3/30/2026 3:16 PM, zhenglifeng (A) wrote: > On 3/30/2026 12:00 PM, Zhongqiu Han wrote: >> On 3/30/2026 10:10 AM, zhenglifeng (A) wrote: >>> On 3/29/2026 5:00 PM, Zhongqiu Han wrote: >>>>> @@ -1377,6 +1386,7 @@ static void cpufreq_policy_free(struct cpufreq_policy *policy) >>>>>        } >>>>>          freq_qos_remove_request(policy->min_freq_req); >>>>> +    freq_qos_remove_request(policy->boost_freq_req); >>>>>        kfree(policy->min_freq_req); >>>>>          cpufreq_policy_put_kobj(policy); >>>>> @@ -1445,26 +1455,38 @@ static int cpufreq_policy_online(struct cpufreq_policy *policy, >>>>>        cpumask_and(policy->cpus, policy->cpus, cpu_online_mask); >>>>>          if (new_policy) { >>>>> +        unsigned int count; >>>>> + >>>>>            for_each_cpu(j, policy->related_cpus) { >>>>>                per_cpu(cpufreq_cpu_data, j) = policy; >>>>>                add_cpu_dev_symlink(policy, j, get_cpu_device(j)); >>>>>            } >>>>>    -        policy->min_freq_req = kzalloc(2 * sizeof(*policy->min_freq_req), >>>>> +        count = policy->boost_supported ? 3 : 2; >>>>> +        policy->min_freq_req = kzalloc(count * sizeof(*policy->min_freq_req), >>>>>                               GFP_KERNEL); >>>>>            if (!policy->min_freq_req) { >>>>>                ret = -ENOMEM; >>>>>                goto out_destroy_policy; >>>>>            } >>>>>    +        if (policy->boost_supported) { >>>>> +            policy->boost_freq_req = policy->min_freq_req + 2; >>>>> + >>>>> +            ret = freq_qos_add_request(&policy->constraints, >>>>> +                           policy->boost_freq_req, >>>>> +                           FREQ_QOS_MAX, >>>>> +                           policy->cpuinfo.max_freq); >>>>> +            if (ret < 0) { >>>>> +                policy->boost_freq_req = NULL; >>>>> +                goto out_destroy_policy; >>>>> +            } >>>>> +        } >>>>> + >>>>>            ret = freq_qos_add_request(&policy->constraints, >>>>>                           policy->min_freq_req, FREQ_QOS_MIN, >>>>>                           FREQ_QOS_MIN_DEFAULT_VALUE); >>>>>            if (ret < 0) { >>>>> -            /* >>>>> -             * So we don't call freq_qos_remove_request() for an >>>>> -             * uninitialized request. >>>>> -             */ >>>>>                kfree(policy->min_freq_req); >>>>>                policy->min_freq_req = NULL; >>>>>                goto out_destroy_policy; >>>> >>>> Hi Pierre, Viresh, >>>> >>>> Sorry for the late follow-up on v8. While re-reading the patch, I >>>> noticed a potential UAF issue on an error path — I might be missing >>>> something, so I'd appreciate a double-check. >>>> >>>> min_freq_req, max_freq_req and boost_freq_req all point into the same >>>> contiguous kzalloc'd block: >>>> >>>> slot0 (min_freq_req + 0) -> min_freq_req >>>> slot1 (min_freq_req + 1) -> max_freq_req >>>> slot2 (min_freq_req + 2) -> boost_freq_req >>>> >>>> If boost_freq_req is successfully added to the QoS constraints list, but >>>> the subsequent freq_qos_add_request() for min_freq_req fails, the error >>>> path does: >>>> >>>> kfree(policy->min_freq_req); /* frees the entire block, including slot2 >>>> */ >>>> policy->min_freq_req = NULL; >>>> goto out_destroy_policy; >>>> >>>> policy->boost_freq_req is not set to NULL here, so it becomes a dangling >>>> pointer into freed memory. >>>> cpufreq_policy_free() is then called from cpufreq_online() and does: >>>> >>>> freq_qos_remove_request(policy->boost_freq_req); /* UAF */ >>>> or this boost qos req will leak. >>>> >>> >>> Good catch! >>> >>> How about remove the kfree() here and just leave it to >>> cpufreq_policy_free()? >>> >> >> Thanks for the suggestion — this is another fix approach we can >> explore, but there seems to be a small caveat. >> >> Some additional changes would still be needed; otherwise, removing the >> kfree() here and deferring it to cpufreq_policy_free() can lead to a >> warning. >> >> The reason is that we neither free policy->min_freq_req nor set policy >> ->min_freq_req = NULL. As a result, when cpufreq_policy_free() later >> calls freq_qos_remove_request(policy->min_freq_req), it hits the >> following warning: >> >> if (WARN(!freq_qos_request_active(req), >>     "%s() called for unknown object\n", __func__)) >>     return -EINVAL; >> > > Therefore, it seems the only option is to allocate memory separately for > boost_freq_req. > Thanks Lifeng. Allocating memory separately could also be a direction we can explore. I also sketched another small example in a separate mail thread for discussion. -- Thx and BRs, Zhongqiu Han