From: Bart Van Assche <bvanassche@acm.org>
To: Roland Dreier <rdreier@cisco.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, David Dillow <dave@thedillows.org>
Subject: Re: [PATCH] Add BUILD_BUG_ON_NOT_POWER_OF_2()
Date: Thu, 7 Jan 2010 08:33:21 +0100 [thread overview]
Message-ID: <e2e108261001062333p2a626bf6h4b25de0ac919ef1d@mail.gmail.com> (raw)
In-Reply-To: <adaeim2supb.fsf_-_@roland-alpha.cisco.com>
On Thu, Jan 7, 2010 at 12:02 AM, Roland Dreier <rdreier@cisco.com> wrote:
> +/* Force a compilation error if expression is not a power of 2 */
> +#define BUILD_BUG_ON_NOT_POWER_OF_2(n) \
> + BUILD_BUG_ON(((n) != 0 && (((n) & ((n) - 1)) == 0)))
Hello Roland,
Can you please change the above into the following, such that the
macro does what its name suggests:
#define BUILD_BUG_ON_NOT_POWER_OF_2(n) \
BUILD_BUG_ON(((n) == 0 || (((n) & ((n) - 1)) != 0)))
Bart.
next prev parent reply other threads:[~2010-01-07 7:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 20:21 [PATCH] log2.h: Macro-ize is_power_of_2() for use in BUILD_BUG_ON Roland Dreier
2010-01-06 20:33 ` Andrew Morton
2010-01-06 20:44 ` Roland Dreier
2010-01-06 21:15 ` David Dillow
2010-01-06 21:42 ` Andrew Morton
2010-01-06 23:02 ` [PATCH] Add BUILD_BUG_ON_NOT_POWER_OF_2() Roland Dreier
2010-01-06 23:09 ` Andrew Morton
2010-01-07 7:33 ` Bart Van Assche [this message]
2010-01-07 7:51 ` Roland Dreier
2010-01-07 8:36 ` Robert P. J. Day
2010-01-07 16:45 ` Stefan Richter
2010-01-06 21:23 ` [PATCH] log2.h: Macro-ize is_power_of_2() for use in BUILD_BUG_ON Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2e108261001062333p2a626bf6h4b25de0ac919ef1d@mail.gmail.com \
--to=bvanassche@acm.org \
--cc=akpm@linux-foundation.org \
--cc=dave@thedillows.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®