From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47E80C433EF for ; Tue, 25 Jan 2022 16:04:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356810AbiAYQD5 (ORCPT ); Tue, 25 Jan 2022 11:03:57 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:38664 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358985AbiAYQCi (ORCPT ); Tue, 25 Jan 2022 11:02:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643126557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IcXE3mGr5yfM3UtM9LVtuUY7Hip9fv9Bn5lXnjAC8TA=; b=AFeATuYBBXKvC9Sxk9NcXPiFT9k47o3kyso1nMXrDMZM7lq63lJOWlZASM3e14rdyx84DI DScLfPTMzd9O4MdmNwHHEnVM+fYMqYXJHevQ7sSc+hVTV2Dq1hNa+wbncm4o/xTkb20PeN 2qg37ssQu9jclC+3zOGv1tHz9nFDVJg= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-12-Qze3TO59OGC5xTp9eXjLmA-1; Tue, 25 Jan 2022 11:02:35 -0500 X-MC-Unique: Qze3TO59OGC5xTp9eXjLmA-1 Received: by mail-ed1-f69.google.com with SMTP id el8-20020a056402360800b00403bbdcef64so15262103edb.14 for ; Tue, 25 Jan 2022 08:02:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=IcXE3mGr5yfM3UtM9LVtuUY7Hip9fv9Bn5lXnjAC8TA=; b=s4U2rC5s8EfENGDB9eDhloTYww4Fbn77TApflIu4ei8T39a4VV/XuTL/XHvzWYznWo MvGw+LLBL4xfHPXn8ZiX7T5KEH0SQmBzxB69TuZmPAoHAutb0mE9q7ixLsjMu2UFYXDm l82KVsuOnTpxO0aeOb3Vqn+SS6nrBLRIrRWjVtJ5G+2e1g6filU6/gsNdegA5XuWvI42 o7bvyBks/2G17iHEt+ZPxXUZgmR5dN2sYrSS9QYrWV3kNjRcdPLDvA9b/duwhgUvMpdU CysjY7whEEJt5t6esmTfn6dQlO1glaopPt4Y2+jqB5QWeTqEhpasVW73QOVeeDSj2gTj RkkA== X-Gm-Message-State: AOAM530dcIVZErgSicb2GcH4auB4wg9oD3WX5yw+PA9cF9BHbh7dYIGw LGzjS04Bmat695172VkChxSQw5pJ0K5+fWfvi9XWQwz0ItPqkSwk+hkAvMmSei41P5C3owSPoKP i9pc+FWmCOmxpCoKoiNlUmH7b X-Received: by 2002:a17:907:72c4:: with SMTP id du4mr8767055ejc.243.1643126552085; Tue, 25 Jan 2022 08:02:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJwU53k0R46hrB5fKDfPkTXRr1Nq6+8sBmzHPfHo09CnOTd5BXa/VXr/nYQ7KlVvTDXEMsvf5Q== X-Received: by 2002:a17:907:72c4:: with SMTP id du4mr8767031ejc.243.1643126551881; Tue, 25 Jan 2022 08:02:31 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.googlemail.com with ESMTPSA id g8sm6445025ejt.26.2022.01.25.08.02.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jan 2022 08:02:31 -0800 (PST) Message-ID: Date: Tue, 25 Jan 2022 17:02:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 07/19] KVM: x86/svm: Remove unused "vcpu" of nested_svm_check_tlb_ctl() Content-Language: en-US To: Jinrong Liang Cc: Xianting Tian , Jim Mattson , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220125095909.38122-1-cloudliang@tencent.com> <20220125095909.38122-8-cloudliang@tencent.com> From: Paolo Bonzini In-Reply-To: <20220125095909.38122-8-cloudliang@tencent.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/25/22 10:58, Jinrong Liang wrote: > From: Jinrong Liang > > The "struct kvm_vcpu *vcpu" parameter of nested_svm_check_tlb_ctl() > is not used, so remove it. No functional change intended. > > Signed-off-by: Jinrong Liang This might be useful later if the code needs to check guest CPUID bits. Leaving it in for now. Paolo > --- > arch/x86/kvm/svm/nested.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/svm/nested.c b/arch/x86/kvm/svm/nested.c > index cf206855ebf0..5a1a2678a2b1 100644 > --- a/arch/x86/kvm/svm/nested.c > +++ b/arch/x86/kvm/svm/nested.c > @@ -209,7 +209,7 @@ static bool nested_svm_check_bitmap_pa(struct kvm_vcpu *vcpu, u64 pa, u32 size) > kvm_vcpu_is_legal_gpa(vcpu, addr + size - 1); > } > > -static bool nested_svm_check_tlb_ctl(struct kvm_vcpu *vcpu, u8 tlb_ctl) > +static bool nested_svm_check_tlb_ctl(u8 tlb_ctl) > { > /* Nested FLUSHBYASID is not supported yet. */ > switch(tlb_ctl) { > @@ -240,7 +240,7 @@ static bool __nested_vmcb_check_controls(struct kvm_vcpu *vcpu, > IOPM_SIZE))) > return false; > > - if (CC(!nested_svm_check_tlb_ctl(vcpu, control->tlb_ctl))) > + if (CC(!nested_svm_check_tlb_ctl(control->tlb_ctl))) > return false; > > return true;