From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751216AbdALQv7 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 12 Jan 2017 11:51:59 -0500
Received: from mout.web.de ([212.227.17.12]:56394 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751113AbdALQv4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 12 Jan 2017 11:51:56 -0500
Subject: Re: mtd/ftl: Use kmalloc_array() in build_maps()
To: Cyrille Pitchen <cyrille.pitchen@atmel.com>,
        linux-mtd@lists.infradead.org
References: <4a5a265e-96c8-5fe6-487a-92a0d47a91da@users.sourceforge.net>
 <b379ba57-d926-2572-17ec-5bbe166b0e37@users.sourceforge.net>
 <4be87294-5e91-5ced-770f-8630ccab689a@atmel.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
        Brian Norris <computersforpeace@gmail.com>,
        David Woodhouse <dwmw2@infradead.org>,
        Marek Vasut <marek.vasut@gmail.com>,
        Richard Weinberger <richard@nod.at>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <e2e1d30e-b81f-d034-b266-37fec409350d@users.sourceforge.net>
Date: Thu, 12 Jan 2017 17:50:36 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <4be87294-5e91-5ced-770f-8630ccab689a@atmel.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:D1UPIVHH0ohoSB483HKqxgA3FYJYw2SZrZuIFN1pjwXlQa/t6tb
 QMyv/79rjL7Ew08QbovmqUlBQvwYtG6M+uKNgqL/jXV5Sv+3HrifID4hZ+u2lIUFJM7qTIy
 VlT8qUpWOQmCPPUYiy24M+deQ2p8xF1vMdRTG/e/u7AnkKCyV/C3ayopduxpJLRImjx2uRi
 pulhx+EOv/tnk6VWkMUOg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:VEtYQwGgDHw=:G0V4Ib9cQ01I9JGS9LAy52
 cgzlsFsbr56BYcuRtrJ7Oa8jzs0F+aWdlNe5fD2atiEAuYg6ibRGDX21eRbXHJcELVA2JOpJz
 abDrEWsCx2pPgsH79YaYD/UpSVaxlyYQuan6lzOC+dcr9qxF6716qxWYmPLw9KapkPhG1pBTt
 2yVOKeJMABd+v8KV0p1/hkwrLSY6N7xWXPi0hZoD/ibdTSjrHLLANWd1vhPKF2Z57zAkRQqIL
 NBdY3pseW+DYMG+HGl3CQnd0mT4F+Dm5G9VZd2YE848mOJpd1BQN2h/ozd36LqQoQSHf5DnUo
 bAF261KtPe2pNvu8AQ7gVlauVsE99GONlyL7vZ+sT2A+hgr7kKGDZcl2yJNbqL1DNDQhdEgRI
 ryL073H6kDqma1LELeiS+AOk9hyBbKzlGkExZVx5vrwZe/OwIBQhJfgakCjk7TUnOIRsONqXA
 z+YKPZozmX7sXQXqMV3GpuVJj2q4b3tKtA3XHrf8PHis0q5t8Jf6iKGmjOvui2AyS4Xctf4Vu
 TYpX0awmfPXq05l51pL+VGLZ2e4WBalvmtpEGzYI4qco07F8kluuQ5XTD/vWYIqDC07v4mU9D
 ghBlWwFw1r+6ezi0HHe7s919feB7qlwP59xQqWnGI+q177HWJZwm/pm9rxNINyuIkPLBkMM9E
 hGAuRna5PeVRFdFB0WPlmNuB9+YH+ctUnAYW0/bSz5c8JyWGR/007IcXX7tKLneupVqyRoXrz
 6x/caIEukqN8wEfUEnlCEZNEXwCoWHEgsH5VNiIIUdFlTh8HajT7xk02WiD5fwkMlTxrRuCyS
 62ofBMr
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> The indentation has been changed and the new one looks wrong...

The source code formatting contained various open issues before already.


> If you want to fix the indentation to make it compliant with the Linux
> coding style, do it on the whole file so every thing is uniform.

Such a development task is too much for me today.


> Reviewing such dummy/automatic patches is a pure waste of time,
> so personally I think we should just ignore them.

How much do you care for the usage of a function like “kmalloc_array”?

Regards,
Markus