From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753591AbeAQPww (ORCPT ); Wed, 17 Jan 2018 10:52:52 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:33457 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751559AbeAQPwv (ORCPT ); Wed, 17 Jan 2018 10:52:51 -0500 X-Google-Smtp-Source: ACJfBouBcvSdiDoz1+YCa8iJ3fBOPcq/ObG/4og+TFaQ/7HYD8QBdmgdfgt2rN0bRCcNvA/mrJgN5g== Reply-To: minyard@acm.org Subject: Re: [PATCH -next] ipmi/powernv: Fix error return code in ipmi_powernv_probe() To: Wei Yongjun Cc: openipmi-developer@lists.sourceforge.net, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Jeremy Kerr , "Michael, Ellerman" , Alistair Popple References: <1516188311-144227-1-git-send-email-weiyongjun1@huawei.com> From: Corey Minyard Message-ID: Date: Wed, 17 Jan 2018 09:52:47 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1516188311-144227-1-git-send-email-weiyongjun1@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/17/2018 05:25 AM, Wei Yongjun wrote: > Fix to return a negative error code from the request_irq() error > handling case instead of 0, as done elsewhere in this function. I think you are right here.  However, you had a bunch of people on the email that probably didn't need to be there, and didn't have a few that should. I've adjusted in this response. This was introduced in change dce143c3381c355ef73be3dd97cf3ca1b15359b8, you should add a "Fixes:" in the commit text. I'll let the people that did this code comment, just to be sure, and wait for a v2 patch from you after that. Thanks, -corey > Signed-off-by: Wei Yongjun > --- > drivers/char/ipmi/ipmi_powernv.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/ipmi/ipmi_powernv.c b/drivers/char/ipmi/ipmi_powernv.c > index c687c8d..bcf493d 100644 > --- a/drivers/char/ipmi/ipmi_powernv.c > +++ b/drivers/char/ipmi/ipmi_powernv.c > @@ -250,8 +250,9 @@ static int ipmi_powernv_probe(struct platform_device *pdev) > ipmi->irq = opal_event_request(prop); > } > > - if (request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH, > - "opal-ipmi", ipmi)) { > + rc = request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH, > + "opal-ipmi", ipmi); > + if (rc) { > dev_warn(dev, "Unable to request irq\n"); > goto err_dispose; > } >