From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2424C61D9D for ; Thu, 23 Nov 2023 03:02:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344080AbjKWDBw (ORCPT ); Wed, 22 Nov 2023 22:01:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232615AbjKWDBu (ORCPT ); Wed, 22 Nov 2023 22:01:50 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88D3C191; Wed, 22 Nov 2023 19:01:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=Xptzas81N17YCuuLxBooSV9D0A5Kbw2K/uN1U+PXfjw=; b=rUhUJQzTP+xMnrOSIku0+NXS9e Vwx/yg9ArH/c7A/Hi97odu9Rty203sOPxQXXqHB8k+uJkoz6Jn6LRa5jL/aFAHtZpFI2e2AtHZ2Cb +WS/q/1vBCfgD+sp4sQuD362kTCVDKhoe31BMaeB8SMr1rrcM6TlTkqzK85s7wAbgJ4Q=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1r5zyH-000w18-Cr; Thu, 23 Nov 2023 04:01:41 +0100 Date: Thu, 23 Nov 2023 04:01:41 +0100 From: Andrew Lunn To: Christian Marangi Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Konrad Dybcio , Heiner Kallweit , Russell King , Florian Fainelli , Broadcom internal kernel review list , Daniel Golle , Qingfang Deng , SkyLake Huang , Matthias Brugger , AngeloGioacchino Del Regno , David Epping , Vladimir Oltean , "Russell King (Oracle)" , Harini Katakam , Simon Horman , Robert Marko , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [net-next RFC PATCH 11/14] dt-bindings: net: add QCA807x PHY defines Message-ID: References: <20231120135041.15259-1-ansuelsmth@gmail.com> <20231120135041.15259-12-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231120135041.15259-12-ansuelsmth@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 20, 2023 at 02:50:38PM +0100, Christian Marangi wrote: > From: Robert Marko > > Add DT bindings defined for Qualcomm QCA807x PHY series related to > calibration and DAC settings. > > Signed-off-by: Robert Marko > Signed-off-by: Christian Marangi > --- > include/dt-bindings/net/qcom-qca807x.h | 45 ++++++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > create mode 100644 include/dt-bindings/net/qcom-qca807x.h > > diff --git a/include/dt-bindings/net/qcom-qca807x.h b/include/dt-bindings/net/qcom-qca807x.h > new file mode 100644 > index 000000000000..42c45c7d5210 > --- /dev/null > +++ b/include/dt-bindings/net/qcom-qca807x.h > @@ -0,0 +1,45 @@ > +/* SPDX-License-Identifier: GPL-2.0-only OR MIT */ > +/* > + * Device Tree constants for the Qualcomm QCA807X PHYs > + */ > + > +#ifndef _DT_BINDINGS_QCOM_QCA807X_H > +#define _DT_BINDINGS_QCOM_QCA807X_H > + > +#define PSGMII_QSGMII_TX_DRIVER_140MV 0 > +#define PSGMII_QSGMII_TX_DRIVER_160MV 1 > +#define PSGMII_QSGMII_TX_DRIVER_180MV 2 > +#define PSGMII_QSGMII_TX_DRIVER_200MV 3 > +#define PSGMII_QSGMII_TX_DRIVER_220MV 4 > +#define PSGMII_QSGMII_TX_DRIVER_240MV 5 > +#define PSGMII_QSGMII_TX_DRIVER_260MV 6 > +#define PSGMII_QSGMII_TX_DRIVER_280MV 7 > +#define PSGMII_QSGMII_TX_DRIVER_300MV 8 > +#define PSGMII_QSGMII_TX_DRIVER_320MV 9 > +#define PSGMII_QSGMII_TX_DRIVER_400MV 10 > +#define PSGMII_QSGMII_TX_DRIVER_500MV 11 > +/* Default value */ > +#define PSGMII_QSGMII_TX_DRIVER_600MV 12 Its not clear what these are used for. I think these are actually package properties, so having the correctly documented in the binding would help a lot understand why we need package properties. Actually using #define like this is probably wrong. You should just have a u32 tx_driver_mv property, and list [140, 160, 180, 200, ... 600] as valid values. The driver should then convert to whatever value it should write into the register. Andrew