From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.51 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794564919; b=3NNS4TC8exQOIBJ4io/Unc4rsUxKk08OynLtB88JVZPSIj0hGRADGnQRq7bMwo7P7Paj ZeUJxOTnchIkbJrqG7QgO8LjvCsuscS5D2+9UML/U+US43QiHI7EEWrNXKfEdb3boJM7/ rdXxlC3dd7C3sn70CBJsYvIJATJyEXfN6lO2ZDgnRzxlevij8x5qEA7JntSoVCxL6LqBm FspSct/CynXyFQ16zZo9j0r3vRXnsBNQSStbR4yNidzSjjnb7bMWFWh7HdbncWiPrJkNe QE0AZY7taFBoDMB7Zoo8tF73gQEBxDJx5sQnSkhwC6JiHvGF40Z/zfwDt2iSpbHfUKQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794564919; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:Content-Transfer-Encoding:User-Agent:MIME-Version; bh=QtOsdPCKGJ1fBhMqXd/zLQfd50NEx4L7veNiE/G2OUE=; b=hDParwTPAuD1zEFICNrErKD6DHZ2n3sUQlpaBB83k3vk03FcEUXfSWFZbRS54RcgX3NI cTx2SsQ1FAD6sIp+6xfOOqJlHEfpXXFIkp4pmWc1NTU6WbrYBwnNGDEoBuWQPnKrTS2At 6SOvaG5LVE7ZocRzzdrqACZxhe18Mc8hKkJnrmM5e3BNGMx/tUV09ndGy6Ghur5bhWHZU 48RcbiD1B0SiJKkHUAzteTf25jfgbjyxsHW+GpuzOUqn+wRh5yULAQHnWRitKTFQEQZgp cihez2957ZLiaal4mD4KhboT4pIFjo2w6MkDO17cwIPv16vUlRBrbRtKVT9w31uo2sA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=amutable.com; spf=pass smtp.mailfrom=amutable.com; dkim=pass header.d=amutable-com.20260707.gappssmtp.com header.i=@amutable-com.20260707.gappssmtp.com header.a=rsa-sha256 header.s=20260707 header.b=XokUN4uh; arc=none smtp.remote-ip=209.85.128.51 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2879606A8B9 for ; Fri, 13 Nov 2026 10:15:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org A2879606A8B9 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=amutable.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amutable.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amutable-com.20260707.gappssmtp.com header.i=@amutable-com.20260707.gappssmtp.com header.a=rsa-sha256 header.s=20260707 header.b=XokUN4uh Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4a5036bbac7so3785155e9.3 for ; Fri, 13 Nov 2026 02:15:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amutable-com.20260707.gappssmtp.com; s=20260707; t=1794564917; x=1795169717; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=QtOsdPCKGJ1fBhMqXd/zLQfd50NEx4L7veNiE/G2OUE=; b=XokUN4uhZ5cnIDNPS9kLjfaPp8ZSmyDY7nHz3ffF9uftFGQzzc0NaUd0CPxl6tmm/G EB2bqVZrrrQULKzHfxmMlarOF7+NP4G1EuGLp1x7hwkFzcf5DKQIlYH5+zTWTg0qLXK8 Q27+pu7matN83z4kFimCCYFY9EtcVBpSYh+f+WbPWczzC82gi2dU1+IxENiNgIvD4ssI 1POQJndyP8zOY9I/drEtHc8Rir/wcokVwFCL8xkdsULqRcKqvw/m2pftg5e6OYSufYMA FPm06vn59Z5lYx4UA2FpKr0UjB0BBdejlJLIE+RKFWt9/d0/clXrD3SuYpmwDbHdW+74 JQJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794564917; x=1795169717; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QtOsdPCKGJ1fBhMqXd/zLQfd50NEx4L7veNiE/G2OUE=; b=KAWD+nT4aBW87ZEJ/2uG6JnHOxt2yR1veGpglRviKMRVm3AxxkVZLuWnz+x1/H7uKI u9prSqYbTGRv3LOz34Zf5bCAMcRdwuU+o1oGGlZY4Z+IRLMHW/HPBIa0efVuhBiMHPov zSXTHg3VQOD2euGjrAfVvD76/AJ43dpJLVrybfBplS/eidFKn+Ka6uYGWGN8nxlhUoPc oY9pyc8bu4r9Nw6LhsPJ+ObGNNsD+5xepBmqQrwGDJ/GSJBl9/elFFaU2b9GapOH/lHy LxiimIiUXBicWqiBoJhPiKgjiz0AgfrdRv3eRWEztrml13bAlop0a2FprbHnHw3ZNEu4 nneQ== X-Forwarded-Encrypted: i=1; AL+hErFOjX+HGbz5Cv9lWGh5uSXMMdJd1Gv/7OJmBhqmopWNAoTs/Dy8pqE8s4GM9UrLFwLcDKAvSHzzl4qalAk=@vger.kernel.org X-Gm-Message-State: APuU4Z8W55deCnraPZDf56YW+nnE45C501xwjJp922kYmm5WU3HSCZuw MIe7Y8Jh/xkzpQhhHyE/3n/jgj6f5rwoKnm3ohHGHpoiprm3kFVL5iIlIlV4qtprT/ds X-Gm-Gg: AYBFou2xrpwi0dojduKDRsFyVryZT3AJvyIz/nhdqSAPAzbTewypwF2XX7nWjgrzOci vH1i9RlyxfsE9CNgXINoy9le4HHmEyZdYL4mUUglG6GJhuRqXc0dN06kt9DxMhT4/f35MLeTXf+ W7p4/pr6ITdBDTsWZKdyVst81aOxJsZtd3SWyjF8acDbp+Ch3bzBvbQgPdzuSxKFD5d+/tBHM4c 6Whe188i7JW+U9LoWCvgcDgzFZuwRUI8Sv4Tq87QJkokgztgl/PiHYVDyuXbQinx5zjRr8PAQxO x+xsv/B7lGXpLxxjqAJeYo+TwzJPZzueaknV3BMRDgJiGVQ3ybahsNzust0gkH0JFjPRMwhe8c0 rUrDN2oMM11wL2cwMw3ueR04rSn1w7GgmpJVbDmGhZDt9mdeft3LG2eOO/HN7HSnLDz51X71AY9 oLZIn+FoUXQy1qgqOUkr7Za9XPG7z85blNAEvFNtcd/EWtfA+GoFexVboaU/ADoO3hA+FQRhfQF 1XtahnA1BD/ofCGH8s63yE0Qv11TkFwIk9DSr5wbXeg4TTZ5Xdoqoj2DVYQ9a1l5vNpgmLQAnuF ZDZYubQ4P0Fi/VqntR3nbtsXpH+PJyO63ahXrnvwIE2pbI1m8BvOtz043mvyfsc= X-Received: by 2002:a05:600c:4f84:b0:4a7:7f3f:6f8e with SMTP id 5b1f17b1804b1-4bb5599ade1mr43492835e9.0.1794564916955; Fri, 13 Nov 2026 02:15:16 -0800 (PST) Received: from [10.0.0.233] (tmo-086-54.customers.d1-online.com. [80.187.86.54]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4bb56680ea9sm31982365e9.0.2026.11.13.02.15.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2026 02:15:16 -0800 (PST) Message-ID: Subject: Re: [PATCH RFC 33/41] fs: add file_is_pseudo() From: Alexander Mikhalitsyn To: Christian Brauner , linux-fsdevel@vger.kernel.org Cc: Jann Horn , Chris Mason , Josef Bacik , Christoph Hellwig , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Alexander Viro , Jan Kara , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, driver-core@lists.linux.dev, linux-mm@kvack.org, bpf@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, apparmor@lists.ubuntu.com, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, fuse-devel@lists.linux.dev, linux-efi@vger.kernel.org, xen-devel@lists.xenproject.org, ocfs2-devel@lists.linux.dev, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-usb@vger.kernel.org, Amir Goldstein , linux-erofs@lists.ozlabs.org, linux-kselftest@vger.kernel.org Date: Fri, 13 Nov 2026 11:15:14 +0100 In-Reply-To: <20261110-work-loop-pseudo-v1-33-4c998976c6c7@kernel.org> References: <20261110-work-loop-pseudo-v1-0-4c998976c6c7@kernel.org> <20261110-work-loop-pseudo-v1-33-4c998976c6c7@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-0+deb13u1 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 On Tue, 2026-11-10 at 10:14 +0100, Christian Brauner wrote: > Add a helper to check whether a file is a regular file on a pseudo > filesystem. Only regular files count. Device nodes on pseudo > filesystems > such as devpts, binderfs or the block devices on bdevfs are what they > are. >=20 > Look at the inode that actually provides the data via d_real_inode(). > overlayfs accepts sysfs, cgroup2, debugfs, tracefs, configfs and > securityfs as lower layers and reads of such an overlayfs file are > served by the file on the pseudo filesystem. Checking the overlayfs > inode would miss that. >=20 > No functional changes. >=20 > Signed-off-by: Christian Brauner (Amutable) Reviewed-by: Alexander Mikhalitsyn > --- > =C2=A0include/linux/fs.h | 12 ++++++++++++ > =C2=A01 file changed, 12 insertions(+) >=20 > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 99caef43ff3c..407ffb6342ec 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -2553,6 +2553,18 @@ static inline const struct inode > *file_user_inode(const struct file *f) > =C2=A0 return file_inode(f); > =C2=A0} > =C2=A0 > +/* > + * Regular files on pseudo filesystems are kernel interfaces and > must not be > + * used as storage. Look through stacking filesystems at the inode > that > + * provides the data. > + */ > +static inline bool file_is_pseudo(const struct file *file) > +{ > + const struct inode *inode =3D d_real_inode(file- > >f_path.dentry); > + > + return S_ISREG(inode->i_mode) && (inode->i_sb->s_iflags & > SB_I_PSEUDO); > +} > + > =C2=A0static inline struct file *file_clone_open(struct file *file) > =C2=A0{ > =C2=A0 return dentry_open(&file->f_path, file->f_flags, file- > >f_cred);