From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4742C433E9 for ; Tue, 9 Mar 2021 16:44:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A144C6523C for ; Tue, 9 Mar 2021 16:44:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230081AbhCIQoT (ORCPT ); Tue, 9 Mar 2021 11:44:19 -0500 Received: from mga17.intel.com ([192.55.52.151]:14008 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229775AbhCIQoH (ORCPT ); Tue, 9 Mar 2021 11:44:07 -0500 IronPort-SDR: ITM4nVZfIi3kjUW/mTBMXIaKaOwoXlH+xHeZG9ftc82uV/JFiIKhDNo+0WwD7r1AQwqKdLaIUn Wa3kG88ir9Uw== X-IronPort-AV: E=McAfee;i="6000,8403,9917"; a="168189280" X-IronPort-AV: E=Sophos;i="5.81,236,1610438400"; d="scan'208";a="168189280" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2021 08:44:06 -0800 IronPort-SDR: tLqRxPfsQ4ayHmwBHR9QmVWRZcMJ+Gv44Fw9E8vQNISMoxrr47qKaTsANVlJd2yN/QFcziNzKt dASRy4EaMOKg== X-IronPort-AV: E=Sophos;i="5.81,236,1610438400"; d="scan'208";a="409806959" Received: from yoojae-mobl.amr.corp.intel.com (HELO [10.251.3.100]) ([10.251.3.100]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2021 08:44:06 -0800 Subject: Re: [PATCH 3/3] aspeed-video: add COMP_READY to VE_SPURIOUS_IRQS To: Joel Stanley , Zev Weiss , Ryan Chen Cc: Eddie James , Mauro Carvalho Chehab , Andrew Jeffery , linux-media@vger.kernel.org, OpenBMC Maillist , Linux ARM , linux-aspeed , Linux Kernel Mailing List References: <20201215024542.18888-1-zev@bewilderbeest.net> <20201215024542.18888-4-zev@bewilderbeest.net> From: Jae Hyun Yoo Message-ID: Date: Tue, 9 Mar 2021 08:43:58 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/21/2020 8:49 PM, Joel Stanley wrote: > On Tue, 15 Dec 2020 at 02:46, Zev Weiss wrote: >> >> This joins CAPTURE_COMPLETE and FRAME_COMPLETE in the set of interrupts >> that have been seen asserted by the hardware even when disabled, leading >> to the interrupt eventually getting disabled as described in commit >> 65d270acb2d662c3346793663ac3a759eb4491b8. >> >> Signed-off-by: Zev Weiss > > I have less experience with this part of the chip, so I defer to Jae > or Ryan for an ack. I didn't see unexpected VE_INTERRUPT_COMP_READY events in my system but it seems a fix good to have. Acked-by: Jae Hyun Yoo >> --- >> drivers/media/platform/aspeed-video.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c >> index 218aae3be809..48c52bf91a1b 100644 >> --- a/drivers/media/platform/aspeed-video.c >> +++ b/drivers/media/platform/aspeed-video.c >> @@ -564,7 +564,8 @@ static void aspeed_video_irq_res_change(struct aspeed_video *video, ulong delay) >> * register. >> */ >> #define VE_SPURIOUS_IRQS \ >> - (VE_INTERRUPT_CAPTURE_COMPLETE | VE_INTERRUPT_FRAME_COMPLETE) >> + (VE_INTERRUPT_CAPTURE_COMPLETE | VE_INTERRUPT_FRAME_COMPLETE \ >> + | VE_INTERRUPT_COMP_READY) >> >> static irqreturn_t aspeed_video_irq(int irq, void *arg) >> { >> -- >> 2.29.2 >>