From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDF35355F47 for ; Tue, 17 Mar 2026 09:20:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739231; cv=none; b=FZ0ebACAX3DHG0yk8rFD6vb4RPv6Upb8Uete88eVwKeiUIPLWABKFsVzyo5mNTWr3+s0axmDURCV27DDcrCM2H3Dv5fHCbbV0HNMuirJ/kaFXT+ic9l2r+B8SoWgEt7gzWw1kQZfvte9SyBUl8eA3ggNDm32ehSLHjMyMzi6KZE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739231; c=relaxed/simple; bh=iBniWLLZnukifzCJcu+oeWa0IDqnSCjoESx57tYs8JU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=S8niiudt+f/wYhAIJi3K+XLYTcwP1N5bIMNY04E5umrouFPykiAbmV4kBszr0c9/mvbMYCJrb0el/3pHUna5pdof1+v2pgRZ6sdRafaqbwCpaW+3eLZ36C/f1PAtnpspR4P3pOZXe/cm+pA20oQQjCpI0IzAUKdZ7Zfvzr6JSc4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ctOeVfXf; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UgNKGPel; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ctOeVfXf"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UgNKGPel" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62H97KcV3102507 for ; Tue, 17 Mar 2026 09:20:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nB8yW7oBg+ycexCmqJuKCMGqgJI/XCsDm+XFn5tPwmU=; b=ctOeVfXfm5OPrUt8 gpnCJeHMFjzsRsfwApv5JgkdVC/nvQkFZFYkfGkzAYCDS4YUjOfOhrBc1sbiWuoX mOzPiqPvBRFCWOF/pPZKHdQarUvM8Q8WOqpFbzVPbhnyejdKoyTYFzrwt+ESmFY+ CrwAleZipnL4LJ8wELa8EC4cH1X3BtKGNBTZBbAgptbTtHYMkhi62NP3o9Gf3idg sUnsXcSYAYRV+bvjLaNGpSx/Cm1dPlLnjdAGcrPJTmcpE+35PNj4wMgSVUSJ+kxG hpkhrYFPijZaGO5KaFpQFk67Ws1mFQIAj0cQPC3szM32WjEZvrgowOrBBjAoMVk6 yq4wIg== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxnb7b48r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Mar 2026 09:20:29 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b069bfa817so2704855ad.3 for ; Tue, 17 Mar 2026 02:20:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773739228; x=1774344028; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nB8yW7oBg+ycexCmqJuKCMGqgJI/XCsDm+XFn5tPwmU=; b=UgNKGPelcUCktwRFuaE1RH2Sn2WmgMTChsEjMild5nyrtadv5Cu6+0aBa2wMai1zr3 815sI9m4keLkGgKX/0sYp/Cz6v8QCl/BE0Dv3xpjzQR6w6YVzfH12QrOmZdrWegjPHXY TErjJiqYkUsOyjoxJ2ysKIKtZmlM8WOAzBRaOcH60KK9NiSRUaP7WfqX0uavZMsyQEj2 NOZtbHftWesyOcPQQ7lp47ahT9aDlxHDQc9lUJrBuKnRS3cKkO446TO8EgMaI03291Ve TkwfX1Rv+C+EEiExWz1QJNWF3JXBdRdpQEt2d4ABUo8puTTF2WwRiRehmV9lN6XisFgE aIxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773739228; x=1774344028; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nB8yW7oBg+ycexCmqJuKCMGqgJI/XCsDm+XFn5tPwmU=; b=QtkkJxAn/rwd1uiZmW7jJLrkFgyI5AB34TScyyosEJQbxK5Adj2s+UojnYMY3ACl9a YjakZ/IDV7AXr969Zr1DAHMmQxxusMIpj7h4NjuXsxReHaBJ0F/bYRCbxuhSWH6Rwdwf 3xn8Xu9kMT+3CelFVe/CuiGyEAPrqx/cgc1/8kKIACEOI7WzSGBHJdlc1reaoGgBRvE9 ZSNI+75jp0tqZRNEDCAY1jXU9vK0cjxH/k8Q0I9z6y3C565+CWAkCNVBUo74Z3w/Q267 76y/+lLMFjFBOBISRYMu/2+6exfzm9TJhX/lAxkqM9yl2YBuhHFx9Ai3GI2ui1LZ3qyf Shiw== X-Forwarded-Encrypted: i=1; AJvYcCW22MWgyAMmwbSymMciYbcC6njGbhBbhbTi/geArtgoc//IQeK3GERM1sIXn4esr3S5msor2DATfgrvIXs=@vger.kernel.org X-Gm-Message-State: AOJu0YyMQVO2UexT/+Yt+7/zbQzd+Ijc64OoG3bhe7PNfghvcWIj4ytr 3zYYnjNTV4RKioHIPW+nPhT+TcEvrIbGzW/Rl1pkJvcaSYLr0a1CUgzkHAz5s4qoIgfrHt+3X05 UA9jgm55bFO8WrQLqVUVOnws/1AT0mNQ+I+j0YUJlkq2S9yOD4lLALXWJVCALEoN5IYs= X-Gm-Gg: ATEYQzxJl/CZ5FgjI8ZBAnsnXVkSt5ktQWldFrg3smOeaOk0a1khph3cwUiYxqCZu7u PE4NcGj0D8YoZ906yXzPJyHouCqGxdKCkUTFJiYIlbsEsEw0NCwUZfjUn4RaOlT8cC8DHtORW95 EPwWJ6UOXuXRbuqc2nPvI1SVy17sVuPOl+7giJU/bMQL0GKt2Yb78gp+DYGnQEcABAA80PhKxB5 4F+KrpF+74Sopr8FnGc+IN19358gtHECS0B5e0fXEiwfg6FjTxrQw91NNPLfqsLGZdKLVwePTZT pclt/m/ax+EltjBMju6x/grWxBM+5LuUzhZXZgXDA4eX+NazX+zIlHm/9ZKIFBrMoXlK5nrtg2m nmb7PJ5gE3RJUDpdfbih+CuABSzM1b6a+3WoUBDPui1IyYNcFfoVJ51U3TfGYEOJGryQHnThMUi Zv2pR3/OtxrL7xUPpUOg== X-Received: by 2002:a17:902:ce10:b0:2b0:6b98:59ec with SMTP id d9443c01a7336-2b06b985bdamr41205ad.34.1773739228454; Tue, 17 Mar 2026 02:20:28 -0700 (PDT) X-Received: by 2002:a17:902:ce10:b0:2b0:6b98:59ec with SMTP id d9443c01a7336-2b06b985bdamr40945ad.34.1773739228006; Tue, 17 Mar 2026 02:20:28 -0700 (PDT) Received: from [10.133.33.139] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b04e5cb3dbsm105952865ad.25.2026.03.17.02.20.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2026 02:20:27 -0700 (PDT) Message-ID: Date: Tue, 17 Mar 2026 17:20:23 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] cpufreq: optimize policy_is_shared() To: Yury Norov , "Rafael J. Wysocki" , Viresh Kumar , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Yury Norov , zhongqiu.han@oss.qualcomm.com References: <20260314192544.605914-1-ynorov@nvidia.com> Content-Language: en-US From: Zhongqiu Han In-Reply-To: <20260314192544.605914-1-ynorov@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE3MDA4MiBTYWx0ZWRfX38urVLMW5EPR sJXOgLtYlgUPLHqeCYVdnicgBVa0Rbz62I+eHUTEVUhU+pZGGhDBzTrK/ClBmdgTokMuaj4tioI Szrobsx9K3wbtofo06+P2kBhy1bPcihXdDDi+lUXh/vB+6gQsrNs1SMAx6o9uJ2ZTq/m3/KXd8l ter2H3tCmvfiP0Oxo+aQvXxATyW3Ex+LzOZkSSYQ2CwBmreRVLS1S5N4ZLlkMEOPm80UjZLZSie MjWXUHA/4Beq7/igekyMN5gqABd9Vqp1q1Q3ZvPXQeIEQSI+g6R9IJueQ0O+nkCrO4Iv69FAAzf Y41bdhG6vLiPgl7XR7Kq7+dPnFyMBNYtszQ6ABaVQFC+C9WR8nuFDqVniNd2cIx4SKZ8boLILjS d9JsCCOOLDhSVP4EsUzsdmzb7jsbImmaMQ5O38ANmGRam8b3dotzF0mWO774pZ5Wtjc8Js74bnx sRXW+0Hfyx8lNJBzuAA== X-Authority-Analysis: v=2.4 cv=D7pK6/Rj c=1 sm=1 tr=0 ts=69b91cdd cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=Ikd4Dj_1AAAA:8 a=EUspDBNiAAAA:8 a=QQo5Q8axJbk09mazrB4A:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-ORIG-GUID: gMO05SLsla4--EUO0XZ5NbvqVllmhlV_ X-Proofpoint-GUID: gMO05SLsla4--EUO0XZ5NbvqVllmhlV_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-17_01,2026-03-16_06,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 clxscore=1015 suspectscore=0 spamscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603170082 On 3/15/2026 3:25 AM, Yury Norov wrote: > The switch to cpumask_nth() over cpumask_weight(), as it may return > earlier - as soon as the function counts the required number of CPUs. > > Signed-off-by: Yury Norov > --- > include/linux/cpufreq.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h > index cc894fc38971..8ca2bcb3d7ae 100644 > --- a/include/linux/cpufreq.h > +++ b/include/linux/cpufreq.h > @@ -232,7 +232,7 @@ static inline bool policy_is_inactive(struct cpufreq_policy *policy) > > static inline bool policy_is_shared(struct cpufreq_policy *policy) > { > - return cpumask_weight(policy->cpus) > 1; > + return cpumask_nth(1, policy->cpus) < nr_cpumask_bits; > } > > #ifdef CONFIG_CPU_FREQ Thanks. While I had a minor readability/API-nit earlier, I'm fine with the patch as-is. Reviewed-by: Zhongqiu Han -- Thx and BRs, Zhongqiu Han