mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Joerg Roedel <jroedel@suse.de>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Ingo Molnar <mingo@kernel.org>, Joerg Roedel <joro@8bytes.org>,
	x86@kernel.org, hpa@zytor.com,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Nikunj A Dadhania <nikunj@amd.com>,
	linux-kernel@vger.kernel.org, Larry.Dewey@amd.com
Subject: Re: [PATCH] x86/sev: Make SEV_STATUS available via SYSFS
Date: Wed, 5 Mar 2025 09:09:47 -0800	[thread overview]
Message-ID: <e2f9c22d-d09c-46b5-9695-a052859d04d2@intel.com> (raw)
In-Reply-To: <20250305165502.GLZ8iB5kAtQmW6fu1F@fat_crate.local>

On 3/5/25 08:55, Borislav Petkov wrote:
> On Wed, Mar 05, 2025 at 08:40:29AM -0800, Dave Hansen wrote:
>> TDX guests have CPUID to tell them that they're running that way.
> 
> And those CPUID leafs cannot be modified or intercepted or so by the
> hypervisor?

They are documented as coming straight from the TDX module when TDX is
in place. But there's nothing stopping an evil hypervisor from faking
them, except attestation.

>> We've just got X86_FEATUREs for hosts and guests:
>>
>> 	#define X86_FEATURE_TDX_HOST_PLATFORM ( 7*32+ 7)
>> 	#define X86_FEATURE_TDX_GUEST ( 8*32+22)
>>
>> and that's it.
> 
> And there are no new ones coming down the pipe?

Not really. There are always new features in the pipeline, but no real
fundamental changes to the threat model like SEV has had throughout its
iterations.

>> Folks certainly _want_ something in sysfs to dump the TDX module version
>> and so forth, but we've resisted the urge so far.
> 
> Perhaps now is the time do design something together...
> 
> I was thinking
> 
> /sys/guest/...
> 
> or something tied to the x86_platform gunk so that we can stick always some
> info there about any platform arch/x86/ has detected and is running on...

Xen has a bunch of gunk in:

	/sys/hypervisor

Joerg, why do folks care if they're running under SEV? What kind of
stuff are they doing after they do the rdmsr and see that SEV is in play?

  reply	other threads:[~2025-03-05 17:10 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-05 10:52 Joerg Roedel
2025-03-05 11:11 ` [tip: x86/sev] " tip-bot2 for Joerg Roedel
2025-03-05 11:12 ` [PATCH] " Borislav Petkov
2025-03-05 11:26   ` Ingo Molnar
2025-03-05 11:31     ` Borislav Petkov
2025-03-05 11:35       ` Juergen Gross
2025-03-05 11:41         ` Borislav Petkov
2025-03-05 11:48           ` Jürgen Groß
2025-03-05 11:53             ` Borislav Petkov
2025-03-05 11:42       ` Ingo Molnar
2025-03-05 11:50         ` Borislav Petkov
2025-03-05 13:56           ` Joerg Roedel
2025-03-05 15:37             ` Borislav Petkov
2025-03-05 16:37               ` Dave Hansen
2025-03-05 16:40               ` Dave Hansen
2025-03-05 16:55                 ` Borislav Petkov
2025-03-05 17:09                   ` Dave Hansen [this message]
2025-03-05 17:51                     ` Joerg Roedel
2025-03-05 20:07                     ` Borislav Petkov
2025-03-06  8:01                 ` Kirill A. Shutemov
2025-03-06  8:38                   ` Joerg Roedel
2025-03-06 10:31                     ` Borislav Petkov
2025-03-06 13:36                       ` Kirill A. Shutemov
2025-03-06 13:56                         ` Borislav Petkov
2025-03-06 10:37                     ` Alexey Gladkov (Intel)
2025-03-10 10:28                       ` Joerg Roedel
2025-03-10 11:02                         ` Borislav Petkov
2025-03-10 12:46                           ` Joerg Roedel
2025-03-10 13:36                             ` Borislav Petkov
2025-03-10 11:24                         ` Alexey Gladkov
2025-03-10 12:28                           ` Juergen Gross
2025-03-10 12:35                             ` Joerg Roedel
2025-03-10 12:49                               ` Juergen Gross
2025-03-10 13:38                                 ` Borislav Petkov
2025-03-10 14:39                                   ` Tom Lendacky
2025-03-10 14:50                                   ` Alexey Gladkov
2025-03-10 15:11                                     ` Borislav Petkov
2025-03-10 15:33                                       ` Jürgen Groß
2025-03-10 15:41                                         ` Borislav Petkov
2025-03-10 15:50                                           ` Alexey Gladkov
2025-03-10 15:43                                         ` Alexey Gladkov
2025-03-10 15:52                                           ` Juergen Gross
2025-03-10 15:55                                             ` Borislav Petkov
2025-03-10 16:00                                               ` Juergen Gross
2025-03-10 16:06                                                 ` Borislav Petkov
2025-03-10 16:23                                                   ` Jürgen Groß
2025-03-10 16:05                                             ` Alexey Gladkov
2025-03-11  9:43                                           ` Joerg Roedel
2025-03-11 10:22                                             ` Jürgen Groß
2025-03-11 11:07                                               ` Borislav Petkov
2025-03-11 11:14                                                 ` Juergen Gross
2025-03-11 18:24                                                 ` Alexey Gladkov
2025-03-11 18:40                                                   ` Joerg Roedel
2025-03-11 20:37                                                     ` Alexey Gladkov
2025-03-12  7:19                                                     ` Kirill A. Shutemov
2025-03-12  8:23                                                       ` Joerg Roedel
2025-03-12  8:48                                                         ` Kirill A. Shutemov
2025-03-12  9:07                                                           ` Joerg Roedel
2025-03-12 10:59                                                             ` Kirill A. Shutemov
2025-03-12 11:44                                                               ` Joerg Roedel
2025-03-11 18:13                                             ` Alexey Gladkov
2025-03-05 13:50 ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e2f9c22d-d09c-46b5-9695-a052859d04d2@intel.com \
    --to=dave.hansen@intel.com \
    --cc=Larry.Dewey@amd.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=joro@8bytes.org \
    --cc=jroedel@suse.de \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=nikunj@amd.com \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®