From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 699ED188713 for ; Mon, 2 Mar 2026 00:15:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772410555; cv=none; b=Ozf9XlOHilVxH3JAxVRdNWhmSz/sF8E2lAXW9i+RHneBmflJ7ESi0cjXdtP75z4fDHKdJssvGJeUk78lG56m/7JuA7loQz4AOn5pZnmtt5og2P3GvbroSmTWUapnnd9sUKEGKZDTpU19PJLjH88fh45NtMdMi3FGpjYlDpaG9M0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772410555; c=relaxed/simple; bh=ybW7ZGIqp8Cj3D0c1tJ/QKxtNDpqm5IigPIVWWekitU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=txafjYXKPY4vMWNFpgQjUao3xiU5BIsEerjsdx0CEVT0XpCUfmReHYGCc1FXlJE+DEykQ8F3Tn3DSux2RcQmiIGJpqJRVq5WPrTWOkzmUJyGax8jVf/q+Ku0PtZjkUVtjsMJ0vbFz8Y5YLwEhup1cPRIx/z8DthexHeQt4bKlUo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CLibOj35; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fnAIchRr; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CLibOj35"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fnAIchRr" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 621JJmM63209978 for ; Mon, 2 Mar 2026 00:15:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= oBZuljD/+5TcXwhWoGNRFrGUV3OJ0gks35QtMWEwRDI=; b=CLibOj358az11iNu my+7sfE+tfLmzugD6ZsrX+Fz/sytJJuWg3AM8HkNW6shh6zg0EdFjQnDOSt5W8eE NYe227IFbhhsRnUD1jUTl0pwBWJtCFXAIo2n+dgUe7+hT1CqToItVHx5JjqfIfSU /ltgdt3b1Aunpxqxvkvbp7mjVv/fCNOMQ2Oi/8pe3+QVyC5pmYV/0cNOwxWt+LWu k0bMSUvD32CSNVgkf9ruC+5l2YQUyBv5fXXPW3sEwu+SClFmj/w2ZcOX86NDaYqp IJA1yxik+c5bEvTsUfLZ5DRWsu7lQ3Ww2MrVy9iiuknpCi9dmfp/nn2J6IhcD1ur ya9GdQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cksfyud9q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Mar 2026 00:15:53 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2aae146bab0so55253395ad.0 for ; Sun, 01 Mar 2026 16:15:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772410552; x=1773015352; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oBZuljD/+5TcXwhWoGNRFrGUV3OJ0gks35QtMWEwRDI=; b=fnAIchRr+ufq/YvbWpG3p9iRB5o2POSY3Ql909hhcF0NQVk7WqkJsV5irPmVGfDnKJ aX5pKYc4ZxZI4WbGTb34VKfxgWy5otHyWpYiio4gj8qkJ+03hgaeZpq5qdKzJXtKwQTM E3m2CBwG8FKKeQoo5hts9EvGHKxqSDRNIGLr48h75bnSViVfbZn7eGdNKqEPUktCQrgk MouNxAVccoL1X6r3VtlQRbul8B+U5MTNLiACX5VBvODwyBdhj+9VS9ass/BlituNKgeQ eO7Fe+JZj7PPCVYIoLte4CjXfK/SRiKdKqvslnmHdE5j7qWeM+qFnMjzG4glg8Ws4ehv wBVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772410552; x=1773015352; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oBZuljD/+5TcXwhWoGNRFrGUV3OJ0gks35QtMWEwRDI=; b=W2dMVH/JLY9kFeTPgVeJfM3QZfFFkCm9ClYMs5G4fKW8V2p+dAT8RLf0/J/di2ZBOq FaYNoGIDx5ZlCCjki834+0stcmd+a5BvUygsdxbUfGihIjTt/C96ciS1AlDOxfvxlkke ZPujDsUdCRP5RJDvZMdvzcrznvDLutX33LS5GdMCjGLSv07CBDuX3W2dQ82XWX37PCuc /SriqViEs5KH9gzIVxq1B4Ui9yTIOtATAoNZVooAWrhUHtV9B/tjIyJtG1Li79Xa5XLJ 074KxopTpPIOwME1nXI/6lnzkwg7FRNuPpdrXmsDtLbmGzRYObi0VfWIs9vPiQdy3u2w x1cA== X-Forwarded-Encrypted: i=1; AJvYcCX98vdpWIiLUjVpe9D/SoGJ9g13nZMK+l55f4Luq7/Nm+hdNL112F0hrERu/WA2EJ2qPHQmuaBmx8C77dg=@vger.kernel.org X-Gm-Message-State: AOJu0YzuqKhGfd83Wzz387MNqLgDfSaJJ6hqN51zUY8qLTCgVbEByZSb EVF/KCcvF9cpmP6ItOnAXzvW4EqEq9/9enpeBEj0NQWkP5T7R2Kcj8yDh0KOri/FZeiO2BDCov4 FWlmpwJ3M50/pxiY2SsiZ0QCVb9YKKY0z+oR7A6fcpKmlnA+kFobK33bbbLm2vO6Cnm0= X-Gm-Gg: ATEYQzxCsSzMPdJXDuvdzywFWyX3HSk/MDNC2aVTv4pvNAJrlSaRIzmyosI/oiEZgGj o8v3SuKLBORzGYlHyzUY6vy10xMsCJe+ZYDN2YR+D+3C+Gfny5tesVJX5Rsdq1mSCSoeVfaW1N8 q62NNd9kwgt38O/AdsXqOitjmgFArmlN7+eT9Byl7aO1emsyhaHTey6MqfRsB6rWeSr/2/k7inS bbQDnzjv/TX2F+iUx0lm+oz2lUM/vO29jU2QZNpL0hzg4RvlEGSUtsjMEJ2+b/JNCabVFAiyLj4 y6/aHat8qiI92psIC0fxzkHFaHVl/kfeWVsrC3uj+9aigthxdZvpIo7y+PZ1feYI5VHH3RekJ6w Xy1oxf8dvC/MCEN8PP2vjCxy31057czYMXsMfzNGyPcQ0h8Q= X-Received: by 2002:a17:903:3804:b0:2ae:3b36:23e7 with SMTP id d9443c01a7336-2ae3b3629c3mr58201065ad.16.1772410552094; Sun, 01 Mar 2026 16:15:52 -0800 (PST) X-Received: by 2002:a17:903:3804:b0:2ae:3b36:23e7 with SMTP id d9443c01a7336-2ae3b3629c3mr58200545ad.16.1772410551609; Sun, 01 Mar 2026 16:15:51 -0800 (PST) Received: from [192.168.0.102] ([183.193.18.168]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb6c4dd0sm120565185ad.70.2026.03.01.16.15.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Mar 2026 16:15:50 -0800 (PST) Message-ID: Date: Mon, 2 Mar 2026 08:15:42 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/11] scsi: ufs: core: Introduce a new ufshcd vops negotiate_pwr_mode() To: Bart Van Assche , avri.altman@wdc.com, beanhuo@micron.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, Alim Akhtar , "James E.J. Bottomley" , Sai Krishna Potthuri , Ajay Neeli , Peter Griffin , Krzysztof Kozlowski , Peter Wang , Chaotian Jing , Stanley Jhu , Manivannan Sadhasivam , Orson Zhai , Baolin Wang , Chunyan Zhang , Matthias Brugger , AngeloGioacchino Del Regno , "Bao D. Nguyen" , Adrian Hunter , Archana Patni , open list , "open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER..." , "moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , "moderated list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER..." , "open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER..." References: <20260227160809.2620598-1-can.guo@oss.qualcomm.com> <20260227160809.2620598-2-can.guo@oss.qualcomm.com> <9d975881-7570-495d-94ea-085e2012a9af@acm.org> <5a2961af-dada-44f3-8e57-119076f10750@oss.qualcomm.com> <3abcef32-f872-4aa5-a7e1-c99286f426aa@acm.org> Content-Language: en-US From: Can Guo In-Reply-To: <3abcef32-f872-4aa5-a7e1-c99286f426aa@acm.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAyMDAwMCBTYWx0ZWRfXz95x64ZP0Sl7 2w4RY8WlNUPCp9az8ux3ZMYawB4zOOjNSzAQ8FXdm6kuA/EgFCLBOf5dE6Gl9iIlPq7iRvtm/xR 2YBD4W5stwDvNwc/XsR2/xAsqwMAfWG1w5LEOgZNeH9K6dRlIHAm5MQZehv8vOO6BILBnI774Bm Ob71mXIVgU3W40Hiayrmpl68Jw7PdrRfNvkgynxy2cotw9WsXVY9P1K1JaqnpsU4Ab3AZEiMwtZ 9/ceJy8BSpTQ7fypzIEaVF1Gt4iWtKqHOeNpbr8KViDThGXaRHNbxVfsy/0Sy7iBzwT5zL+xHV4 bUghlCxc4xlZ6kMdDz+9HncX1vqHDvhKhRq3C0LuVYsaHEDhIY+pJF+PlIlbukzBouAvbKUV4Ww wq+7LuKOj1XLndbGzQFfExPOjSk4xpFgG3loNkOgmQ8YhrDaUiIsPkYc/a4fA4G+BwBCVQMin7y VinhVEkDTNo6z5buGew== X-Authority-Analysis: v=2.4 cv=avS/yCZV c=1 sm=1 tr=0 ts=69a4d6b9 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=4/OApUm1v7sVY8kc7hZvWg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=3hymWB_5rKpTfOV4Hd4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-GUID: yaAjVRXrUS-aWgdE-geWgxFNxBNqzqQi X-Proofpoint-ORIG-GUID: yaAjVRXrUS-aWgdE-geWgxFNxBNqzqQi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-01_05,2026-02-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 impostorscore=0 clxscore=1015 suspectscore=0 phishscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603020000 Hi Bart, On 3/2/2026 1:51 AM, Bart Van Assche wrote: > On 3/1/26 6:26 AM, Can Guo wrote: >> On 2/28/2026 3:31 AM, Bart Van Assche wrote: >>> On 2/27/26 8:07 AM, Can Guo wrote: >>>> -    return -ENOTSUPP; >>>> +    return -EOPNOTSUPP; >>> >>> Why has ENOTSUPP been changed into EOPNOTSUPP? >> I got a warning from checkpatch.pl when I add the new vops, so I >> changed the same for >> ufshcd_vops_pwr_change_notify() too. >> >> WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP > Hi Can, > > SUSv4 = Single UNIX Specification, Version 4. This is a standard that > defines how system calls should behave. Hence, ENOTSUPP must not be > returned as an error value by e.g. sysfs callbacks. As far as I know the > ufshcd_vops_pwr_change_notify() return value is never returned to user > space and hence returning ENOTSUPP from inside this function is fine. > > If you want to keep this change in ufshcd_vops_pwr_change_notify() > please make it a separate patch. Thanks for the info. I will use ENOTSUPP in next version. Best Regards, Can Guo. > > Thanks, > > Bart.